Attachment 356474 Details for Bug 192354 – Patch

[patch] Patch

bug-192354-20181203233015.patch (text/plain), 1.98 KB, created by Matt Baker on 2018-12-03 23:30:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-12-03 23:30:22 PST

Size: 1.98 KB

patch

obsolete

>Subversion Revision: 238828
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index cc8eb918ab1c5e85a759d525bfb0b155b99549ed..550ba64a8c3fe4758b8b165ecfa45af24cc4d2fe 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-03  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
>+        https://bugs.webkit.org/show_bug.cgi?id=192354
>+        <rdar://problem/46444438>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline.prototype._treeKeyDown):
>+        (WI.TreeOutline.prototype._handleMouseDown):
>+
> 2018-12-03  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Elements: $0 is shown for all selected elements
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 96f495717fd340ffb487798750caf6b190ef326d..c2c97a54172589d78d5d190cb870f24316b38c25 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -608,8 +608,11 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>                 handled = this.treeOutline.onspace(this.selectedTreeElement);
>         }
> 
>-        if (!handled)
>+        if (!handled) {
>+            this._itemWasSelectedByUser = true;
>             handled = this._selectionController.handleKeyDown(event);
>+            this._itemWasSelectedByUser = false;
>+        }
> 
>         if (nextSelectedElement) {
>             nextSelectedElement.reveal();
>@@ -999,7 +1002,9 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         if (isNaN(index))
>             return;
> 
>+        this._itemWasSelectedByUser = true;
>         this._selectionController.handleItemMouseDown(index, event);
>+        this._itemWasSelectedByUser = false;
>     }
> 
>     _indexOfTreeElement(treeElement)

Actions: View | Formatted Diff | Diff

Attachments on bug 192354: 356474