Attachment 356454 Details for Bug 192346 – Patch

[patch] Patch

bug-192346-20181203205705.patch (text/plain), 2.53 KB, created by Devin Rousso on 2018-12-03 20:57:05 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-03 20:57:05 PST

Size: 2.53 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index a8672f0e4ea916ffe55d12df13f8ccaf8b516af5..9bc967288dd7564139da4463be1cc6536c5360ee 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-03  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Audit: save the expanded state of test groups
>+        https://bugs.webkit.org/show_bug.cgi?id=192346
>+        <rdar://problem/46440704>
>+
>+        Reviewed by Matt Baker.
>+
>+        * UserInterface/Views/AuditTreeElement.js:
>+        (WI.AuditTreeElement):
>+        (WI.AuditTreeElement.prototype.onattach):
>+        (WI.AuditTreeElement.prototype.onexpand): Added.
>+        (WI.AuditTreeElement.prototype.oncollapse): Added.
>+
> 2018-12-03  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: "Add Default Audits" shown when there are no filter results
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js
>index 6976376e83e467b0cbb911e099d8df6e1466b9b7..2015b6ad6ac35287b12facce74255287488f4262 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js
>@@ -49,6 +49,9 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
> 
>         const subtitle = null;
>         super(classNames, representedObject.name, subtitle, representedObject, options);
>+
>+        if (isTestGroup)
>+            this._expandedSetting = new WI.Setting(`audit-tree-element-${this.representedObject.name}-expanded`, false);
>     }
> 
>     // Protected
>@@ -66,6 +69,9 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
>                 this.representedObject.addEventListener(WI.AuditTestBase.Event.Scheduled, this._handleTestGroupScheduled, this);
>         }
> 
>+        if (this._expandedSetting && this._expandedSetting.value)
>+            this.expand();
>+
>         this._updateLevel();
>     }
> 
>@@ -96,6 +102,22 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
>         }
>     }
> 
>+    onexpand()
>+    {
>+        console.assert(this.expanded);
>+
>+        if (this._expandedSetting)
>+            this._expandedSetting.value = this.expanded;
>+    }
>+
>+    oncollapse()
>+    {
>+        console.assert(!this.expanded);
>+
>+        if (this._expandedSetting)
>+            this._expandedSetting.value = this.expanded;
>+    }
>+
>     ondelete()
>     {
>         if (!(this.representedObject instanceof WI.AuditTestBase))

Actions: View | Formatted Diff | Diff

Attachments on bug 192346: 356449 | 356454