WebKit Bugzilla
Attachment 356449 Details for
Bug 192346
: Web Inspector: Audit: save the expanded state of test groups
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192346-20181203193715.patch (text/plain), 2.54 KB, created by
Devin Rousso
on 2018-12-03 19:37:16 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2018-12-03 19:37:16 PST
Size:
2.54 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index a8672f0e4ea916ffe55d12df13f8ccaf8b516af5..e44048d4e7163677d39f2b91060a8df9f54a19be 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,17 @@ >+2018-12-03 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Audit: save the expanded state of test groups >+ https://bugs.webkit.org/show_bug.cgi?id=192346 >+ <rdar://problem/46440704> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/AuditTreeElement.js: >+ (WI.AuditTreeElement): >+ (WI.AuditTreeElement.prototype.onattach): >+ (WI.AuditTreeElement.prototype.onexpand): Added. >+ (WI.AuditTreeElement.prototype.oncollapse): Added. >+ > 2018-12-03 Devin Rousso <drousso@apple.com> > > Web Inspector: Audit: "Add Default Audits" shown when there are no filter results >diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js >index 6976376e83e467b0cbb911e099d8df6e1466b9b7..a774549ae6528da3b8b69c92e25e0db0c76b5f6b 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js >+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js >@@ -49,6 +49,9 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement > > const subtitle = null; > super(classNames, representedObject.name, subtitle, representedObject, options); >+ >+ if (isTestGroup) >+ this._expandedSetting = new WI.Setting("audit-tree-element-" + this.representedObject.name + "-expanded", false); > } > > // Protected >@@ -66,6 +69,9 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement > this.representedObject.addEventListener(WI.AuditTestBase.Event.Scheduled, this._handleTestGroupScheduled, this); > } > >+ if (this._expandedSetting && this._expandedSetting.value) >+ this.expand(); >+ > this._updateLevel(); > } > >@@ -96,6 +102,22 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement > } > } > >+ onexpand() >+ { >+ console.assert(this.expanded); >+ >+ if (this._expandedSetting) >+ this._expandedSetting.value = this.expanded; >+ } >+ >+ oncollapse() >+ { >+ console.assert(!this.expanded); >+ >+ if (this._expandedSetting) >+ this._expandedSetting.value = this.expanded; >+ } >+ > ondelete() > { > if (!(this.representedObject instanceof WI.AuditTestBase))
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192346
:
356449
|
356454