Attachment 356446 Details for Bug 192341 – Patch

[patch] Patch

bug-192341-20181203190740.patch (text/plain), 4.25 KB, created by Devin Rousso on 2018-12-03 19:07:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-03 19:07:41 PST

Size: 4.25 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index a8672f0e4ea916ffe55d12df13f8ccaf8b516af5..be77ff78cffa9a13fbfb644cedb30bc361883dd3 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-12-03  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Audit: sidebar briefly shows "No Filter Results" before populating default audits
>+        https://bugs.webkit.org/show_bug.cgi?id=192341
>+        <rdar://problem/46436550>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/AuditNavigationSidebarPanel.js:
>+        (WI.AuditNavigationSidebarPanel.prototype.initialLayout):
>+        (WI.AuditNavigationSidebarPanel.prototype._addTest):
>+        (WI.AuditNavigationSidebarPanel.prototype._addResult):
>+        (WI.AuditNavigationSidebarPanel.prototype.applyFiltersToTreeElement): Deleted.
>+        Delay the construction of the "Results" folder until it's needed, since adding a hidden
>+        `WI.TreeElement` will cause the placeholder to appear.
>+
> 2018-12-03  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: "Add Default Audits" shown when there are no filter results
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js
>index a3adf2c184d611f268be3d5eb8bd2f8708d98c63..1186bfae87e0afc77f7e8ad450e234fd7a80efff 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js
>@@ -57,11 +57,6 @@ WI.AuditNavigationSidebarPanel = class AuditNavigationSidebarPanel extends WI.Na
> 
>         this.contentTreeOutline.allowsRepeatSelection = false;
> 
>-        this._resultsFolderTreeElement = new WI.FolderTreeElement(WI.UIString("Results"));
>-        this.contentTreeOutline.appendChild(this._resultsFolderTreeElement);
>-        this._resultsFolderTreeElement.hidden = true;
>-        this._resultsFolderTreeElement.expand();
>-
>         let navigationBar = new WI.NavigationBar;
> 
>         this._startStopButtonNavigationItem = new WI.ToggleButtonNavigationItem("audit-start-stop", WI.UIString("Start"), WI.UIString("Stop"), "Images/AuditStart.svg", "Images/AuditStop.svg", 13, 13);
>@@ -109,14 +104,6 @@ WI.AuditNavigationSidebarPanel = class AuditNavigationSidebarPanel extends WI.Na
>             this._updateNoAuditsPlaceholder();
>     }
> 
>-    applyFiltersToTreeElement(treeElement)
>-    {
>-        super.applyFiltersToTreeElement(treeElement);
>-
>-        if (treeElement === this._resultsFolderTreeElement && !WI.auditManager.results.length)
>-            this._resultsFolderTreeElement.hidden = true;
>-    }
>-
>     // Private
> 
>     _addTest(test)
>@@ -125,9 +112,13 @@ WI.AuditNavigationSidebarPanel = class AuditNavigationSidebarPanel extends WI.Na
> 
>         this._updateStartStopButtonNavigationItemState();
> 
>-        this.contentTreeOutline.insertChild(new WI.AuditTreeElement(test), this.contentTreeOutline.children.indexOf(this._resultsFolderTreeElement));
>+        let treeElement = new WI.AuditTreeElement(test);
> 
>-        this._resultsFolderTreeElement.hidden = !this._resultsFolderTreeElement.children.length;
>+        if (this._resultsFolderTreeElement) {
>+            this.contentTreeOutline.insertChild(treeElement, this.contentTreeOutline.children.indexOf(this._resultsFolderTreeElement));
>+            this._resultsFolderTreeElement.hidden = !this._resultsFolderTreeElement.children.length;
>+        } else
>+            this.contentTreeOutline.appendChild(treeElement);
> 
>         this.hideEmptyContentPlaceholder();
>     }
>@@ -138,7 +129,12 @@ WI.AuditNavigationSidebarPanel = class AuditNavigationSidebarPanel extends WI.Na
> 
>         this._updateStartStopButtonNavigationItemState();
> 
>-        this._resultsFolderTreeElement.hidden = false;
>+        if (!this._resultsFolderTreeElement) {
>+            this._resultsFolderTreeElement = new WI.FolderTreeElement(WI.UIString("Results"));
>+            this.contentTreeOutline.appendChild(this._resultsFolderTreeElement);
>+        }
>+
>+        this._resultsFolderTreeElement.expand();
> 
>         let resultFolderTreeElement = new WI.FolderTreeElement(WI.UIString("Run %d").format(index + 1));
>         if (result instanceof WI.AuditTestResultBase) {

Actions: View | Formatted Diff | Diff

Attachments on bug 192341: 356446