Attachment 356422 Details for Bug 192336 – Patch

[patch] Patch

bug-192336.diff (text/plain), 5.98 KB, created by Don Olmstead on 2018-12-03 15:36:39 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2018-12-03 15:36:39 PST

Size: 5.98 KB

patch

obsolete

>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 878d824bcd6..11ab7f50788 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-03  Don Olmstead  <don.olmstead@sony.com>
>+
>+        Fix some unused parameter warnings
>+        https://bugs.webkit.org/show_bug.cgi?id=192336
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/StackTrace.cpp:
>+        (WTFGetBacktrace):
>+        (WTF::StackTrace::demangle):
>+        * wtf/generic/MemoryPressureHandlerGeneric.cpp:
>+        (WTF::MemoryPressureHandler::platformReleaseMemory):
>+        (WTF::MemoryPressureHandler::holdOff):
>+        (WTF::MemoryPressureHandler::respondToMemoryPressure):
>+
> 2018-12-01  Alexey Proskuryakov  <ap@apple.com>
> 
>         Modernize version check for _suppressedAutoAddedHTTPHeaders
>diff --git a/Source/WTF/wtf/StackTrace.cpp b/Source/WTF/wtf/StackTrace.cpp
>index becf22ae0aa..c41dec00601 100644
>--- a/Source/WTF/wtf/StackTrace.cpp
>+++ b/Source/WTF/wtf/StackTrace.cpp
>@@ -51,6 +51,7 @@ void WTFGetBacktrace(void** stack, int* size)
> #elif OS(WINDOWS)
>     *size = RtlCaptureStackBackTrace(0, *size, stack, 0);
> #else
>+    UNUSED_PARAM(stack);
>     *size = 0;
> #endif
> }
>@@ -100,6 +101,8 @@ auto StackTrace::demangle(void* pc) -> std::optional<DemangleEntry>
>     }
>     if (mangledName || cxaDemangled)
>         return DemangleEntry { mangledName, cxaDemangled };
>+#else
>+    UNUSED_PARAM(pc);
> #endif
>     return std::nullopt;
> }
>diff --git a/Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp b/Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp
>index db897c69214..25fafbd468f 100644
>--- a/Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp
>+++ b/Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp
>@@ -28,8 +28,9 @@
> 
> namespace WTF {
> 
>-void MemoryPressureHandler::platformReleaseMemory(Critical)
>+void MemoryPressureHandler::platformReleaseMemory(Critical critical)
> {
>+    UNUSED_PARAM(critical);
> }
> 
> void MemoryPressureHandler::install()
>@@ -42,10 +43,13 @@ void MemoryPressureHandler::uninstall()
> 
> void MemoryPressureHandler::holdOff(Seconds seconds)
> {
>+    UNUSED_PARAM(seconds);
> }
> 
> void MemoryPressureHandler::respondToMemoryPressure(Critical critical, Synchronous synchronous)
> {
>+    UNUSED_PARAM(critical);
>+    UNUSED_PARAM(synchronous);
> }
> 
> std::optional<MemoryPressureHandler::ReliefLogger::MemoryUsage> MemoryPressureHandler::ReliefLogger::platformMemoryUsage()
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 734882a6b79..32354b39c76 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-12-03  Don Olmstead  <don.olmstead@sony.com>
>+
>+        Fix some unused parameter warnings
>+        https://bugs.webkit.org/show_bug.cgi?id=192336
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * Modules/indexeddb/server/IDBSerialization.cpp:
>+        (WebCore::isLegacySerializedIDBKeyData):
>+        * platform/FileSystem.cpp:
>+        (WebCore::FileSystem::openAndLockFile):
>+        * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
>+        (WebCore::GraphicsContext3D::bindVertexArray):
>+        * platform/network/curl/CertificateInfo.h:
>+        (WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
>+        (WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
>+
> 2018-12-03  Zalan Bujtas  <zalan@apple.com>
> 
>         [iOS] Add logging channel for hover related content observation
>diff --git a/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp b/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp
>index 98d09be1c5e..a5f02922519 100644
>--- a/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp
>+++ b/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp
>@@ -114,6 +114,9 @@ static bool isLegacySerializedIDBKeyData(const uint8_t* data, size_t size)
>     GRefPtr<GBytes> bytes = adoptGRef(g_bytes_new(data, size));
>     GRefPtr<GVariant> variant = g_variant_new_from_bytes(G_VARIANT_TYPE("a{sv}"), bytes.get(), FALSE);
>     return g_variant_is_normal_form(variant.get());
>+#else
>+    UNUSED_PARAM(data);
>+    UNUSED_PARAM(size);
> #endif
>     return false;
> }
>diff --git a/Source/WebCore/platform/FileSystem.cpp b/Source/WebCore/platform/FileSystem.cpp
>index a77998ccf20..ed9d37aaa13 100644
>--- a/Source/WebCore/platform/FileSystem.cpp
>+++ b/Source/WebCore/platform/FileSystem.cpp
>@@ -339,6 +339,8 @@ PlatformFileHandle openAndLockFile(const String& path, FileOpenMode openMode, Op
> #if USE(FILE_LOCK)
>     bool locked = lockFile(handle, lockMode);
>     ASSERT_UNUSED(locked, locked);
>+#else
>+    UNUSED_PARAM(lockMode);
> #endif
> 
>     return handle;
>diff --git a/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp b/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>index d71711ad2d2..eb93bc09343 100644
>--- a/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>+++ b/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>@@ -1579,6 +1579,8 @@ void GraphicsContext3D::bindVertexArray(Platform3DObject array)
>     makeContextCurrent();
> #if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
>     ::glBindVertexArray(array);
>+#else
>+    UNUSED_PARAM(array);
> #endif
> }
> 
>diff --git a/Source/WebCore/platform/network/curl/CertificateInfo.h b/Source/WebCore/platform/network/curl/CertificateInfo.h
>index 758ecba0034..f1f45389ced 100644
>--- a/Source/WebCore/platform/network/curl/CertificateInfo.h
>+++ b/Source/WebCore/platform/network/curl/CertificateInfo.h
>@@ -73,11 +73,15 @@ namespace Persistence {
> template<> struct Coder<WebCore::CertificateInfo> {
>     static void encode(Encoder& encoder, const WebCore::CertificateInfo& certificateInfo)
>     {
>+        UNUSED_PARAM(encoder);
>+        UNUSED_PARAM(certificateInfo);
>         notImplemented();
>     }
> 
>     static bool decode(Decoder& decoder, WebCore::CertificateInfo& certificateInfo)
>     {
>+        UNUSED_PARAM(decoder);
>+        UNUSED_PARAM(certificateInfo);
>         notImplemented();
>         return false;
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 192336: 356422 | 356423 | 356430