Attachment 356387 Details for Bug 192298 – Patch

[patch] Patch

bug-192298-20181203111022.patch (text/plain), 34.57 KB, created by Ross Kirsling on 2018-12-03 11:10:23 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-12-03 11:10:23 PST

Size: 34.57 KB

patch

obsolete

>Subversion Revision: 238800
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 602809822d2b14a0fac8bf7c2dc0087b264f4079..d2791c6d5a16ed854ef871181eeb3a569ec2c3b9 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-12-02  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        Redeclaration of var over let/const/class should be a syntax error.
>+        https://bugs.webkit.org/show_bug.cgi?id=192298
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        From https://tc39.github.io/ecma262/#sec-block-static-semantics-early-errors:
>+        It is a Syntax Error if any element of the LexicallyDeclaredNames of StatementList also occurs in the
>+        VarDeclaredNames of StatementList.
>+
>+        As the title suggests, this patch just handles the { let x; var x; } scenario;
>+        it does not specifically cover { var x; let x; } or shadowed function declarations.
>+
>+        * parser/Parser.h:
>+        (JSC::Scope::declareVariable):
>+        (JSC::Scope::declareLexicalVariable):
>+        (JSC::Parser::declareVariable):
>+        Currently, we're erroneously checking currentVariableScope for lexical variables.
>+        Instead, we can immediately validate currentLexicalDeclarationScope, since var/let/const all need to do so.
>+
> 2018-12-02  Zalan Bujtas  <zalan@apple.com>
> 
>         Add a runtime feature flag for LayoutFormattingContext.
>diff --git a/Source/JavaScriptCore/parser/Parser.h b/Source/JavaScriptCore/parser/Parser.h
>index 6533ef9be86179eeb9a5c581adba7e06bf640892..564f1260c937049a92ed31edd76351eb7e15ab13 100644
>--- a/Source/JavaScriptCore/parser/Parser.h
>+++ b/Source/JavaScriptCore/parser/Parser.h
>@@ -354,8 +354,6 @@ public:
>         addResult.iterator->value.setIsVar();
>         if (!isValidStrictMode)
>             result |= DeclarationResult::InvalidStrictMode;
>-        if (m_lexicalVariables.contains(ident->impl()))
>-            result |= DeclarationResult::InvalidDuplicateDeclaration;
>         return result;
>     }
> 
>@@ -421,8 +419,6 @@ public:
>             addResult.iterator->value.setIsImportedNamespace();
>         }
> 
>-        if (!addResult.isNewEntry)
>-            result |= DeclarationResult::InvalidDuplicateDeclaration;
>         if (!isValidStrictMode)
>             result |= DeclarationResult::InvalidStrictMode;
> 
>@@ -1211,6 +1207,9 @@ private:
>     
>     DeclarationResultMask declareVariable(const Identifier* ident, DeclarationType type = DeclarationType::VarDeclaration, DeclarationImportType importType = DeclarationImportType::NotImported)
>     {
>+        if (currentLexicalDeclarationScope()->lexicalVariables().contains(ident->impl()))
>+            return DeclarationResult::InvalidDuplicateDeclaration;
>+
>         if (type == DeclarationType::VarDeclaration)
>             return currentVariableScope()->declareVariable(ident);
> 
>diff --git a/JSTests/ChakraCore/test/LetConst/defer3.baseline-jsc b/JSTests/ChakraCore/test/LetConst/defer3.baseline-jsc
>index 1a57ef271d192e81d108e9029585014380bd60e9..24c2900623df734cbb607b20452c9ba4e1ca54f6 100644
>--- a/JSTests/ChakraCore/test/LetConst/defer3.baseline-jsc
>+++ b/JSTests/ChakraCore/test/LetConst/defer3.baseline-jsc
>@@ -30,8 +30,8 @@ SyntaxError: Cannot declare a var variable that shadows a let/const/class variab
> SyntaxError: Cannot declare a var variable that shadows a let/const/class variable: 'x'.
> Syntax check succeeded
> Syntax check succeeded
>-Syntax check succeeded
>-Syntax check succeeded
>+SyntaxError: Cannot declare a var variable that shadows a let/const/class variable: 'x'.
>+SyntaxError: Cannot declare a var variable that shadows a let/const/class variable: 'x'.
> SyntaxError: Cannot declare a const variable twice: 'x'.
> SyntaxError: Cannot declare a let variable twice: 'x'.
> SyntaxError: Cannot declare a var variable that shadows a let/const/class variable: 'x'.
>diff --git a/JSTests/ChakraCore/test/LetConst/letvar.baseline-jsc b/JSTests/ChakraCore/test/LetConst/letvar.baseline-jsc
>index 90a38683a3c34a7026e38ea065b626d9b0acb0b2..e30cf5ce68b89c6b1a6b18ee7cb6537457feef9b 100644
>--- a/JSTests/ChakraCore/test/LetConst/letvar.baseline-jsc
>+++ b/JSTests/ChakraCore/test/LetConst/letvar.baseline-jsc
>@@ -1,8 +1,4 @@
> SyntaxError: Cannot declare a var variable that shadows a let/const/class variable: 'x'.
>-var x
>-undefined
>-let y
>-var y
>-undefined
>+SyntaxError: Cannot declare a var variable that shadows a let/const/class variable: 'x'.
> let x
> undefined
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index ab5f795342c039803eaff3f2260df7043514382f..1713ac95303683bbadbb2508ec8101152d551987 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-12-02  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        Redeclaration of var over let/const/class should be a syntax error.
>+        https://bugs.webkit.org/show_bug.cgi?id=192298
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * test262.yaml:
>+        * test262/expectations.yaml:
>+        Mark 22 test262 tests as passing.
>+
>+        * stress/for-in-tests.js:
>+        Fix a test case that was exploiting the very bug that this patch fixes. :)
>+
>+        * ChakraCore/test/LetConst/defer3.baseline-jsc:
>+        * ChakraCore/test/LetConst/letvar.baseline-jsc:
>+        Update expectations.
>+
> 2018-12-02  Caio Lima  <ticaiolima@gmail.com>
> 
>         [ESNext][BigInt] Implement support for "<<" and ">>"
>diff --git a/JSTests/stress/for-in-tests.js b/JSTests/stress/for-in-tests.js
>index a685489a2d2a9d973dc6ba1cb928eae74b1bb82b..c84480dd55947dcd374ebc2b6b4c133702c53836 100644
>--- a/JSTests/stress/for-in-tests.js
>+++ b/JSTests/stress/for-in-tests.js
>@@ -153,9 +153,11 @@
>     var foo = function(a, b, first) {
>         {   
>             let p = 'some-value';
>-            for (var p = b in a) {}
>-            if (first)
>-                return p;
>+            {
>+                for (var p = b in a) {}
>+                if (first)
>+                    return p;
>+            }
>         }
>         return p;
>     };
>diff --git a/JSTests/test262.yaml b/JSTests/test262.yaml
>index 22216fe5525f5e48c3d99edfcd5aa39d6674ca3f..daa26ff6c73086b6670931edb4fc79f8f84bdfa6 100644
>--- a/JSTests/test262.yaml
>+++ b/JSTests/test262.yaml
>@@ -62362,7 +62362,7 @@
> - path: test262/test/language/block-scope/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-var-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/async-generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/async-generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -62424,9 +62424,9 @@
> - path: test262/test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-let-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -62456,9 +62456,9 @@
> - path: test262/test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-let-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -62488,7 +62488,7 @@
> - path: test262/test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -62520,7 +62520,7 @@
> - path: test262/test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-var-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -62550,9 +62550,9 @@
> - path: test262/test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-let-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/block-scope/syntax/redeclaration/var-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/block-scope/syntax/redeclaration/var-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -101346,7 +101346,7 @@
> - path: test262/test/language/statements/const/global-use-before-initialization-in-prior-statement.js
>   cmd: runTest262 :normal, "ReferenceError", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/const/redeclaration-error-from-within-strict-mode-function-const.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
> - path: test262/test/language/statements/const/syntax/block-scope-syntax-const-declarations-mixed-with-without-initialiser.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/const/syntax/block-scope-syntax-const-declarations-mixed-with-without-initialiser.js
>@@ -114156,15 +114156,15 @@
> - path: test262/test/language/statements/let/global-use-before-initialization-in-prior-statement.js
>   cmd: runTest262 :normal, "ReferenceError", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/let/redeclaration-error-from-within-strict-mode-function.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
> - path: test262/test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-function-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-var.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-var.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/let/syntax/escaped-let.js
>   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/let/syntax/identifier-let-allowed-as-lefthandside-expression-strict.js
>@@ -114526,7 +114526,7 @@
> - path: test262/test/language/statements/switch/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-var-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/async-generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/async-generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -114588,9 +114588,9 @@
> - path: test262/test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-let-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -114620,9 +114620,9 @@
> - path: test262/test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-let-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -114652,7 +114652,7 @@
> - path: test262/test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -114684,7 +114684,7 @@
> - path: test262/test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-var-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-async-function-declaration.js
>@@ -114714,9 +114714,9 @@
> - path: test262/test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-let-declaration.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-var-declaration.js
>-  cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
>+  cmd: runTest262 :normal, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
> - path: test262/test/language/statements/switch/syntax/redeclaration/var-declaration-attempt-to-redeclare-with-async-function-declaration.js
>   cmd: runTest262 :fail, "SyntaxError", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
> - path: test262/test/language/statements/switch/syntax/redeclaration/var-declaration-attempt-to-redeclare-with-async-function-declaration.js
>diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml
>index ab63fc56a7355d9aece70ed6790949ed3acfc043..ebf90fc00cd370ebaea6b74f3d239bf3678d32b5 100644
>--- a/JSTests/test262/expectations.yaml
>+++ b/JSTests/test262/expectations.yaml
>@@ -1765,25 +1765,18 @@ test/language/block-scope/syntax/redeclaration/async-function-declaration-attemp
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-var-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-generator-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/block-scope/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-var-declaration.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-generator-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/block-scope/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-var-declaration.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-class-declaration.js:
>@@ -1799,7 +1792,6 @@ test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-r
>   strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-class-declaration.js:
>@@ -1814,16 +1806,12 @@ test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-var-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-generator-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/block-scope/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-var-declaration.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/block-scope/syntax/redeclaration/var-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>   strict mode: 'Test262: This statement should not be evaluated.'
>@@ -3416,8 +3404,6 @@ test/language/statements/class/subclass/class-definition-superclass-generator.js
> test/language/statements/class/super-fielddefinition-initializer-abrupt-completion.js:
>   default: "SyntaxError: Unexpected token '='. Expected an opening '(' before a method's parameter list."
>   strict mode: "SyntaxError: Unexpected token '='. Expected an opening '(' before a method's parameter list."
>-test/language/statements/const/redeclaration-error-from-within-strict-mode-function-const.js:
>-  default: 'Test262: This statement should not be evaluated.'
> test/language/statements/do-while/let-array-with-newline.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/for-in/12.6.4-2.js:
>@@ -3700,13 +3686,8 @@ test/language/statements/labeled/value-yield-strict.js:
>   strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode."
> test/language/statements/let/block-local-closure-set-before-initialization.js:
>   default: 'Test262Error: Expected a ReferenceError to be thrown but no exception was thrown at all'
>-test/language/statements/let/redeclaration-error-from-within-strict-mode-function.js:
>-  default: 'Test262: This statement should not be evaluated.'
> test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-var.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/let/syntax/escaped-let.js:
>   default: "SyntaxError: Unexpected escaped characters in keyword token: 'l\\u0065t'"
> test/language/statements/switch/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>@@ -3723,25 +3704,18 @@ test/language/statements/switch/syntax/redeclaration/async-function-declaration-
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/async-function-declaration-attempt-to-redeclare-with-var-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-generator-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/statements/switch/syntax/redeclaration/class-declaration-attempt-to-redeclare-with-var-declaration.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-generator-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/statements/switch/syntax/redeclaration/const-declaration-attempt-to-redeclare-with-var-declaration.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-class-declaration.js:
>@@ -3754,7 +3728,6 @@ test/language/statements/switch/syntax/redeclaration/function-declaration-attemp
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-class-declaration.js:
>@@ -3769,16 +3742,12 @@ test/language/statements/switch/syntax/redeclaration/generator-declaration-attem
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/generator-declaration-attempt-to-redeclare-with-var-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-generator-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>-test/language/statements/switch/syntax/redeclaration/let-declaration-attempt-to-redeclare-with-var-declaration.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: 'Test262: This statement should not be evaluated.'
> test/language/statements/switch/syntax/redeclaration/var-declaration-attempt-to-redeclare-with-async-function-declaration.js:
>   default: 'Test262: This statement should not be evaluated.'
>   strict mode: 'Test262: This statement should not be evaluated.'

Actions: View | Formatted Diff | Diff

Attachments on bug 192298: 356356 | 356387 | 356907 | 356945 | 357488