WebKit Bugzilla
Attachment 356386 Details for
Bug 192313
: Enable swipe snapshot removal logging in release builds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192313-20181203103542.patch (text/plain), 1.70 KB, created by
Tim Horton
on 2018-12-03 10:35:43 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tim Horton
Created:
2018-12-03 10:35:43 PST
Size:
1.70 KB
patch
obsolete
>Subversion Revision: 238804 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 18bb6ad6828f969be7272a5c7e2ef5610b0ea112..0c0c775dbde84e901550ed54be9276db68c1b1cf 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2018-12-03 Tim Horton <timothy_horton@apple.com> >+ >+ Enable swipe snapshot removal logging in release builds >+ https://bugs.webkit.org/show_bug.cgi?id=192313 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/Cocoa/ViewGestureController.cpp: >+ (WebKit::ViewGestureController::SnapshotRemovalTracker::log const): >+ This is super-low-traffic and super-helpful logging. >+ Turn it on all the time. >+ > 2018-12-03 Yusuke Suzuki <yusukesuzuki@slowstart.org> > > Use WallTime for file time >diff --git a/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp b/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp >index 8a70694cc84565aac00e0f15190c6773d316ea78..2d795e7d9af2de94b23837f81580e668bb13f5ca 100644 >--- a/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp >+++ b/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp >@@ -268,10 +268,8 @@ String ViewGestureController::SnapshotRemovalTracker::eventsDescription(Events e > > void ViewGestureController::SnapshotRemovalTracker::log(const String& log) const > { >-#if !LOG_DISABLED > auto sinceStart = MonotonicTime::now() - m_startTime; >-#endif >- LOG(ViewGestures, "Swipe Snapshot Removal (%0.2f ms) - %s", sinceStart.milliseconds(), log.utf8().data()); >+ RELEASE_LOG(ViewGestures, "Swipe Snapshot Removal (%0.2f ms) - %{public}s", sinceStart.milliseconds(), log.utf8().data()); > } > > void ViewGestureController::SnapshotRemovalTracker::resume()
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192313
: 356386