Attachment 356270 Details for Bug 192119 – Patch

[patch] Patch

bug-192119-20181130173032.patch (text/plain), 3.14 KB, created by Matt Baker on 2018-11-30 17:30:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-11-30 17:30:33 PST

Size: 3.14 KB

patch

obsolete

>Subversion Revision: 238757
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 0ccfc19c52b547c7e2c8075993aee5f0ca6e373b..c8a06701de51075ff8e0d3d098fc2f84e57ebff4 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-11-30  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Elements: $0 is shown for all selected elements
>+        https://bugs.webkit.org/show_bug.cgi?id=192119
>+        <rdar://problem/46327554>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DOMTreeOutline.css:
>+        (.tree-outline.dom li.last-selected > span::after):
>+        (.tree-outline.dom li.selected > span::after): Deleted.
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline):
>+        (WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
>+        Add a unique class name to the last selected TreeElement to distinguish
>+        it from other selected elements.
>+
> 2018-11-30  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION(r238599): Multiple Selection: selecting a breakpoint will change the selection to it's parent on the first click
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css b/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
>index a7ac3cc77e1348dddd715f6d1444d91b804033c5..77dc159f44e07465cd690bf8429b81a88a823d17 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
>@@ -78,7 +78,7 @@
>     background-color: hsl(209, 100%, 49%);
> }
> 
>-.tree-outline.dom li.selected > span::after {
>+.tree-outline.dom li.last-selected > span::after {
>     content: " = $0";
>     color: var(--console-secondary-text-color);
>     position: absolute;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 61a3c4187dca322326fad759880354b8ec62a59a..48306fa73038df984143fda929c7193a288effdf 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -55,6 +55,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         this._selectable = selectable;
> 
>         this._cachedNumberOfDescendents = 0;
>+        this._previousSelectedTreeElement = null;
>         this._selectionController = new WI.SelectionController(this);
>         this._treeElementIndexCache = new Map;
> 
>@@ -812,6 +813,16 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>             }
>         }
> 
>+        let selectedTreeElement = this.selectedTreeElement;
>+        if (selectedTreeElement !== this._previousSelectedTreeElement) {
>+            if (this._previousSelectedTreeElement)
>+                this._previousSelectedTreeElement.listItemElement.classList.remove("last-selected");
>+            if (selectedTreeElement)
>+                selectedTreeElement.listItemElement.classList.add("last-selected");
>+
>+            this._previousSelectedTreeElement = selectedTreeElement;
>+        }
>+
>         this._dispatchSelectionDidChangeEvent();
> 
>         this._processingSelectionChange = false;

Actions: View | Formatted Diff | Diff

Attachments on bug 192119: 355934 | 356270 | 356274 | 356280 | 356401 | 356476 | 356495 | 356501