Attachment 356246 Details for Bug 192260 – Patch

[patch] Patch

bug-192260-20181130152133.patch (text/plain), 2.41 KB, created by Jonathan Bedard on 2018-11-30 15:21:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2018-11-30 15:21:34 PST

Size: 2.41 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 238757)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2018-11-30  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Support unicode in MeteredStream
>+        https://bugs.webkit.org/show_bug.cgi?id=192260
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It's possible that the test runner returns unicode characters to be logged when
>+        running layout tests.
>+
>+        * Scripts/webkitpy/layout_tests/views/metered_stream.py:
>+        (MeteredStream.write): Message written to metered stream should be unicode.
>+        * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
>+        (RegularTest.test_unicode):
>+
> 2018-11-30  Chris Dumez  <cdumez@apple.com>
> 
>         [PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
>Index: Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py
>===================================================================
>--- Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py	(revision 238757)
>+++ Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py	(working copy)
>@@ -105,9 +105,9 @@ class MeteredStream(object):
>             timestamp_string = '%02d:%02d:%02d.%03d %d ' % (now_tuple.tm_hour, now_tuple.tm_min, now_tuple.tm_sec, int((now * 1000) % 1000), pid)
> 
>         if self._isatty and not self._verbose:
>-            msg = '{}{}'.format(timestamp_string, txt)
>+            msg = u'{}{}'.format(timestamp_string, txt)
>         else:
>-            msg = '{}{}'.format(timestamp_string, self._ensure_newline(txt))
>+            msg = u'{}{}'.format(timestamp_string, self._ensure_newline(txt))
> 
>         self._stream.write(msg)
> 
>Index: Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py
>===================================================================
>--- Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py	(revision 238757)
>+++ Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py	(working copy)
>@@ -108,6 +108,10 @@ class RegularTest(unittest.TestCase):
>         self.logger.info('foo %s %d', 'bar', 2)
>         self.assertEqual(self.buflist, ['foo bar 2\n'])
> 
>+    def test_unicode(self):
>+        self.logger.info(u'\u2713')
>+        self.assertEqual(self.buflist[-1][-2:], u'\u2713\n')
>+
> 
> class TtyTest(RegularTest):
>     verbose = False

Actions: View | Formatted Diff | Diff

Attachments on bug 192260: 356246 | 356255 | 356400