Attachment 356217 Details for Bug 192233 – Patch for landing

[patch] Patch for landing

bug-192233-20181130115714.patch (text/plain), 6.09 KB, created by Wenson Hsieh on 2018-11-30 11:57:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-11-30 11:57:15 PST

Size: 6.09 KB

patch

obsolete

>Subversion Revision: 238738
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9ecbbde1e30dc66b11069ab034179b54340b1acb..e9c741a2094e7ccada890936c1b9de8e65a766a8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-11-30  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Replace "auto fill" with "AutoFill" in some localizable strings
>+        https://bugs.webkit.org/show_bug.cgi?id=192233
>+        <rdar://problem/46311614>
>+
>+        Reviewed by Chris Fleizach.
>+
>+        Replace "autofill" with "AutoFill".
>+
>+        * en.lproj/Localizable.strings:
>+        * platform/LocalizedStrings.cpp:
>+        (WebCore::AXAutoFillCredentialsLabel):
>+        (WebCore::AXAutoFillContactsLabel):
>+        (WebCore::AXAutoFillStrongPasswordLabel):
>+        (WebCore::AXAutoFillCreditCardLabel):
>+
> 2018-11-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
> 
>         [GStreamer][EME] CDMInstance should be shipped as a GstContext to the decryptors
>diff --git a/Source/WebCore/en.lproj/Localizable.strings b/Source/WebCore/en.lproj/Localizable.strings
>index 8310dd0044cddd2d8a2a6cabb22714a73d49699c..d58020112dbc9e1f36fcd39a7e793c53f08aec51 100644
>--- a/Source/WebCore/en.lproj/Localizable.strings
>+++ b/Source/WebCore/en.lproj/Localizable.strings
>@@ -973,8 +973,8 @@
> /* HTTP result code string */
> "conflict" = "conflict";
> 
>-/* Label for the auto fill contacts button inside a text field. */
>-"contact info auto fill" = "contact info auto fill";
>+/* Label for the AutoFill contacts button inside a text field. */
>+"contact info AutoFill" = "contact info AutoFill";
> 
> /* An ARIA accessibility group that contains content. */
> "content information" = "content information";
>@@ -985,8 +985,8 @@
> /* HTTP result code string */
> "created" = "created";
> 
>-/* Label for the credit card auto fill button inside a text field. */
>-"credit card auto fill" = "credit card auto fill";
>+/* Label for the credit card AutoFill button inside a text field. */
>+"credit card AutoFill" = "credit card AutoFill";
> 
> /* The less good value description for a meter element. */
> "critical value" = "critical value";
>@@ -1186,8 +1186,8 @@
> /* HTTP result code string */
> "partial content" = "partial content";
> 
>-/* Label for the auto fill credentials button inside a text field. */
>-"password auto fill" = "password auto fill";
>+/* Label for the AutoFill credentials button inside a text field. */
>+"password AutoFill" = "password AutoFill";
> 
> /* accessibility label for pause button */
> "pause" = "pause";
>@@ -1288,8 +1288,8 @@
> /* accessibility help text for hide closed captions button */
> "stop displaying closed captions" = "stop displaying closed captions";
> 
>-/* Label for the strong password auto fill button inside a text field. */
>-"strong password auto fill" = "strong password auto fill";
>+/* Label for the strong password AutoFill button inside a text field. */
>+"strong password AutoFill" = "strong password AutoFill";
> 
> /* The suboptimal value description for a meter element. */
> "suboptimal value" = "suboptimal value";
>diff --git a/Source/WebCore/platform/LocalizedStrings.cpp b/Source/WebCore/platform/LocalizedStrings.cpp
>index d0370cf8fda6d0f6e3babf6e851a723d3982aace..b1acfb02df9ad6ebe0d0dffe28ba4890669d020d 100644
>--- a/Source/WebCore/platform/LocalizedStrings.cpp
>+++ b/Source/WebCore/platform/LocalizedStrings.cpp
>@@ -626,22 +626,22 @@ String AXListItemActionVerb()
> 
> String AXAutoFillCredentialsLabel()
> {
>-    return WEB_UI_STRING("password auto fill", "Label for the auto fill credentials button inside a text field.");
>+    return WEB_UI_STRING("password AutoFill", "Label for the AutoFill credentials button inside a text field.");
> }
> 
> String AXAutoFillContactsLabel()
> {
>-    return WEB_UI_STRING("contact info auto fill", "Label for the auto fill contacts button inside a text field.");
>+    return WEB_UI_STRING("contact info AutoFill", "Label for the AutoFill contacts button inside a text field.");
> }
> 
> String AXAutoFillStrongPasswordLabel()
> {
>-    return WEB_UI_STRING("strong password auto fill", "Label for the strong password auto fill button inside a text field.");
>+    return WEB_UI_STRING("strong password AutoFill", "Label for the strong password AutoFill button inside a text field.");
> }
> 
> String AXAutoFillCreditCardLabel()
> {
>-    return WEB_UI_STRING("credit card auto fill", "Label for the credit card auto fill button inside a text field.");
>+    return WEB_UI_STRING("credit card AutoFill", "Label for the credit card AutoFill button inside a text field.");
> }
> 
> String autoFillStrongPasswordLabel()
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 99bbb14cfa354474e50980d30b728b20a0dc2b3e..dd3b4a8f1400f4ab0f676b472ff227b6590db517 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-11-30  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Replace "auto fill" with "AutoFill" in some localizable strings
>+        https://bugs.webkit.org/show_bug.cgi?id=192233
>+        <rdar://problem/46311614>
>+
>+        Reviewed by Chris Fleizach.
>+
>+        Rebaseline a test.
>+
>+        * accessibility/auto-fill-types-expected.txt:
>+
> 2018-11-30  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] Compute min/maxHeight margins only when they are needed.
>diff --git a/LayoutTests/accessibility/auto-fill-types-expected.txt b/LayoutTests/accessibility/auto-fill-types-expected.txt
>index 72c5689b85a938e3623b1a760783e1eb7a6b88ed..c7792b168b8d08c0c75090049316bd2437e82bca 100644
>--- a/LayoutTests/accessibility/auto-fill-types-expected.txt
>+++ b/LayoutTests/accessibility/auto-fill-types-expected.txt
>@@ -7,10 +7,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
> Initial auto-fill available: false
> Auto-fill type: none
> Contact button role: AXRole: AXButton
>-Contact button label: AXDescription: contact info auto fill
>+Contact button label: AXDescription: contact info AutoFill
> Auto-fill type: contacts
> Credentials button role: AXRole: AXButton
>-Credentials button label: AXDescription: password auto fill
>+Credentials button label: AXDescription: password AutoFill
> Auto-fill type: credentials
> Post auto-fill available: true
> PASS successfullyParsed is true

Actions: View | Formatted Diff | Diff

Attachments on bug 192233: 356197 | 356211 | 356215 | 356217 | 356221