WebKit Bugzilla
Attachment 356190 Details for
Bug 192231
: Web Inspector: Settings: reload button needs horizontal spacing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192231-20181130100538.patch (text/plain), 3.40 KB, created by
Devin Rousso
on 2018-11-30 10:05:39 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2018-11-30 10:05:39 PST
Size:
3.40 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index a8e1de9a0cfd0c5e34ea4a1df1dcb17fe8067135..9d69a3911f17684ff8019243507415a0da57b028 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,21 @@ >+2018-11-30 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Settings: reload button needs horizontal spacing >+ https://bugs.webkit.org/show_bug.cgi?id=192231 >+ <rdar://problem/46274363> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/SettingsTabContentView.css: >+ (.content-view.settings > .settings-view > .container button): >+ (.content-view.settings > .settings-view > .container > .title): >+ (.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): >+ (body[dir=ltr] .content-view.settings > .settings-view > .container > .title): Deleted. >+ (body[dir=rtl] .content-view.settings > .settings-view > .container > .title): Deleted. >+ (body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted. >+ (body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted. >+ Drive-by: replace `dir=*` attribute rules with `-webkit-margin-*` properties. >+ > 2018-11-29 Matt Baker <mattbaker@apple.com> > > Web Inspector: RTL: disclosure triangles should be flipped and aligned right >diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css >index deacee597586b7e76d221f4c7a7d195f2e61a083..7e74f46f2acccf94dee5f7c900fb97243e5510ff 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css >+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css >@@ -69,23 +69,15 @@ > } > > .content-view.settings > .settings-view > .container button { >+ -webkit-margin-end: 4px; > font-size: inherit; > } > > .content-view.settings > .settings-view > .container > .title { >- margin-top: 2px; > width: 50%; >+ margin-top: 2px; >+ -webkit-margin-end: 6px; > text-align: end; >- >- --setting-name-margin-end: 6px; >-} >- >-body[dir=ltr] .content-view.settings > .settings-view > .container > .title { >- margin-right: var(--setting-name-margin-end); >-} >- >-body[dir=rtl] .content-view.settings > .settings-view > .container > .title { >- margin-left: var(--setting-name-margin-end); > } > > .content-view.settings > .settings-view > .container > .editor-group { >@@ -98,18 +90,9 @@ body[dir=rtl] .content-view.settings > .settings-view > .container > .title { > } > > .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] { >+ -webkit-margin-end: 4px; > /* Vertically align <select> with the group title text. */ > font-size: 16px; >- >- --settings-input-checkbox-margin-end: 4px; >-} >- >-body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] { >- margin-right: var(--settings-input-checkbox-margin-end); >-} >- >-body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] { >- margin-left: var(--settings-input-checkbox-margin-end); > } > > .content-view.settings > .settings-view > .container > .editor-group > .editor select {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192231
: 356190