WebKit Bugzilla
Attachment 356184 Details for
Bug 192228
: [ews-app] Ensure only one instance of BugzillaPatchFetcher is running
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-ews-app-Ensure-only-one-instance-of-BugzillaPatchFet.patch (text/plain), 2.23 KB, created by
Aakash Jain
on 2018-11-30 09:14:16 PST
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Aakash Jain
Created:
2018-11-30 09:14:16 PST
Size:
2.23 KB
patch
obsolete
>From af7a0c182257c791c9c4c5c0d7da8ecc4bb6e85e Mon Sep 17 00:00:00 2001 >From: Aakash Jain <aakash_jain@apple.com> >Date: Fri, 30 Nov 2018 09:13:15 -0800 >Subject: [PATCH] [ews-app] Ensure only one instance of BugzillaPatchFetcher is > running https://bugs.webkit.org/show_bug.cgi?id=192228 > >Reviewed by NOBODY (OOPS!). > >* BuildSlaveSupport/ews-app/ews/fetcher.py: >(BugzillaPatchFetcher.fetch): >--- > Tools/BuildSlaveSupport/ews-app/ews/fetcher.py | 8 ++++++++ > Tools/ChangeLog | 10 ++++++++++ > 2 files changed, 18 insertions(+) > >diff --git a/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py b/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py >index 5a0037b5340..53cbe83f458 100644 >--- a/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py >+++ b/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py >@@ -30,7 +30,14 @@ _log = logging.getLogger(__name__) > > > class BugzillaPatchFetcher(): >+ isRunning = False >+ > def fetch(self): >+ if BugzillaPatchFetcher.isRunning: >+ _log.warn('Fetcher already running.') >+ return >+ >+ BugzillaPatchFetcher.isRunning = True > patch_ids = Bugzilla.get_list_of_patches_needing_reviews() > patch_ids = BugzillaPatchFetcher.filter_valid_patches(patch_ids) > _log.debug('r? patches: {}'.format(patch_ids)) >@@ -54,6 +61,7 @@ class BugzillaPatchFetcher(): > else: > _log.error('Failed to send patch to buildbot.') > #FIXME: send an email for this failure >+ BugzillaPatchFetcher.isRunning = False > return patch_ids > > def patches_to_send_to_buildbot(self, patch_ids): >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 67489f26908..17f5d797847 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,13 @@ >+2018-11-30 Aakash Jain <aakash_jain@apple.com> >+ >+ [ews-app] Ensure only one instance of BugzillaPatchFetcher is running >+ https://bugs.webkit.org/show_bug.cgi?id=192228 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * BuildSlaveSupport/ews-app/ews/fetcher.py: >+ (BugzillaPatchFetcher.fetch): >+ > 2018-11-28 Wenson Hsieh <wenson_hsieh@apple.com> > > [iOSMac] Dropping text selections from web content into editable elements crashes the web process >-- >2.17.2 (Apple Git-113) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
dino
:
review+
ews-watchlist
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192228
: 356184 |
356345