Attachment 356168 Details for Bug 114965 – Patch

[patch] Patch

bug-114965-20181130122418.patch (text/plain), 1.83 KB, created by Rob Buis on 2018-11-30 03:24:17 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2018-11-30 03:24:17 PST

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 238666
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 8b6cc709f37589783ac64814b6e2b6e020d6b0c9..dc5628480366349514f55ab1bfa7777941a2b38d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-11-30  Rob Buis  <rbuis@igalia.com>
>+
>+        [Mac] HEAD requests changed to GET after 301, 302, and 303 redirections (http/tests/xmlhttprequest/head-redirection.html)
>+        https://bugs.webkit.org/show_bug.cgi?id=114965
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
>+        (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
>+
> 2018-11-29  Tomas Popela  <tpopela@redhat.com>
> 
>         [GTK][WPE] Fix BubblewrapLauncher clang warnings
>diff --git a/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm b/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
>index 5e832b7a1bd25b41d7bc00e9eef083b29fefc202..43c00e565f3b85ebfb819652b1949e7e0a9a456b 100644
>--- a/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
>+++ b/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
>@@ -306,7 +306,8 @@ void NetworkDataTaskCocoa::willPerformHTTPRedirection(WebCore::ResourceResponse&
>         String originalContentType = m_firstRequest.httpContentType();
>         if (!originalContentType.isEmpty())
>             request.setHTTPHeaderField(WebCore::HTTPHeaderName::ContentType, originalContentType);
>-    }
>+    } else if (redirectResponse.httpStatusCode() == 303 && equalLettersIgnoringASCIICase(m_firstRequest.httpMethod(), "head"))
>+        request.setHTTPMethod("HEAD"_s);
>     
>     // Should not set Referer after a redirect from a secure resource to non-secure one.
>     if (m_shouldClearReferrerOnHTTPSToHTTPRedirect && !request.url().protocolIs("https") && WebCore::protocolIs(request.httpReferrer(), "https"))

Actions: View | Formatted Diff | Diff

Attachments on bug 114965: 356168 | 356169 | 356175 | 356181 | 356186 | 356199 | 356233 | 356593