Attachment 350220 Details for Bug 189792 – Patch

[patch] Patch

bug-189792-20180920095531.patch (text/plain), 3.80 KB, created by youenn fablet on 2018-09-20 09:55:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-09-20 09:55:31 PDT

Size: 3.80 KB

patch

obsolete

>Subversion Revision: 236237
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0897079475259438ef5fa64ddd56d575fc831b2a..4663c1aee3ec1c701c2480e252e38212f4dea4a1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-20  Youenn Fablet  <youenn@apple.com>
>+
>+        codecId missing in RTCRTPStreamStats and the corresponding RTCCodecStats
>+        https://bugs.webkit.org/show_bug.cgi?id=189792
>+        <rdar://problem/32370668>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by updated test.
>+
>+        * Modules/mediastream/RTCStatsReport.h:
>+        Removed fields that are already defined in the base class.
>+
> 2018-09-19  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         REGRESSION(r235917): 2% regression in Dromaeo CSS selector on MacBookPro11,4
>diff --git a/Source/WebCore/Modules/mediastream/RTCStatsReport.h b/Source/WebCore/Modules/mediastream/RTCStatsReport.h
>index 01f3e7f1e1480fe0334542e7b5874e172302e8c3..ce95d7f858d5fbc454081c87d3413193ca37e38b 100644
>--- a/Source/WebCore/Modules/mediastream/RTCStatsReport.h
>+++ b/Source/WebCore/Modules/mediastream/RTCStatsReport.h
>@@ -77,18 +77,6 @@ public:
>     struct InboundRTPStreamStats : RTCRTPStreamStats {
>         InboundRTPStreamStats() { type = RTCStatsReport::Type::InboundRtp; }
> 
>-        uint32_t ssrc;
>-        String associateStatsId;
>-        bool isRemote { false };
>-        String mediaType;
>-        String mediaTrackId;
>-        String transportId;
>-        String codecId;
>-        unsigned long firCount { 0 };
>-        unsigned long pliCount { 0 };
>-        unsigned long nackCount { 0 };
>-        unsigned long sliCount { 0 };
>-        unsigned long long qpSum { 0 };
>         unsigned long packetsReceived { 0 };
>         unsigned long long bytesReceived { 0 };
>         unsigned long packetsLost { 0 };
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 11303ac114643fdfc5c603479f79dd7a0a4d2c60..1da8a3c0bc64fb8abf78e91975d2fce4b2d14125 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-20  Youenn Fablet  <youenn@apple.com>
>+
>+        codecId missing in RTCRTPStreamStats and the corresponding RTCCodecStats
>+        https://bugs.webkit.org/show_bug.cgi?id=189792
>+       <rdar://problem/32370668>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webrtc/video-stats.html:
>+
> 2018-09-19  Justin Fan  <justin_fan@apple.com>
> 
>         WebGL 2 partial passes and failing test expectations for conformance/conformance2 layout tests
>diff --git a/LayoutTests/webrtc/video-stats.html b/LayoutTests/webrtc/video-stats.html
>index 8286ca75abdbe1a4b3849dc50e0b0d49014220e2..a7a004746673cfe5716210b4afe85f8d775d7d4a 100644
>--- a/LayoutTests/webrtc/video-stats.html
>+++ b/LayoutTests/webrtc/video-stats.html
>@@ -69,6 +69,7 @@ function checkInboundFramesNumberIncreased(secondConnection, statsSecondConnecti
>         if (stats.framesDecoded > statsSecondConnection.framesDecoded) {
>             if (testTimestampDifference(stats.timestamp - statsSecondConnection.timestamp, stats.framesDecoded - statsSecondConnection.framesDecoded))
>                 return Promise.reject("timestamp and frames increment do not match");
>+            assert_not_equals(Object.keys(stats).indexOf("codecId"), -1);
>             return;
>         }
>         if (++count === 20)
>@@ -85,6 +86,7 @@ function checkOutboundFramesNumberIncreased(firstConnection, statsFirstConnectio
>         if (stats.framesEncoded > statsFirstConnection.framesEncoded) {
>             if (testTimestampDifference(stats.timestamp - statsFirstConnection.timestamp, stats.framesEncoded - statsFirstConnection.framesEncoded))
>                 return Promise.reject("timestamp and frames increment do not match");
>+            assert_not_equals(Object.keys(stats).indexOf("codecId"), -1);
>             return;
>         }
>         if (++count === 20)

Actions: View | Formatted Diff | Diff

Attachments on bug 189792: 350220 | 350274 | 350289 | 350389