Attachment 350208 Details for Bug 189740 – Patch

[patch] Patch

bug-189740-20180920175809.patch (text/plain), 1.80 KB, created by Yacine Bandou on 2018-09-20 08:58:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yacine Bandou

Created: 2018-09-20 08:58:10 PDT

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 236165
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0c35e3138c1b66701dfbf638e514d41310441afe..58f649385355a8127fa9df894f14178625e7cc4b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-20  Yacine Bandou  <yacine.bandou@softathome.com>
>+
>+        [EME] Fix typo in WebM sanitization variable
>+        https://bugs.webkit.org/show_bug.cgi?id=189789
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This commit corrects a typo in the name of a local variable, sanitizedBuffer
>+        instead of sanitazedBuffer.
>+
>+        * Modules/encryptedmedia/InitDataRegistry.cpp:
>+        (WebCore::extractKeyIDsWebM):
>+
> 2018-09-19  Yacine Bandou  <yacine.bandou@softathome.com>
> 
>         [EME] Add WebM sanitization
>diff --git a/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp b/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp
>index 1e2e8335339a37fc42e8954f912888da8fef6954..01eddcd09259eda839c4ccaabe7dc9982d59f46d 100644
>--- a/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp
>+++ b/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp
>@@ -154,13 +154,13 @@ static RefPtr<SharedBuffer> sanitizeWebM(const SharedBuffer& buffer)
> static std::optional<Vector<Ref<SharedBuffer>>> extractKeyIDsWebM(const SharedBuffer& buffer)
> {
>     Vector<Ref<SharedBuffer>> keyIDs;
>-    RefPtr<SharedBuffer> sanitazedBuffer = sanitizeWebM(buffer);
>-    if (!sanitazedBuffer)
>+    RefPtr<SharedBuffer> sanitizedBuffer = sanitizeWebM(buffer);
>+    if (!sanitizedBuffer)
>         return std::nullopt;
> 
>     // 1. Format
>     // https://w3c.github.io/encrypted-media/format-registry/initdata/webm.html#format
>-    keyIDs.append(sanitazedBuffer.releaseNonNull());
>+    keyIDs.append(sanitizedBuffer.releaseNonNull());
>     return keyIDs;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189740: 350106 | 350108 | 350184 | 350208 | 350213