Attachment 350203 Details for Bug 189788 – Patch

[patch] Patch

bug-189788-20180920173308.patch (text/plain), 2.10 KB, created by Alicia Boya García on 2018-09-20 08:33:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2018-09-20 08:33:10 PDT

Size: 2.10 KB

patch

obsolete

>Subversion Revision: 236166
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9fcb657142ed7fe2503cc27f7bdae634efdf21e4..0f373c020e6d83f1b7d477319674460dc8c779a8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-20  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        [GStreamer][MSE] Add a default sample duration
>+        https://bugs.webkit.org/show_bug.cgi?id=189788
>+
>+        Some WebM files don't provide sample durations, so we need to provide
>+        a safe default in order for them to be playable.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
>+        (WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
>+
> 2018-09-19  Philippe Normand <pnormand@igalia.com>
> 
>         [GStreamer] Add support for AV1 decoding
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
>index 586d8dfe65c03f252dbc3c27549865e77650d9a7..b810e78da82d1c6dbe9ea4b3faf0ad81ea0963f7 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
>@@ -50,6 +50,14 @@ MediaSampleGStreamer::MediaSampleGStreamer(GRefPtr<GstSample>&& sample, const Fl
>         m_dts = createMediaTime(GST_BUFFER_DTS_OR_PTS(buffer));
>     if (GST_BUFFER_DURATION_IS_VALID(buffer))
>         m_duration = createMediaTime(GST_BUFFER_DURATION(buffer));
>+    else {
>+        // Unfortunately, sometimes samples don't provide a duration. This can never happen in MP4 because of the way
>+        // the format is laid out, but it's pretty common in WebM.
>+        // The good part is that durations don't matter for playback, just for buffered ranges and coded frame deletion.
>+        // We want to pick something small enough to not cause unwanted frame deletion, but big enough to never be
>+        // mistaken for a rounding artifact.
>+        m_duration = createMediaTime(16666667); // 1/60 seconds
>+    }
> 
>     m_size = gst_buffer_get_size(buffer);
>     m_sample = sample;

Actions: View | Formatted Diff | Diff

Attachments on bug 189788: 350203