Attachment 350163 Details for Bug 189770 – Patch

[patch] Patch

bug-189770-20180919171808.patch (text/plain), 1.93 KB, created by Dean Jackson on 2018-09-19 17:18:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2018-09-19 17:18:09 PDT

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 236071
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 766af6b6a5e854c40e5f59de242847b559e6e9a5..1270f59ba452bad3e47352870710d18c8b8fe211 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-19  Dean Jackson  <dino@grorg.org>
>+
>+        Temporarily move fullscreen back to experimental features
>+        https://bugs.webkit.org/show_bug.cgi?id=189770
>+        <rdar://problem/44619282>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make fullscreen an experimental feature again.
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2018-09-17  Woodrow Wang  <woodrow_wang@apple.com>
> 
>         Clear pending resource load statistics' writes after tests
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 3f83115a718195d3637f056ed6a0fdb1b47560e7..bdf801bac4647afdf93de6b09085996f7165e022 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1253,6 +1253,15 @@ EncryptedMediaAPIEnabled:
>   category: experimental
>   condition: ENABLE(ENCRYPTED_MEDIA)
> 
>+FullScreenEnabled:
>+  type: bool
>+  defaultValue: false
>+  condition: ENABLE(FULLSCREEN_API)
>+  hidden: EXPERIMENTAL_FULLSCREEN_API_HIDDEN
>+  humanReadableName: "Fullscreen API"
>+  humanReadableDescription: "Fullscreen API"
>+  category: experimental
>+
> # For internal features:
> # The type should be boolean.
> # You must provide a humanReadableName and humanReadableDescription for all debug features. They
>@@ -1326,15 +1335,6 @@ WebGLCompressedTextureASTCSupportEnabled:
>   category: internal
>   webcoreBinding: RuntimeEnabledFeatures
> 
>-FullScreenEnabled:
>-  type: bool
>-  defaultValue: false
>-  condition: ENABLE(FULLSCREEN_API)
>-  hidden: EXPERIMENTAL_FULLSCREEN_API_HIDDEN
>-  humanReadableName: "Fullscreen API"
>-  humanReadableDescription: "Fullscreen API"
>-  category: internal
>-
> AriaReflectionEnabled:
>   type: bool
>   defaultValue: true

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189770: 350163