Attachment 350162 Details for Bug 189771 – Patch

[patch] Patch

bug-189771-20180919170828.patch (text/plain), 2.27 KB, created by Alex Christensen on 2018-09-19 17:08:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-09-19 17:08:29 PDT

Size: 2.27 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 236231)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-09-19  Alex Christensen  <achristensen@webkit.org>
>+
>+        REGRESSION(236154) C API clients not using WKPageSetPageNavigationClient couldn't complete HTTPS requests
>+        https://bugs.webkit.org/show_bug.cgi?id=189771
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/APINavigationClient.h:
>+        (API::NavigationClient::didReceiveAuthenticationChallenge):
>+        Perform default behavior if there's an authentication challenge but we're using the default navigation client.
>+        I wish we had infrastructure to test this but WebKitTestRunner uses WKPageSetNavigationClient
>+        and we don't have the ability to do networking from API tests.  This is a growing problem I intend to solve.
>+
> 2018-09-19  Woodrow Wang  <woodrow_wang@apple.com>
> 
>         Clear persistent storage between tests for resourceLoadStatistics
>Index: Source/WebKit/UIProcess/API/APINavigationClient.h
>===================================================================
>--- Source/WebKit/UIProcess/API/APINavigationClient.h	(revision 236150)
>+++ Source/WebKit/UIProcess/API/APINavigationClient.h	(working copy)
>@@ -27,6 +27,8 @@
> 
> #include "APIData.h"
> #include "APIString.h"
>+#include "AuthenticationChallengeProxy.h"
>+#include "AuthenticationDecisionListener.h"
> #include "PluginModuleInfo.h"
> #include "ProcessTerminationReason.h"
> #include "SameDocumentNavigationType.h"
>@@ -86,7 +88,7 @@ public:
>     virtual void renderingProgressDidChange(WebKit::WebPageProxy&, WebCore::LayoutMilestones) { }
> 
>     virtual bool canAuthenticateAgainstProtectionSpace(WebKit::WebPageProxy&, WebKit::WebProtectionSpace*) { return false; }
>-    virtual void didReceiveAuthenticationChallenge(WebKit::WebPageProxy&, WebKit::AuthenticationChallengeProxy&) { }
>+    virtual void didReceiveAuthenticationChallenge(WebKit::WebPageProxy&, WebKit::AuthenticationChallengeProxy& challenge) { challenge.listener().performDefaultHandling(); }
> 
>     // FIXME: These function should not be part of this client.
>     virtual bool processDidTerminate(WebKit::WebPageProxy&, WebKit::ProcessTerminationReason) { return false; }

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189771: 350162