Attachment 350143 Details for Bug 189738 – Patch for landing

[patch] Patch for landing

bug-189738-20180919123751.patch (text/plain), 2.19 KB, created by Ryosuke Niwa on 2018-09-19 12:37:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-09-19 12:37:52 PDT

Size: 2.19 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 236165)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-09-19  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        REGRESSION(r235917): 2% regression in Dromaeo CSS selector on MacBookPro11,4
>+        https://bugs.webkit.org/show_bug.cgi?id=189738
>+
>+        Reviewed by Yusuke Suzuki.
>+
>+        The regression was caused by the regundant walk to the parent element. Removed it to fix the regression.
>+
>+        * cssjit/SelectorCompiler.cpp:
>+        (WebCore::SelectorCompiler::SelectorCodeGenerator::generateNthChildParentCheckAndRelationUpdate):
>+        (WebCore::SelectorCompiler::SelectorCodeGenerator::generateNthLastChildParentCheckAndRelationUpdate):
>+
> 2018-09-19  Philippe Normand <pnormand@igalia.com>
> 
>         [GStreamer] Add support for AV1 decoding
>Index: Source/WebCore/cssjit/SelectorCompiler.cpp
>===================================================================
>--- Source/WebCore/cssjit/SelectorCompiler.cpp	(revision 236165)
>+++ Source/WebCore/cssjit/SelectorCompiler.cpp	(working copy)
>@@ -3551,7 +3551,6 @@ void SelectorCodeGenerator::generateNthC
>     failureCases.append(m_assembler.branchTestPtr(Assembler::Zero, parentNode));
>     Assembler::Jump notElement = DOMJIT::branchTestIsElementFlagOnNode(m_assembler, Assembler::Zero, parentNode);
> 
>-    generateWalkToParentElement(failureCases, parentNode);
>     auto relation = fragmentMatchesRightmostOrAdjacentElement(fragment)
>         ? Style::Relation::ChildrenAffectedByForwardPositionalRules
>         : Style::Relation::DescendantsAffectedByForwardPositionalRules;
>@@ -3673,7 +3672,6 @@ void SelectorCodeGenerator::generateNthL
>     failureCases.append(m_assembler.branchTestPtr(Assembler::Zero, parentNode));
>     Assembler::Jump notElement = DOMJIT::branchTestIsElementFlagOnNode(m_assembler, Assembler::Zero, parentNode);
> 
>-    generateWalkToParentElement(failureCases, parentNode);
>     auto relation = fragmentMatchesRightmostOrAdjacentElement(fragment)
>         ? Style::Relation::ChildrenAffectedByBackwardPositionalRules
>         : Style::Relation::DescendantsAffectedByBackwardPositionalRules;

Actions: View | Formatted Diff | Diff

Attachments on bug 189738: 350099 | 350143