Attachment 350114 Details for Bug 189543 – Patch

[patch] Patch

bug-189543-20180919164357.patch (text/plain), 1.87 KB, created by Tomas Popela on 2018-09-19 07:43:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tomas Popela

Created: 2018-09-19 07:43:58 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 236166
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b58444249c044ca9dcbef2f0f4634dad583c2c24..3b57165001f0af4efbe051580c8030e424d925c9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-19  Tomas Popela  <tpopela@redhat.com>
>+
>+        [GTK] Always prints in portrait when landscape is requested
>+        https://bugs.webkit.org/show_bug.cgi?id=189543
>+
>+        We have to change the surface size based on the requested orientation.
>+        Otherwise only portrait will be printed as it's hardcoded.
>+
>+        * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
>+
> 2018-09-18  Brent Fulgham  <bfulgham@apple.com>
> 
>         [iOS] Allow WebContent process to check the "Protocol Characteristics" of files to which it has access
>diff --git a/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp b/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
>index c2faefbb24ac455699d3094a0da1d318e97b60ff..e58e9f1dd7b077f561ca51c92fef715b0ae1429d 100644
>--- a/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
>@@ -134,7 +134,16 @@ public:
>                 break;
>             }
>         } else if (surfaceType == CAIRO_SURFACE_TYPE_PDF)
>-            cairo_pdf_surface_set_size(surface, width, height);
>+            switch (gtk_page_setup_get_orientation(m_pageSetup.get())) {
>+            case GTK_PAGE_ORIENTATION_PORTRAIT:
>+            case GTK_PAGE_ORIENTATION_REVERSE_PORTRAIT:
>+                cairo_pdf_surface_set_size(surface, width, height);
>+                break;
>+            case GTK_PAGE_ORIENTATION_LANDSCAPE:
>+            case GTK_PAGE_ORIENTATION_REVERSE_LANDSCAPE:
>+                cairo_pdf_surface_set_size(surface, height, width);
>+                break;
>+            }
>     }
> 
>     void endPage(cairo_t* cr) override

Flags:

mcatanzaro: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189543: 350114