Attachment 350102 Details for Bug 189742 – Patch v1

[patch] Patch v1

bug-189742-20180919031917.patch (text/plain), 2.88 KB, created by David Kilzer (:ddkilzer) on 2018-09-19 03:19:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-09-19 03:19:18 PDT

Size: 2.88 KB

patch

obsolete

>Subversion Revision: 236161
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a54aa17bf287fe7ac5d6e69d503d77d4a658e452..2df306923e70d4e1bafc54e91c6464f6516e83df 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-09-19  David Kilzer  <ddkilzer@apple.com>
>+
>+        WebCoreNSURLSession leaks an NSString (_sessionDescription) in -dealloc
>+        <https://webkit.org/b/189742>
>+        <rdar://problem/44589774>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/network/cocoa/WebCoreNSURLSession.h:
>+        (WebCoreNSURLSession._sessionDescription): Change type from
>+        NSString * to RetainPtr<NSString>.
>+        * platform/network/cocoa/WebCoreNSURLSession.mm: Remove
>+        @synthesized statement for sessionDescription so that custom
>+        methods can be implemented to handle RetainPtr<NSString>.
>+        (-[WebCoreNSURLSession sessionDescription]): Add.
>+        (-[WebCoreNSURLSession setSessionDescription:]): Add.
>+
> 2018-09-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
> 
>         [Curl] Limit capturing extra metrics for Web Inspector when not required.
>diff --git a/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h b/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h
>index 56d87994ed7f6b081efb56c9ba6982ac8c57748e..7c638065b7130e16045a7dcd7e38a6cc628d143d 100644
>--- a/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h
>+++ b/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h
>@@ -60,7 +60,7 @@ WEBCORE_EXPORT @interface WebCoreNSURLSession : NSObject {
>     RefPtr<WebCore::PlatformMediaResourceLoader> _loader;
>     RetainPtr<id<NSURLSessionDelegate>> _delegate;
>     RetainPtr<NSOperationQueue> _queue;
>-    NSString *_sessionDescription;
>+    RetainPtr<NSString> _sessionDescription;
>     HashSet<RetainPtr<CFTypeRef>> _dataTasks;
>     HashSet<RefPtr<WebCore::SecurityOrigin>> _origins;
>     Lock _dataTasksLock;
>diff --git a/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm b/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
>index 83a05dad172964eda50b4ce5cb5d80e85d460c74..70eb7768e306c387dc986050139fc902daaa0574 100644
>--- a/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
>+++ b/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
>@@ -155,7 +155,6 @@ - (void)task:(WebCoreNSURLSessionDataTask *)task didReceiveResponseFromOrigin:(R
> }
> 
> #pragma mark - NSURLSession API
>-@synthesize sessionDescription=_sessionDescription;
> @dynamic delegate;
> - (__nullable id<NSURLSessionDelegate>)delegate
> {
>@@ -179,6 +178,16 @@ - (NSURLSessionConfiguration *)configuration
>     return nil;
> }
> 
>+- (NSString *)sessionDescription
>+{
>+    return _sessionDescription.get();
>+}
>+
>+- (void)setSessionDescription:(NSString *)sessionDescription
>+{
>+    _sessionDescription = adoptNS([sessionDescription copy]);
>+}
>+
> @dynamic loader;
> - (PlatformMediaResourceLoader&)loader
> {

Actions: View | Formatted Diff | Diff

Attachments on bug 189742: 350102