Attachment 350094 Details for Bug 189733 – Patch

[patch] Patch

bug-189733-20180919145046.patch (text/plain), 2.29 KB, created by Fujii Hironori on 2018-09-18 22:50:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-18 22:50:48 PDT

Size: 2.29 KB

patch

obsolete

>Subversion Revision: 236161
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index d308be19282a9a310e8404b1044d05cde49dadce..0704962724392096ea8e7984e48e4f0097f83bea 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-09-18  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] Can't compile IGNORE_CLANG_WARNINGS_BEGIN
>+        https://bugs.webkit.org/show_bug.cgi?id=189733
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        IGNORE_WARNINGS_BEGIN_IMPL was defined only if
>+        COMPILER(GCC_OR_CLANG) and Clang for Windows builds don't meet the
>+        condition. Clang for Windows builds enable WTF_COMPILER_CLANG and
>+        WTF_COMPILER_MSVC, but disable WTF_COMPILER_GCC_OR_CLANG. It is a
>+        little strange WTF_COMPILER_GCC_OR_CLANG is not enabled even
>+        though WTF_COMPILER_CLANG is enabled. Clang for Windows imitates
>+        MSVC, and codes for COMPILER(GCC_OR_CLANG) are for non MSVC.
>+
>+        * wtf/Compiler.h: Replaced "COMPILER(GCC_OR_CLANG)" with "COMPILER(GCC) || COMPILER(CLANG)" of IGNORE_WARNINGS_* macros.
>+
> 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
>diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h
>index 71e6b8e6a08e53754e148a8e8390796d1c9aac0a..1d3d8abc09b779b903a91fef18365d0313f866a7 100644
>--- a/Source/WTF/wtf/Compiler.h
>+++ b/Source/WTF/wtf/Compiler.h
>@@ -396,7 +396,7 @@
> 
> #define _COMPILER_WARNING_NAME(warning) "-W" warning
> 
>-#if COMPILER(GCC_OR_CLANG)
>+#if COMPILER(GCC) || COMPILER(CLANG)
> #define IGNORE_WARNINGS_BEGIN_COND(cond, compiler, warning) \
>     _Pragma(_COMPILER_STRINGIZE(compiler diagnostic push)) \
>     _COMPILER_CONCAT(IGNORE_WARNINGS_BEGIN_IMPL_, cond)(compiler, warning)
>@@ -419,7 +419,7 @@
> #define IGNORE_WARNINGS_BEGIN_IMPL(compiler, warning) \
>     _IGNORE_WARNINGS_BEGIN_IMPL(compiler, _COMPILER_WARNING_NAME(warning))
> 
>-#endif // COMPILER(GCC_OR_CLANG)
>+#endif // COMPILER(GCC) || COMPILER(CLANG)
> 
> 
> #if COMPILER(GCC)
>@@ -438,7 +438,7 @@
> #define IGNORE_CLANG_WARNINGS_END
> #endif
> 
>-#if COMPILER(GCC_OR_CLANG)
>+#if COMPILER(GCC) || COMPILER(CLANG)
> #define IGNORE_WARNINGS_BEGIN(warning) IGNORE_WARNINGS_BEGIN_IMPL(GCC, warning)
> #define IGNORE_WARNINGS_END IGNORE_WARNINGS_END_IMPL(GCC)
> #else

Actions: View | Formatted Diff | Diff

Attachments on bug 189733: 350094 | 350346 | 350728