Attachment 350092 Details for Bug 189732 – Patch

[patch] Patch

bug-189732-20180919132412.patch (text/plain), 1.35 KB, created by Fujii Hironori on 2018-09-18 21:24:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-18 21:24:13 PDT

Size: 1.35 KB

patch

obsolete

>Subversion Revision: 236161
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index d308be19282a9a310e8404b1044d05cde49dadce..57993a740f32de026284d3c868afe90bdbf7616f 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-18  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"
>+        https://bugs.webkit.org/show_bug.cgi?id=189732
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Clang for Windows can't compile the MSVC workaround of
>+        UNUSED_PARAM which has been introduced for Windows CE and Visual
>+        Studio 10. I think it's safe just to remove it.
>+
>+        * wtf/Compiler.h: Removed the code for COMPILER(MSVC).
>+
> 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
>diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h
>index 71e6b8e6a08e53754e148a8e8390796d1c9aac0a..90ce48229c259d7c8ede9ac82c02d7ec4f8f6e7f 100644
>--- a/Source/WTF/wtf/Compiler.h
>+++ b/Source/WTF/wtf/Compiler.h
>@@ -363,10 +363,6 @@
> 
> /* UNUSED_PARAM */
> 
>-#if !defined(UNUSED_PARAM) && COMPILER(MSVC)
>-#define UNUSED_PARAM(variable) (void)&variable
>-#endif
>-
> #if !defined(UNUSED_PARAM)
> #define UNUSED_PARAM(variable) (void)variable
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 189732: 350092