Attachment 350090 Details for Bug 189730 – Patch

[patch] Patch

bug-189730-20180919123841.patch (text/plain), 1.53 KB, created by Fujii Hironori on 2018-09-18 20:38:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-18 20:38:42 PDT

Size: 1.53 KB

patch

obsolete

>Subversion Revision: 236099
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 6ce7c338fef3372e56aa274e7498cc0fb810c6fc..9034ab4649039555496a65b569ea65c8406ead1d 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-18  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'
>+        https://bugs.webkit.org/show_bug.cgi?id=189730
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Clang for Windows can't compile the workaround for MSVC quirk in generateOutOfLine.
>+
>+        * jit/JITMathIC.h:
>+        (generateOutOfLine): Append "&& !COMPILER(CLANG)" to "#if COMPILER(MSVC)".
>+
> 2018-09-17  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: generate CSSKeywordCompletions from backend values
>diff --git a/Source/JavaScriptCore/jit/JITMathIC.h b/Source/JavaScriptCore/jit/JITMathIC.h
>index 4e00958d19f8f308b390f6ab7cbcde42d04c9baa..68167926fbae70c86914e9955cff0aa91d09204b 100644
>--- a/Source/JavaScriptCore/jit/JITMathIC.h
>+++ b/Source/JavaScriptCore/jit/JITMathIC.h
>@@ -144,7 +144,7 @@ public:
>         };
> 
>         auto replaceCall = [&] () {
>-#if COMPILER(MSVC)
>+#if COMPILER(MSVC) && !COMPILER(CLANG)
>             ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().retagged<JSInternalPtrTag>(), callReplacement);
> #else
>             ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().template retagged<JSInternalPtrTag>(), callReplacement);

Actions: View | Formatted Diff | Diff

Attachments on bug 189730: 350090