Attachment 350067 Details for Bug 177501 – Patch

[patch] Patch

bug-177501-20180918153617.patch (text/plain), 4.62 KB, created by youenn fablet on 2018-09-18 15:36:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-09-18 15:36:18 PDT

Size: 4.62 KB

patch

obsolete

>Subversion Revision: 236151
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bd769ff935f045de971085efc3d1c18675cbf132..1a5161dd22e62bf200e7ba037b04142e81261c22 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-18  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout Test webrtc/video-mute.html is flaky.
>+        https://bugs.webkit.org/show_bug.cgi?id=177501
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by updated test expectation.
>+
>+        * platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
>+        (WebCore::createBlackPixelBuffer): Make sure the whole buffer is properly initialized.
>+
> 2018-09-18  Simon Fraser  <simon.fraser@apple.com>
> 
>         Remove the unused RenderLayerCompositor::enclosingCompositorFlushingLayers()
>diff --git a/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm b/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
>index d86a59f8c617d0770c5dff360bae26d25332890e..4e4a0f8676d61093e67d91a8520cd5f4aa8f977b 100644
>--- a/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
>+++ b/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
>@@ -73,9 +73,12 @@ RetainPtr<CVPixelBufferRef> createBlackPixelBuffer(size_t width, size_t height)
>     status = CVPixelBufferLockBaseAddress(pixelBuffer, 0);
>     ASSERT(status == noErr);
>     void* data = CVPixelBufferGetBaseAddress(pixelBuffer);
>+
>     size_t yLength = width * height;
>     memset(data, 0, yLength);
>-    memset(static_cast<uint8_t*>(data) + yLength, 128, yLength / 2);
>+
>+    auto totalSize = CVPixelBufferGetDataSize(pixelBuffer);
>+    memset(static_cast<uint8_t*>(data) + yLength, 128, totalSize - yLength);
> 
>     status = CVPixelBufferUnlockBaseAddress(pixelBuffer, 0);
>     ASSERT(!status);
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4b81bc1389b11ccccc9f461969266fa1514153c8..629ea1a1a57b6309ed3c1dcb8ea15a9984772395 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-18  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout Test webrtc/video-mute.html is flaky.
>+        https://bugs.webkit.org/show_bug.cgi?id=177501
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/ios-wk2/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+        * webrtc/routines.js: Increase counter to make test more robust.
>+
> 2018-09-18  Youenn Fablet  <youenn@apple.com>
> 
>         Enable Unified Plan by default
>diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations
>index 0b27c86017c7244272bce0f4bc2a27645cf4af8d..9c0b1ca179864d45f2a7f9251b0a63e112d85521 100644
>--- a/LayoutTests/platform/ios-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-wk2/TestExpectations
>@@ -1234,8 +1234,6 @@ webkit.org/b/176240 http/tests/websocket/tests/hybi/handshake-ok-with-legacy-web
> 
> webkit.org/b/173608 webrtc/video-replace-muted-track.html [ Skip ]
> 
>-webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
>-
> webkit.org/b/187388 animations/needs-layout.html [ Pass ImageOnlyFailure ]
> webkit.org/b/172397 legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]
> 
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index a74d475d684988fc748a8a88e22d9cd8d0f10c03..cf048f4b75d6c7deb73be695e71cb512c67b072e 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -783,8 +783,6 @@ webkit.org/b/176881 plugins/js-from-destroy.html [ Pass Failure ]
> 
> webkit.org/b/178553 [ HighSierra Release ] imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/011.html [ Skip ]
> 
>-webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
>-
> webkit.org/b/165620 [ Sierra ] http/tests/cache/disk-cache/disk-cache-request-headers.html [ Pass Failure ]
> 
> webkit.org/b/179773 imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html [ Pass Failure ]
>diff --git a/LayoutTests/webrtc/routines.js b/LayoutTests/webrtc/routines.js
>index 11499aefc03663257b0fa032ac2022db5de91fe3..2fb0dc79162ec6fdd32e886ca673a23a58aa0415 100644
>--- a/LayoutTests/webrtc/routines.js
>+++ b/LayoutTests/webrtc/routines.js
>@@ -195,7 +195,7 @@ async function checkVideoBlack(expected, canvas, video, errorMessage, counter)
> 
>     if (counter === undefined)
>         counter = 0;
>-    if (counter > 50) {
>+    if (counter > 400) {
>         if (!errorMessage)
>             errorMessage = "checkVideoBlack timed out expecting " + expected;
>         return Promise.reject(errorMessage);

Actions: View | Formatted Diff | Diff

Attachments on bug 177501: 350025 | 350035 | 350065 | 350067