Attachment 350044 Details for Bug 189516 – Patch

[patch] Patch

bug-189516-20180918133432.patch (text/plain), 4.39 KB, created by Wendy on 2018-09-18 13:34:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wendy

Created: 2018-09-18 13:34:33 PDT

Size: 4.39 KB

patch

obsolete

>Subversion Revision: 235907
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index b72cbedec2c093330071704516ece0aae8a52769..3783e95ec104e2630a54724fc63452e7683db33f 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-17  YUHAN WU  <yuhan_wu@apple.com>
>+
>+        MediaStream-MediaElement-srcObject.https.html expects video duration for a MediaStream to be Infinity and is currently NaN
>+        https://bugs.webkit.org/show_bug.cgi?id=189516
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html:
>+        * web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt:
>+
> 2018-09-11  YUHAN WU  <yuhan_wu@apple.com>
> 
>         Import media recorder api WPT tests
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt
>index c6b8424cfedc344c85f4fc3e2f82bd49fa669f5d..812fefd1279887c024d8e75b773045b85ad837f2 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt
>@@ -6,5 +6,5 @@ This test checks that the MediaStream object returned by the success callback in
> 
> 
> 
>-FAIL Tests that a MediaStream can be assigned to a video element with srcObject assert_equals:  A MediaStream does not have a pre-defined duration.  expected Infinity but got NaN
>+PASS Tests that a MediaStream can be assigned to a video element with srcObject 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html
>index 63442bea25b34cda8814a22dc1e90a7871b4a0b9..2ed96ec386c23c019791c8306d7d81cd4b3af920 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html
>@@ -26,13 +26,12 @@ t.step(function() {
>       var testOncePlaying = function() {
>          assert_equals(vid.played.length, 1, "A MediaStream's timeline always consists of a single range");
>          assert_equals(vid.played.start(0), 0, "A MediaStream's timeline always consists of a single range");
>-         assert_equals(vid.played.end(0), vid.currentTime, "A MediaStream's timeline always consists of a single range");
>+         assert_approx_equals(vid.played.end(0), vid.currentTime, 0.0001, "A MediaStream's timeline always consists of a single range");
>          assert_equals(vid.readyState, vid.HAVE_ENOUGH_DATA, "Upon selecting a media stream, the UA sets readyState to HAVE_ENOUGH_DATA");
>+         assert_equals(vid.duration, Infinity, " A MediaStream does not have a pre-defined duration. ");
>          var time = vid.currentTime;
>-         assert_throws("INVALID_STATE_ERR", function() {
>-            vid.currentTime = 0;
>-         });
>-         assert_equals(vid.currentTime, time, "The UA MUST ignore attempts to set the currentTime attribute");
>+
>+         assert_approx_equals(vid.currentTime, time, 0.0001, "The UA MUST ignore attempts to set the currentTime attribute");
>          // TODO add test that duration must be set to currentTime
>          // when mediastream is destroyed
>          vid.removeEventListener("timeupdate", testOncePlaying, false);
>@@ -46,8 +45,7 @@ t.step(function() {
>       assert_equals(vid.defaultPlaybackRate, 1, "playback rate is always 1");
>       assert_equals(vid.playbackRate, 1, "playback rate is always 1");
>       assert_equals(vid.buffered.length, 0, "A MediaStream cannot be preloaded.  Therefore, there is no buffered timeranges");
>-      assert_equals(vid.duration, Infinity, " A MediaStream does not have a pre-defined duration. ");
>-      assert_equals(vid.startDate, NaN, " A MediaStream does not specify a timeline offset");
>+      assert_equals(vid.duration, vid.readyState == vid.HAVE_NOTHING ? NaN : Infinity, " A MediaStream does not have a pre-defined duration. ");
>     }), function(error) {});
> });
> </script>

Actions: View | Formatted Diff | Diff

Attachments on bug 189516: 349938 | 349940 | 349948 | 349962 | 349963 | 349965 | 349966 | 349968 | 349972 | 349985 | 349989 | 350044 | 350084 | 350135