WebKit Bugzilla
Attachment 350031 Details for
Bug 189702
: webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189702-20180918102933.patch (text/plain), 2.89 KB, created by
Jonathan Bedard
on 2018-09-18 10:29:34 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jonathan Bedard
Created:
2018-09-18 10:29:34 PDT
Size:
2.89 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 236144) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2018-09-18 Jonathan Bedard <jbedard@apple.com> >+ >+ webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports >+ https://bugs.webkit.org/show_bug.cgi?id=189702 >+ <rdar://problem/44541704> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/webkitpy/layout_tests/controllers/manager.py: >+ (Manager._set_up_run): Move build check and clobbering to run, since set up is >+ run multiple times for iOS simulator. >+ (Manager.run): >+ > 2018-09-18 Chris Dumez <cdumez@apple.com> > > "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache >Index: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py >=================================================================== >--- Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (revision 234812) >+++ Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (working copy) >@@ -160,11 +160,6 @@ class Manager(object): > self._options.child_processes = worker_count > > def _set_up_run(self, test_names, device_class=None): >- self._printer.write_update("Checking build ...") >- if not self._port.check_build(): >- _log.error("Build check failed") >- return False >- > self._options.device_class = device_class > > # This must be started before we check the system dependencies, >@@ -183,12 +178,6 @@ class Manager(object): > self._port.stop_helper() > return False > >- if self._options.clobber_old_results: >- self._clobber_old_results() >- >- # Create the output directory if it doesn't already exist. >- self._port.host.filesystem.maybe_make_directory(self._results_directory) >- > self._port.setup_test_run(self._options.device_class) > return True > >@@ -239,6 +228,17 @@ class Manager(object): > self._runner = LayoutTestRunner(self._options, self._port, self._printer, self._results_directory, self._test_is_slow, > needs_http=needs_http, needs_web_platform_test_server=needs_web_platform_test_server, needs_websockets=needs_websockets) > >+ self._printer.write_update("Checking build ...") >+ if not self._port.check_build(): >+ _log.error("Build check failed") >+ return test_run_results.RunDetails(exit_code=-1) >+ >+ if self._options.clobber_old_results: >+ self._clobber_old_results() >+ >+ # Create the output directory if it doesn't already exist. >+ self._port.host.filesystem.maybe_make_directory(self._results_directory) >+ > if default_device_tests: > _log.info('') > _log.info("Running %s", pluralize(len(tests_to_run), "test"))
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189702
: 350031