Attachment 350020 Details for Bug 189698 – Patch for landing

[patch] Patch for landing

bug-189698-20180918163421.patch (text/plain), 6.01 KB, created by Manuel Rego Casasnovas on 2018-09-18 07:34:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Manuel Rego Casasnovas

Created: 2018-09-18 07:34:23 PDT

Size: 6.01 KB

patch

obsolete

>Subversion Revision: 236104
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 578df152123214b1a2fb1a5ff370f687be7f95a6..aecb2a26a4b9992d35e911ccea84503878136eab 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2018-09-18  Manuel Rego Casasnovas  <rego@igalia.com>
>+
>+        [css-grid] Static position should use content-box, not padding-box
>+        https://bugs.webkit.org/show_bug.cgi?id=189698
>+
>+        Reviewed by Javier Fernandez.
>+
>+        This is a recent change by the CSSWG:
>+        https://github.com/w3c/csswg-drafts/issues/3020
>+
>+        The spec text (https://drafts.csswg.org/css-grid/#static-position):
>+          "The static position of an absolutely-positioned child
>+           of a grid container is determined as if it were the sole grid item
>+           in a grid area whose edges coincide with the content edges
>+           of the grid container."
>+
>+        Test: imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html
>+
>+        * rendering/RenderGrid.cpp:
>+        (WebCore::RenderGrid::prepareChildForPositionedLayout):
>+        Simple change to use border and padding.
>+
> 2018-09-18  Xabier Rodriguez Calvar  <calvaris@igalia.com>
> 
>         [EME][GStreamer] The current EME implementation doesn't support the waitingforkey event
>diff --git a/Source/WebCore/rendering/RenderGrid.cpp b/Source/WebCore/rendering/RenderGrid.cpp
>index b903ef00ace2f694bd0dc3b6964d76e0ed6ab79c..99e0d61fe56530c2dabda4a7675fae282d96988d 100644
>--- a/Source/WebCore/rendering/RenderGrid.cpp
>+++ b/Source/WebCore/rendering/RenderGrid.cpp
>@@ -903,8 +903,9 @@ void RenderGrid::prepareChildForPositionedLayout(RenderBox& child)
>     child.containingBlock()->insertPositionedObject(child);
> 
>     RenderLayer* childLayer = child.layer();
>-    childLayer->setStaticInlinePosition(borderStart());
>-    childLayer->setStaticBlockPosition(borderBefore());
>+    // Static position of a positioned child should use the content-box (https://drafts.csswg.org/css-grid/#static-position).
>+    childLayer->setStaticInlinePosition(borderAndPaddingStart());
>+    childLayer->setStaticBlockPosition(borderAndPaddingBefore());
> }
> 
> bool RenderGrid::hasStaticPositionForChild(const RenderBox& child, GridTrackSizingDirection direction) const
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 94fed533a9b89f0107cbbd2b27a0ec1f4e5b48a3..5390d2783798d46299cbbe430ec370c4effa1c54 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-18  Manuel Rego Casasnovas  <rego@igalia.com>
>+
>+        [css-grid] Static position should use content-box, not padding-box
>+        https://bugs.webkit.org/show_bug.cgi?id=189698
>+
>+        Reviewed by Javier Fernandez.
>+
>+        * web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html:
>+        Update tests from WPT.
>+
> 2018-09-12  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Update composedPath to match the latest spec
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html b/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html
>index e798b80d9d03ccb0739c04e59b3c26ab86e1f6af..a7a38ad0a0ab8c8fa13b7fac0a75268e1a026cbb 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html
>@@ -41,19 +41,19 @@
> 
> <div class="container relative">
>   <div class="grid">
>-    <div class="sizedToGridArea absolute autoRowAutoColumn" data-offset-x="35" data-offset-y="5" data-expected-width="500" data-expected-height="400"></div>
>+    <div class="sizedToGridArea absolute autoRowAutoColumn" data-offset-x="50" data-offset-y="10" data-expected-width="500" data-expected-height="400"></div>
>   </div>
> </div>
> 
> <div class="container relative">
>   <div class="grid">
>-    <div class="sizedToGridArea absolute firstRowFirstColumn" data-offset-x="35" data-offset-y="5" data-expected-width="500" data-expected-height="400"></div>
>+    <div class="sizedToGridArea absolute firstRowFirstColumn" data-offset-x="50" data-offset-y="10" data-expected-width="500" data-expected-height="400"></div>
>   </div>
> </div>
> 
> <div class="container relative">
>   <div class="grid">
>-    <div class="sizedToGridArea absolute secondRowSecondColumn" data-offset-x="35" data-offset-y="5" data-expected-width="500" data-expected-height="400"></div>
>+    <div class="sizedToGridArea absolute secondRowSecondColumn" data-offset-x="50" data-offset-y="10" data-expected-width="500" data-expected-height="400"></div>
>   </div>
> </div>
> 
>@@ -77,19 +77,19 @@
> 
> <div class="container relative">
>   <div class="grid directionRTL">
>-    <div class="sizedToGridArea absolute autoRowAutoColumn" data-offset-x="-135" data-offset-y="5" data-expected-width="500" data-expected-height="400"></div>
>+    <div class="sizedToGridArea absolute autoRowAutoColumn" data-offset-x="-150" data-offset-y="10" data-expected-width="500" data-expected-height="400"></div>
>   </div>
> </div>
> 
> <div class="container relative">
>   <div class="grid directionRTL">
>-    <div class="sizedToGridArea absolute firstRowFirstColumn" data-offset-x="-135" data-offset-y="5" data-expected-width="500" data-expected-height="400"></div>
>+    <div class="sizedToGridArea absolute firstRowFirstColumn" data-offset-x="-150" data-offset-y="10" data-expected-width="500" data-expected-height="400"></div>
>   </div>
> </div>
> 
> <div class="container relative">
>   <div class="grid directionRTL">
>-    <div class="sizedToGridArea absolute secondRowSecondColumn" data-offset-x="-135" data-offset-y="5" data-expected-width="500" data-expected-height="400"></div>
>+    <div class="sizedToGridArea absolute secondRowSecondColumn" data-offset-x="-150" data-offset-y="10" data-expected-width="500" data-expected-height="400"></div>
>   </div>
> </div>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189698: 350016 | 350020