Attachment 349960 Details for Bug 189675 – Patch

[patch] Patch

bug-189675-20180917155837.patch (text/plain), 4.71 KB, created by youenn fablet on 2018-09-17 15:58:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-09-17 15:58:38 PDT

Size: 4.71 KB

patch

obsolete

>Subversion Revision: 236030
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2e760640fbb29d611580588e6527534bfd221107..41daba3339e186ff0010be26276df0d1b4313104 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-17  Youenn Fablet  <youenn@apple.com>
>+
>+        Enable Unified Plan by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189675
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        RTCRtpTransceiver.currentDirection is now gated by the unified plan runtime flag.
>+        This will allow easy feature detection of unified plan support.
>+        Covered by updated test.
>+
>+        * Modules/mediastream/RTCRtpTransceiver.idl:
>+
> 2018-09-17  Youenn Fablet  <youenn@apple.com>
> 
>         Implement RTCRtpReceiver getContributingSources/getSynchronizationSources
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 54441d45029076e2ab612c7a7e82bf622f2eb086..36e43344ede1b480611dc9a314e2f8b25c207c55 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-17  Youenn Fablet  <youenn@apple.com>
>+
>+        Enable Unified Plan by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189675
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2018-09-14  Matt Lewis  <jlewis3@apple.com>
> 
>         Unreviewed, rolling out r236020.
>diff --git a/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl b/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl
>index aa166028f2cc724912736512fc779092aa02ced6..157e05a355853d6c3c60cac876867df37217c33d 100644
>--- a/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl
>+++ b/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl
>@@ -40,7 +40,7 @@ typedef RTCRtpTransceiverDirection RtpTransceiverDirection;
>     [SameObject] readonly attribute RTCRtpReceiver receiver;
>     readonly attribute boolean stopped;
>     readonly attribute RtpTransceiverDirection direction;
>-    readonly attribute RTCRtpTransceiverDirection? currentDirection;
>+    [EnabledAtRuntime=WebRTCUnifiedPlan] readonly attribute RTCRtpTransceiverDirection? currentDirection;
>     void setDirection(RtpTransceiverDirection direction);
>     void stop();
>     // FIXME 169662: missing setCodecPreferences
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 3f83115a718195d3637f056ed6a0fdb1b47560e7..66f61586a9157f6d99461502a9a0ec4d48eb00ea 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -496,7 +496,7 @@ PeerConnectionEnabled:
> 
> WebRTCUnifiedPlanEnabled:
>   type: bool
>-  defaultValue: false
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>   webcoreBinding: RuntimeEnabledFeatures
>   condition: ENABLE(WEB_RTC)
>   humanReadableName: "WebRTC Unified Plan"
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 2b56b4c294158fefabcc278f618f6e68d356ae5b..464a58b0208f230de0c279288953bb5ab760a9a7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-17  Youenn Fablet  <youenn@apple.com>
>+
>+        Enable Unified Plan by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189675
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webrtc/video-addLegacyTransceiver-expected.txt:
>+        * webrtc/video-addLegacyTransceiver.html:
>+
> 2018-09-14  Youenn Fablet  <youenn@apple.com>
> 
>         Enable VCP for iOS and reenable it for MacOS
>diff --git a/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt b/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt
>index 8790e6b8b4104da2260286290776d4330788d8c6..332060d755ff09b29bad7b2705ca57a0f01daba7 100644
>--- a/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt
>+++ b/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt
>@@ -1,5 +1,6 @@
> 
> 
>+PASS Expose currentDirection only for unified plan 
> PASS Setting up calls with addTransceiver but with no track 
> PASS Setting up calls with addTransceiver with a track 
> PASS Basic video exchange set up with addTransceiver 
>diff --git a/LayoutTests/webrtc/video-addLegacyTransceiver.html b/LayoutTests/webrtc/video-addLegacyTransceiver.html
>index 3ca754c6e692f8468909bd888ec8836a3ec4a388..e1c227c120d21a6704377323f84c0c2fe05f75b0 100644
>--- a/LayoutTests/webrtc/video-addLegacyTransceiver.html
>+++ b/LayoutTests/webrtc/video-addLegacyTransceiver.html
>@@ -14,6 +14,10 @@
> if (window.testRunner)
>     testRunner.setWebRTCUnifiedPlanEnabled(false);
> 
>+test(() => {
>+    assert_equals(Object.keys(RTCRtpTransceiver.prototype).indexOf("currentDirection"), -1, "No currentDirection if unified plan is off");
>+}, "Expose currentDirection only for unified plan");
>+
> promise_test((test) => {
>     var pc = new RTCPeerConnection();
>     pc.addTransceiver("video");

Actions: View | Formatted Diff | Diff

Attachments on bug 189675: 349928 | 349949 | 349960