Attachment 349907 Details for Bug 189635 – iOS simulator build fix

[patch] iOS simulator build fix

bug-189635-20180917110522.patch (text/plain), 1.67 KB, created by youenn fablet on 2018-09-17 11:05:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-09-17 11:05:23 PDT

Size: 1.67 KB

patch

obsolete

>Subversion Revision: 236030
>diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog
>index 7ab65af1ce61151ab134a495853bd4726c11af04..6c58d56457338cfb97058cae98b2942fc2b686f5 100644
>--- a/Source/ThirdParty/libwebrtc/ChangeLog
>+++ b/Source/ThirdParty/libwebrtc/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-17  Youenn Fablet  <youenn@apple.com>
>+
>+        Enable VCP for iOS and reenable it for MacOS
>+        https://bugs.webkit.org/show_bug.cgi?id=189635
>+        <rdar://problem/43621029>
>+
>+        Unreviewed, build fix for iOS simulator.
>+
>+        * Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
>+
> 2018-09-14  Youenn Fablet  <youenn@apple.com>
> 
>         Enable VCP for iOS and reenable it for MacOS
>diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h b/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h
>index 9540f6e2607ed84d1b1170d5ea096ab2fd021aea..5266f71ddafa5d568d7de8e0dfc7c86596233147 100644
>--- a/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h
>+++ b/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h
>@@ -33,7 +33,9 @@
> // Macro taken from WTF/wtf/Platform.h
> #if defined __has_include && __has_include(<CoreFoundation/CFPriv.h>)
> 
>-#if (defined(TARGET_OS_IPHONE)  && TARGET_OS_IPHONE)
>+#if (defined(TARGET_IPHONE_SIMULATOR)  && TARGET_IPHONE_SIMULATOR)
>+#define ENABLE_VCP_ENCODER 0
>+#elif (defined(TARGET_OS_IPHONE)  && TARGET_OS_IPHONE)
> #define ENABLE_VCP_ENCODER (__IPHONE_OS_VERSION_MAX_ALLOWED >= 120000)
> #elif (defined(TARGET_OS_MAC)  && TARGET_OS_MAC)
> #define ENABLE_VCP_ENCODER (__MAC_OS_X_VERSION_MAX_ALLOWED >= 101304)

Actions: View | Formatted Diff | Diff

Attachments on bug 189635: 349822 | 349827 | 349831 | 349840 | 349843 | 349846 | 349847 | 349865 | 349893 | 349907 | 349956