Attachment 349896 Details for Bug 189096 – Patch for landing

[patch] Patch for landing

bug-189096-20180917103704.patch (text/plain), 1.38 KB, created by Jer Noble on 2018-09-17 10:37:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-09-17 10:37:05 PDT

Size: 1.38 KB

patch

obsolete

>Subversion Revision: 236018
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm
>index 9389476f3ce88e77fff710274bdc596fbb0a4b88..6c4ab23661269f5c1ac10e176c7edc1081a9351b 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm
>@@ -25,10 +25,11 @@
> 
> #include "config.h"
> 
>-#if WK_API_ENABLED && USE(MEDIAREMOTE) && (PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101304))
>+#if WK_API_ENABLED && USE(MEDIAREMOTE) && !PLATFORM(IOS_SIMULATOR) && (PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101304))
> 
> #import "PlatformUtilities.h"
> #import "TestWKWebView.h"
>+#import <WebKit/WKWebViewConfigurationPrivate.h>
> #import <WebKit/WKWebViewPrivate.h>
> #import <pal/spi/mac/MediaRemoteSPI.h>
> #import <wtf/Function.h>
>@@ -89,6 +90,10 @@ public:
> 
>         _configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
>         [_configuration setMediaTypesRequiringUserActionForPlayback:WKAudiovisualMediaTypeAudio];
>+#if PLATFORM(IOS)
>+        [_configuration setAllowsInlineMediaPlayback:YES];
>+        [_configuration _setInlineMediaPlaybackRequiresPlaysInlineAttribute:NO];
>+#endif
> 
>         _webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 300, 300) configuration:_configuration.get() addToWindow:YES]);
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 189096: 348430 | 348444 | 348450 | 348530 | 348553 | 348644 | 348645 | 349316 | 349408 | 349442 | 349446 | 349896 | 349897 | 349898 | 349904 | 349909