Attachment 349891 Details for Bug 189665 – Patch

[patch] Patch

bug-189665-20180917091622.patch (text/plain), 23.66 KB, created by Jeremy Jones on 2018-09-17 09:16:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-09-17 09:16:23 PDT

Size: 23.66 KB

patch

obsolete

>Subversion Revision: 235121
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5248e3f5f7c371854f00295d3aaf4ec9edcaae89..a402e046aa618ed467b1437510edd88fbc52bf61 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-09-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Add setting RequiresUserGestureToLoadVideo to enable more tests on iOS.
>+        https://bugs.webkit.org/show_bug.cgi?id=189665
>+        rdar://problem/44522223
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Expose RequiresUserGestureToLoadVideo preference.
>+
>+        * Shared/WebPreferences.yaml:
>+        * Shared/WebPreferencesDefaultValues.h:
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _initializeWithConfiguration:]):
>+        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
>+        (-[WKWebViewConfiguration init]):
>+        (-[WKWebViewConfiguration copyWithZone:]):
>+        (-[WKWebViewConfiguration _requiresUserGestureToLoadVideo]):
>+        (-[WKWebViewConfiguration _setRequiresUserGestureToLoadVideo:]):
>+        * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
>+
> 2018-08-21  Daniel Bates  <dabates@apple.com>
> 
>         Replace TextCheckingTypeMask with OptionSet
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index df66f6ce9880460dedb40372753dd9ae45e18620..9af1555c5080a8a66eb98ae3df2cd92e6d80cf5a 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-09-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Add setting RequiresUserGestureToLoadVideo to enable more tests on iOS.
>+        https://bugs.webkit.org/show_bug.cgi?id=189665
>+        rdar://problem/44522223
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Expose RequiresUserGestureToLoadVideo preference.
>+
>+        * WebView/WebPreferenceKeysPrivate.h:
>+        * WebView/WebPreferences.mm:
>+        (shouldRequireUserGestureToLoadVideo):
>+        (+[WebPreferences initialize]):
>+        (-[WebPreferences requiresUserGestureToLoadVideo]):
>+        (-[WebPreferences setRequiresUserGestureToLoadVideo:]):
>+        * WebView/WebPreferencesPrivate.h:
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2018-08-21  Daniel Bates  <dabates@apple.com>
> 
>         Replace TextCheckingTypeMask with OptionSet
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 260221cb30cd25bf524c22b74e6525187fb8001c..2e453e4059c65bdf428068409c3f9b2cdf3e01d1 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -220,7 +220,7 @@ RequiresUserGestureForAudioPlayback:
> 
> RequiresUserGestureToLoadVideo:
>   type: bool
>-  defaultValue: false
>+  defaultValue: DEFAULT_REQUIRES_USER_GESTURE_TO_LOAD_VIDEO
> 
> MainContentUserGestureOverrideEnabled:
>   type: bool
>diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.h b/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>index 47812b142f46c06962bfc96cfdc2dcc6a1dc9a72..2cc892ed6b081c2463e3e48702e3b65e1497e88b 100644
>--- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>+++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>@@ -74,6 +74,7 @@
> #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM false
> #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED false
> #define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK true
>+#define DEFAULT_REQUIRES_USER_GESTURE_TO_LOAD_VIDEO true
> #define DEFAULT_INTERACTIVE_MEDIA_CAPTURE_STREAM_REPROMPT_INTERVAL_IN_MINUTES 1
> #define EXPERIMENTAL_FULLSCREEN_API_HIDDEN false
> #else
>@@ -93,6 +94,7 @@
> #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM true
> #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED true
> #define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK false
>+#define DEFAULT_REQUIRES_USER_GESTURE_TO_LOAD_VIDEO false
> #define DEFAULT_INTERACTIVE_MEDIA_CAPTURE_STREAM_REPROMPT_INTERVAL_IN_MINUTES 10
> #define EXPERIMENTAL_FULLSCREEN_API_HIDDEN true
> #endif
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index f02301813e02af3362bfc5b3c47e39dafd1c4f5e..1faf3ba98dd0b7617c0b4e2528b1d0b8f7d37afb 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -427,16 +427,6 @@ static bool shouldAllowSettingAnyXHRHeaderFromFileURLs()
> 
> #endif
> 
>-static bool shouldRequireUserGestureToLoadVideo()
>-{
>-#if PLATFORM(IOS)
>-    static bool shouldRequireUserGestureToLoadVideo = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
>-    return shouldRequireUserGestureToLoadVideo;
>-#else
>-    return false;
>-#endif
>-}
>-
> #if PLATFORM(MAC)
> static uint32_t convertUserInterfaceDirectionPolicy(WKUserInterfaceDirectionPolicy policy)
> {
>@@ -569,7 +559,7 @@ - (void)_initializeWithConfiguration:(WKWebViewConfiguration *)configuration
>     WKAudiovisualMediaTypes mediaTypesRequiringUserGesture = [_configuration mediaTypesRequiringUserActionForPlayback];
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::requiresUserGestureForVideoPlaybackKey(), WebKit::WebPreferencesStore::Value((mediaTypesRequiringUserGesture & WKAudiovisualMediaTypeVideo) == WKAudiovisualMediaTypeVideo));
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::requiresUserGestureForAudioPlaybackKey(), WebKit::WebPreferencesStore::Value(((mediaTypesRequiringUserGesture & WKAudiovisualMediaTypeAudio) == WKAudiovisualMediaTypeAudio)));
>-    pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::requiresUserGestureToLoadVideoKey(), WebKit::WebPreferencesStore::Value(shouldRequireUserGestureToLoadVideo()));
>+    pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::requiresUserGestureToLoadVideoKey(), WebKit::WebPreferencesStore::Value(!![_configuration _requiresUserGestureToLoadVideo]));
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::mainContentUserGestureOverrideEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _mainContentUserGestureOverrideEnabled]));
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::invisibleAutoplayNotPermittedKey(), WebKit::WebPreferencesStore::Value(!![_configuration _invisibleAutoplayNotPermitted]));
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::mediaDataLoadsAutomaticallyKey(), WebKit::WebPreferencesStore::Value(!![_configuration _mediaDataLoadsAutomatically]));
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>index bf187ffcb69fd62463266914ca5248edcf8c0e87..687de4dc6a35ff1ec2913f879ec8001782369bb9 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>@@ -105,6 +105,7 @@ static _WKDragLiftDelay toDragLiftDelay(NSUInteger value)
> 
> #endif
> 
>+
> @implementation WKWebViewConfiguration {
>     RefPtr<API::PageConfiguration> _pageConfiguration;
>     LazyInitialized<RetainPtr<WKProcessPool>> _processPool;
>@@ -137,6 +138,7 @@ @implementation WKWebViewConfiguration {
> 
>     BOOL _invisibleAutoplayNotPermitted;
>     BOOL _mediaDataLoadsAutomatically;
>+    BOOL _requiresUserGestureToLoadVideo;
>     BOOL _attachmentElementEnabled;
>     BOOL _mainContentUserGestureOverrideEnabled;
> 
>@@ -178,6 +180,7 @@ - (instancetype)init
>     _inlineMediaPlaybackRequiresPlaysInlineAttribute = !_allowsInlineMediaPlayback;
>     _allowsInlineMediaPlaybackAfterFullscreen = !_allowsInlineMediaPlayback;
>     _mediaDataLoadsAutomatically = NO;
>+    _requiresUserGestureToLoadVideo = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
> #if !PLATFORM(WATCHOS)
>     if (WebKit::linkedOnOrAfter(WebKit::SDKVersion::FirstWithMediaTypesRequiringUserActionForPlayback))
>         _mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAudio;
>@@ -189,6 +192,7 @@ - (instancetype)init
> #else
>     _mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeNone;
>     _mediaDataLoadsAutomatically = YES;
>+    _requiresUserGestureToLoadVideo = NO;
>     _userInterfaceDirectionPolicy = WKUserInterfaceDirectionPolicyContent;
>     _legacyEncryptedMediaAPIEnabled = YES;
> #endif
>@@ -351,6 +355,7 @@ - (id)copyWithZone:(NSZone *)zone
> 
>     configuration->_invisibleAutoplayNotPermitted = self->_invisibleAutoplayNotPermitted;
>     configuration->_mediaDataLoadsAutomatically = self->_mediaDataLoadsAutomatically;
>+    configuration->_requiresUserGestureToLoadVideo = self->_requiresUserGestureToLoadVideo;
>     configuration->_attachmentElementEnabled = self->_attachmentElementEnabled;
>     configuration->_mediaTypesRequiringUserActionForPlayback = self->_mediaTypesRequiringUserActionForPlayback;
>     configuration->_mainContentUserGestureOverrideEnabled = self->_mainContentUserGestureOverrideEnabled;
>@@ -731,6 +736,16 @@ - (void)_setMediaDataLoadsAutomatically:(BOOL)mediaDataLoadsAutomatically
>     _mediaDataLoadsAutomatically = mediaDataLoadsAutomatically;
> }
> 
>+- (BOOL)_requiresUserGestureToLoadVideo
>+{
>+    return _requiresUserGestureToLoadVideo;
>+}
>+
>+- (void)_setRequiresUserGestureToLoadVideo:(BOOL)requiresUserGestureToLoadVideo
>+{
>+    _requiresUserGestureToLoadVideo = requiresUserGestureToLoadVideo;
>+}
>+
> - (BOOL)_attachmentElementEnabled
> {
>     return _attachmentElementEnabled;
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
>index ac9d5e52dfb0376f86e84a1fd0a1e29a86ec0580..622f2af5c7680b24fcc98ca9a024fc7d4725baf9 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
>@@ -64,6 +64,7 @@ typedef NS_ENUM(NSUInteger, _WKDragLiftDelay) {
> @property (nonatomic, setter=_setMainContentUserGestureOverrideEnabled:) BOOL _mainContentUserGestureOverrideEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> @property (nonatomic, setter=_setInvisibleAutoplayNotPermitted:) BOOL _invisibleAutoplayNotPermitted WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> @property (nonatomic, setter=_setMediaDataLoadsAutomatically:) BOOL _mediaDataLoadsAutomatically WK_API_AVAILABLE(macosx(10.12), ios(10.0));
>+@property (nonatomic, setter=_setRequiresUserGestureToLoadVideo:) BOOL _requiresUserGestureToLoadVideo;
> @property (nonatomic, setter=_setAttachmentElementEnabled:) BOOL _attachmentElementEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> @property (nonatomic, setter=_setInitialCapitalizationEnabled:) BOOL _initialCapitalizationEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> @property (nonatomic, setter=_setApplePayEnabled:) BOOL _applePayEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>index fc7bf743c00b09de3b0df8fb52e35e4b1136e14e..d7d7f84a79e71c97f89f9a1d9e80d087ff4d8f0d 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>@@ -242,6 +242,7 @@
> 
> #define WebKitEnableInheritURIQueryComponentPreferenceKey @"WebKitEnableInheritURIQueryComponent"
> #define WebKitMediaDataLoadsAutomaticallyPreferenceKey @"WebKitMediaDataLoadsAutomatically"
>+#define WebKitRequiresUserGestureToLoadVideoPreferenceKey @"WebKitRequiresUserGestureToLoadVideo"
> #define WebKitMockCaptureDevicesEnabledPreferenceKey @"WebKitMockCaptureDevicesEnabled"
> #define WebKitMockCaptureDevicesPromptEnabledPreferenceKey @"WebKitMockCaptureDevicesPromptEnabled"
> #define WebKitEnumeratingAllNetworkInterfacesEnabledPreferenceKey @"WebKitEnumeratingAllNetworkInterfacesEnabled"
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index 3a986070eb3cb6a7161a9925c09eee59d85eb1b8..194134a7d2dfa4e89dab960f37ba06d7a3c77b2f 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -386,6 +386,16 @@ + (WebPreferences *)standardPreferences
>     return _standardPreferences;
> }
> 
>+static bool shouldRequireUserGestureToLoadVideo()
>+{
>+#if PLATFORM(IOS)
>+    static bool shouldRequireUserGestureToLoadVideo = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
>+    return shouldRequireUserGestureToLoadVideo;
>+#else
>+    return false;
>+#endif
>+}
>+
> // if we ever have more than one WebPreferences object, this would move to init
> + (void)initialize
> {
>@@ -533,6 +543,7 @@ + (void)initialize
>         [NSNumber numberWithBool:YES],  WebKitAVFoundationNSURLSessionEnabledKey,
>         [NSNumber numberWithBool:NO],   WebKitSuppressesIncrementalRenderingKey,
>         [NSNumber numberWithBool:attachmentElementEnabled], WebKitAttachmentElementEnabledPreferenceKey,
>+        [NSNumber numberWithBool:shouldRequireUserGestureToLoadVideo()],   WebKitRequiresUserGestureToLoadVideoPreferenceKey,
> #if !PLATFORM(IOS)
>         [NSNumber numberWithBool:YES],  WebKitAllowsInlineMediaPlaybackPreferenceKey,
>         [NSNumber numberWithBool:NO],   WebKitAllowsInlineMediaPlaybackAfterFullscreenPreferenceKey,
>@@ -2903,6 +2914,16 @@ - (void)setMediaDataLoadsAutomatically:(BOOL)flag
>     [self _setBoolValue:flag forKey:WebKitMediaDataLoadsAutomaticallyPreferenceKey];
> }
> 
>+- (BOOL)requiresUserGestureToLoadVideo
>+{
>+    return [self _boolValueForKey:WebKitRequiresUserGestureToLoadVideoPreferenceKey];
>+}
>+
>+- (void)setRequiresUserGestureToLoadVideo:(BOOL)flag
>+{
>+    [self _setBoolValue:flag forKey:WebKitRequiresUserGestureToLoadVideoPreferenceKey];
>+}
>+
> - (BOOL)attachmentElementEnabled
> {
>     return [self _boolValueForKey:WebKitAttachmentElementEnabledPreferenceKey];
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>index 2f1ddc4971ece4f3697199f3fa648fb6664d23b9..2a1c12b48e9dff42d5be6fd691167d69d329fba0 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>@@ -591,6 +591,7 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> @property (nonatomic) BOOL animatedImageAsyncDecodingEnabled;
> @property (nonatomic) BOOL javaScriptMarkupEnabled;
> @property (nonatomic) BOOL mediaDataLoadsAutomatically;
>+@property (nonatomic) BOOL requiresUserGestureToLoadVideo;
> @property (nonatomic) BOOL attachmentElementEnabled;
> @property (nonatomic) BOOL allowsInlineMediaPlaybackAfterFullscreen;
> @property (nonatomic) BOOL intersectionObserverEnabled;
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index b892734caff365dd78549d87ec0a0394976b6666..9f8e4d1f3e273bc36812db82962b2b3ff0b8545f 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -1307,16 +1307,6 @@ static bool shouldConvertInvalidURLsToBlank()
>     return shouldConvertInvalidURLsToBlank;
> }
> 
>-static bool shouldRequireUserGestureToLoadVideo()
>-{
>-#if PLATFORM(IOS)
>-    static bool shouldRequireUserGestureToLoadVideo = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
>-    return shouldRequireUserGestureToLoadVideo;
>-#else
>-    return false;
>-#endif
>-}
>-
> #if ENABLE(GAMEPAD)
> static void WebKitInitializeGamepadProviderIfNecessary()
> {
>@@ -2907,7 +2897,7 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
>     BOOL mediaPlaybackRequiresUserGesture = [preferences mediaPlaybackRequiresUserGesture];
>     settings.setVideoPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture || [preferences videoPlaybackRequiresUserGesture]);
>     settings.setAudioPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture || [preferences audioPlaybackRequiresUserGesture]);
>-    settings.setRequiresUserGestureToLoadVideo(shouldRequireUserGestureToLoadVideo());
>+    settings.setRequiresUserGestureToLoadVideo([preferences requiresUserGestureToLoadVideo]);
>     settings.setMainContentUserGestureOverrideEnabled([preferences overrideUserGestureRequirementForMainContent]);
>     settings.setAllowsInlineMediaPlayback([preferences mediaPlaybackAllowsInline]);
>     settings.setAllowsInlineMediaPlaybackAfterFullscreen([preferences allowsInlineMediaPlaybackAfterFullscreen]);
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6d81cc61fe68e583cbd04ac16830f8da08744126..a3f77fd097f98bd1a0b45027452219c517f44f7e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-09-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Add setting RequiresUserGestureToLoadVideo to enable more tests on iOS.
>+        https://bugs.webkit.org/show_bug.cgi?id=189665
>+        rdar://problem/44522223
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Set RequiresUserGestureToLoadVideo to false so there is consistent behavior across platforms. 
>+
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (resetWebPreferencesToConsistentValues):
>+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
>+        (WTR::initializeWebViewConfiguration):
>+
> 2018-08-20  Alex Christensen  <achristensen@webkit.org>
> 
>         Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
>diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>index 43069ccdf23d1bd437bc3f0be260e1497433a550..fef3f23149fafaffe1d2e370ec0cdc67e8e40c6a 100644
>--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>@@ -934,6 +934,7 @@ static void resetWebPreferencesToConsistentValues()
>     [preferences setVideoPlaybackRequiresUserGesture:NO];
>     [preferences setAudioPlaybackRequiresUserGesture:NO];
>     [preferences setMediaDataLoadsAutomatically:YES];
>+    [preferences setRequiresUserGestureToLoadVideo:NO];
>     [preferences setInvisibleAutoplayNotPermitted:NO];
>     [preferences setSubpixelAntialiasedLayerTextEnabled:NO];
> 
>diff --git a/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm b/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>index 5d495eb736e5af76634fb9b3d062ff434790db15..88ace57270d7a298c8328f39d815029e067e1372 100644
>--- a/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>+++ b/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>@@ -87,6 +87,7 @@ void initializeWebViewConfiguration(const char* libraryPath, WKStringRef injecte
>     globalWebViewConfiguration._inlineMediaPlaybackRequiresPlaysInlineAttribute = NO;
>     globalWebViewConfiguration._invisibleAutoplayNotPermitted = NO;
>     globalWebViewConfiguration._mediaDataLoadsAutomatically = YES;
>+    globalWebViewConfiguration._requiresUserGestureToLoadVideo = NO;
>     globalWebViewConfiguration.requiresUserActionForMediaPlayback = NO;
> #endif
>     globalWebViewConfiguration.mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeNone;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e8948f4448eff6dbebee9cdfd7fada067e12b83f..b2d8fcc080e61e55e63bef9d1387469745ad90d1 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Add setting RequiresUserGestureToLoadVideo to enable more tests on iOS.
>+        https://bugs.webkit.org/show_bug.cgi?id=189665
>+        rdar://problem/44522223
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable more tests on iOS that depend on RequiresUserGestureToLoadVideo.
>+
>+        * platform/ios/TestExpectations:
>+
> 2018-08-21  Daniel Bates  <dabates@apple.com>
> 
>         Disallow navigations when page cache updates the current document of the frame
>diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations
>index 45f51f894c1a31bc5a8f7b15e358a3ca71b4f03a..fe370fd51541bdd4198b95ab5b6393371b04501c 100644
>--- a/LayoutTests/platform/ios/TestExpectations
>+++ b/LayoutTests/platform/ios/TestExpectations
>@@ -2576,13 +2576,11 @@ webkit.org/b/136708 media/media-fullscreen-not-in-document.html
> media/document-level-media-user-gesture-quirk.html
> media/media-controls-accessibility.html [ Timeout ]
> media/media-fullscreen-return-to-inline.html
>-media/no-autoplay-with-user-gesture-requirement.html
> media/video-controls-drag.html
> media/video-controls-fullscreen-volume.html
> media/video-controls-no-display-with-text-track.html
> media/video-controls-show-on-kb-or-ax-event.html
> media/video-fullscreen-restriction-removed.html
>-media/video-playsinline.html
> media/video-remote-control-playpause.html
> media/video-volume-slider-drag.html
> media/video-webkit-playsinline.html
>@@ -2604,7 +2602,6 @@ webkit.org/b/160367 media/track/track-remove-crash.html
> webkit.org/b/131476 media/track/w3c/track/webvtt
> 
> media/video-object-fit-change.html [ ImageOnlyFailure ]
>-media/video-object-fit.html [ ImageOnlyFailure ]
> 
> media/W3C/video/canPlayType/canPlayType_codecs_order_2.html [ Failure ]
> media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html [ Failure ]
>@@ -2645,7 +2642,6 @@ media/track/track-in-band-subtitles-too-large.html [ Failure ]
> media/track/track-long-word-container-sizing.html [ Failure ]
> media/track/track-manual-mode.html [ Failure ]
> media/track/w3c/interfaces/TextTrackCue/align.html [ Failure ]
>-media/video-autoplay-allowed-but-fullscreen-required.html [ Failure ]
> media/video-background-tab-playback.html [ Failure ]
> media/video-colorspace-yuv420.html [ Failure ]
> media/video-colorspace-yuv422.html [ Failure ]
>@@ -2667,8 +2663,6 @@ media/video-volume.html [ Failure ]
> 
> media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1.html [ Failure ]
> 
>-media/video-seek-to-current-time.html [ Failure ]
>-
> fast/attachment/attachment-wrapping-action.html [ Pass ]
> fast/attachment/attachment-borderless.html [ Pass ]
> fast/images/pdf-as-image-dest-rect-change.html [ Pass ]
>@@ -2836,8 +2830,6 @@ webkit.org/b/168239 [ Release ] fast/css/target-fragment-match.html [ Pass Failu
> webkit.org/b/173328 fast/text/system-font-fallback-emoji.html [ Failure ]
> webkit.org/b/173328 fast/text/system-font-fallback.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/173611 media/video-buffered.html [ Pass Failure ]
>-
> webkit.org/b/171617 perf/object-keys.html [ Pass Failure ]
> 
> # WebGL tests which need triaging https://bugs.webkit.org/b/174100
>@@ -2949,9 +2941,6 @@ fast/images/animated-image-different-dest-size.html [ ImageOnlyFailure ]
> # <rdar://problem/32659595> iOS 11: LayoutTest fast/text/international/system-language/arabic-glyph-cache-fill-combine.html is failing
> fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
> 
>-# <rdar://problem/32626498> REGRESSION (iOS 11/High Sierra): media/remote-control-command-seek.html is timing out
>-media/remote-control-command-seek.html [ Timeout ]
>-
> # <rdar://problem/32714935> iOS 11: LayoutTest security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html is timing out
> security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ Timeout ]
> 
>@@ -2959,9 +2948,6 @@ security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.htm
> http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html [ Timeout ]
> http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html [ Timeout ]
> 
>-# <rdar://problem/32715903> iOS 11: LayoutTest media/sources-fallback-codecs.html is failing
>-media/sources-fallback-codecs.html [ Failure ]
>-
> # <rdar://problem/32715902> iOS 11: LayoutTest media/video-src-blob-using-open-panel.html is failing
> media/video-src-blob-using-open-panel.html [ Failure ]
> 
>@@ -3071,7 +3057,6 @@ media/modern-media-controls/seek-backward-support [ Skip ]
> media/modern-media-controls/seek-forward-support [ Skip ]
> media/modern-media-controls/start-support/start-support-click-to-start.html [ Skip ]
> media/modern-media-controls/start-support/start-support-disable-controls-and-re-enable-post-play.html [ Skip ]
>-media/modern-media-controls/start-support/start-support-lowPowerMode.html [ Skip ]
> media/modern-media-controls/volume-down-support [ Skip ]
> media/modern-media-controls/volume-up-support [ Skip ]
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189665: 349890 | 349891 | 349906 | 351201 | 351203 | 351204 | 351205 | 351209 | 351221 | 351222 | 351223 | 351224 | 351258 | 351283