Attachment 349880 Details for Bug 189411 – Patch

[patch] Patch

bug-189411-20180917112213.patch (text/plain), 3.44 KB, created by Antoine Quint on 2018-09-17 02:22:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2018-09-17 02:22:14 PDT

Size: 3.44 KB

patch

obsolete

>Subversion Revision: 236034
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 6b753994e8df2581f7ab9957779a5171d16b5602..33f6e6f70159be10840c9e8ea544d3d1c87cd6d4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-17  Antoine Quint  <graouts@apple.com>
>+
>+        [Web Animations] Positive delays of accelerated animations are not respected
>+        https://bugs.webkit.org/show_bug.cgi?id=189411
>+        <rdar://problem/44151416>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use a mask over the animated rectangle to allow for a 1px rounding error when seeking to fix flakiness.
>+
>+        * webanimations/accelerated-animation-with-delay-and-seek-expected.html:
>+        * webanimations/accelerated-animation-with-delay-and-seek.html:
>+
> 2018-09-16  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed test gardening, mark fast/text/variations/ipc2.html as slow.
>diff --git a/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html b/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html
>index cf518fe98c60f1ce7682c1008665f2359c04b420..61dce5dede292411cd83adb63002c8b527f50705 100644
>--- a/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html
>+++ b/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html
>@@ -3,15 +3,32 @@
> <head>
> <style>
> div {
>+    left: 0;
>+    top: 0;
>     position: absolute;
>-    width: 100px;
>     height: 100px;
>-    transform: translateX(50px);
>+}
>+
>+.mask {
>+    /* We add an extra pixel to account for rounding errors */
>+    width: 51px;
>+    background-color: red;
>+}
>+
>+#target {
>+    width: 100px;
>     background-color: black;
>+    transform: translateX(50px);
>+}
>+
>+#right {
>+    left: 149px;
> }
> </style>
> </head>
> <body>
>-<div></div>
>+<div id="target"></div>
>+<div id="left" class="mask"></div>
>+<div id="right" class="mask"></div>
> </body>
> </html>
>diff --git a/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html b/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html
>index b5fd87a7af863ff731e6fd674ad0b20b8cf4e104..c314bfe96053e877eba89e1003d8180fa582f290 100644
>--- a/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html
>+++ b/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html
>@@ -4,29 +4,52 @@
> <style>
> 
> div {
>+    left: 0;
>+    top: 0;
>     position: absolute;
>-    width: 100px;
>     height: 100px;
>+}
>+
>+.mask {
>+    /* We add an extra pixel to account for rounding errors */
>+    width: 51px;
>+    background-color: red;
>+}
>+
>+#target {
>+    width: 100px;
>     background-color: black;
> }
> 
>+#right {
>+    left: 149px;
>+}
>+
> </style>
> </head>
> <body>
>+
>+<div id="target"></div>
>+<div id="left" class="mask"></div>
>+<div id="right" class="mask"></div>
>+
> <script>
> 
> if (window.testRunner)
>     testRunner.waitUntilDone();
> 
>-const animation = document.body.appendChild(document.createElement("div")).animate({
>+const animation = document.getElementById("target").animate({
>     transform: ["translateX(100px)", "none"]
> }, { duration: 10000, delay: 1000 });
> 
> requestAnimationFrame(() => {
>     animation.pause();
>     animation.currentTime = 6000;
>-    if (window.testRunner)
>-        requestAnimationFrame(() => testRunner.notifyDone());
>+    if (window.testRunner) {
>+        requestAnimationFrame(() => {
>+            requestAnimationFrame(() => testRunner.notifyDone())
>+        });
>+    }
> });
> 
> </script>

Flags:

dino: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189411: 349153 | 349306 | 349880