Attachment 349859 Details for Bug 189308 – Patch

[patch] Patch

189308.diff (text/plain), 1.61 KB, created by Devin Rousso on 2018-09-15 11:04:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-09-15 11:04:06 PDT

Size: 1.61 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 6a84f40e087..a4eee43a723 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-15  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: REGRESSION: breakpoint context menu appears twice in DOM tree
>+        https://bugs.webkit.org/show_bug.cgi?id=189308
>+
>+        Reviewed by Joseph Pecoraro.
>+
>+        * UserInterface/Controllers/DOMBreakpointTreeController.js:
>+        (WI.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
>+        Set a symbol on the `contextMenu` to ensure that the same items are not added twice.
>+
> 2018-09-13  Jamal Nasser  <jamaln@mail.com>
> 
>         Web Inspector: Dark Mode: bezier curve editor should be updated
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js b/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js
>index 9e8aba7a54c..0af27d46d05 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js
>@@ -46,6 +46,11 @@ WI.DOMBreakpointTreeController = class DOMBreakpointsTreeController extends WI.O
>     {
>         console.assert(WI.domDebuggerManager.supported);
> 
>+        if (contextMenu.__domBreakpointItemsAdded)
>+            return;
>+
>+        contextMenu.__domBreakpointItemsAdded = true;
>+
>         let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break onâ¦"));
> 
>         let breakpoints = WI.domDebuggerManager.domBreakpointsForNode(domNode);

Actions: View | Formatted Diff | Diff

Attachments on bug 189308: 348933 | 348934 | 349741 | 349859