WebKit Bugzilla
Attachment 349845 Details for
Bug 189643
: Re-order Node flags based on semantics
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Cleanup
bug-189643-20180914185212.patch (text/plain), 3.33 KB, created by
Ryosuke Niwa
on 2018-09-14 18:52:13 PDT
(
hide
)
Description:
Cleanup
Filename:
MIME Type:
Creator:
Ryosuke Niwa
Created:
2018-09-14 18:52:13 PDT
Size:
3.33 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 236030) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2018-09-14 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Re-order Node flags based on semantics >+ https://bugs.webkit.org/show_bug.cgi?id=189643 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Re-ordered Node flags based on their category and subclasses of Node which use them. >+ >+ * dom/Node.h: >+ > 2018-09-14 Basuke Suzuki <Basuke.Suzuki@sony.com> > > [Curl] Bug fix on some inaccurate values in NetworkLoadMetrics. >Index: Source/WebCore/dom/Node.h >=================================================================== >--- Source/WebCore/dom/Node.h (revision 236027) >+++ Source/WebCore/dom/Node.h (working copy) >@@ -559,39 +559,41 @@ protected: > IsHTMLFlag = 1 << 3, > IsSVGFlag = 1 << 4, > IsMathMLFlag = 1 << 5, >- IsConnectedFlag = 1 << 6, >- IsInShadowTreeFlag = 1 << 7, >- IsDocumentNodeFlag = 1 << 8, >- IsShadowRootFlag = 1 << 9, >+ IsDocumentNodeFlag = 1 << 6, >+ IsShadowRootFlag = 1 << 7, >+ IsConnectedFlag = 1 << 8, >+ IsInShadowTreeFlag = 1 << 9, > HasRareDataFlag = 1 << 10, > HasEventTargetDataFlag = 1 << 11, > > // These bits are used by derived classes, pulled up here so they can > // be stored in the same memory word as the Node bits above. > ChildNeedsStyleRecalcFlag = 1 << 12, // ContainerNode >+ DirectChildNeedsStyleRecalcFlag = 1 << 13, > >- IsParsingChildrenFinishedFlag = 1 << 13, // Element >- StyleValidityShift = 14, >+ IsEditingTextOrUndefinedCustomElementFlag = 1 << 14, // Text and Element >+ IsCustomElement = 1 << 15, // Element >+ HasFocusWithin = 1 << 16, >+ IsLinkFlag = 1 << 17, >+ IsUserActionElement = 1 << 18, >+ IsParsingChildrenFinishedFlag = 1 << 19, >+ HasSyntheticAttrChildNodesFlag = 1 << 20, >+ SelfOrAncestorHasDirAutoFlag = 1 << 21, >+ >+ // The following flags are used in style invalidation. >+ StyleValidityShift = 22, > StyleValidityMask = 3 << StyleValidityShift, >- StyleResolutionShouldRecompositeLayerFlag = 1 << 16, >- IsEditingTextOrUndefinedCustomElementFlag = 1 << 17, >- HasFocusWithin = 1 << 18, >- HasSyntheticAttrChildNodesFlag = 1 << 19, >- HasCustomStyleResolveCallbacksFlag = 1 << 20, >- DescendantsAffectedByPreviousSiblingFlag = 1 << 21, >- IsCustomElement = 1 << 22, >- IsLinkFlag = 1 << 23, >- IsUserActionElement = 1 << 24, >+ StyleResolutionShouldRecompositeLayerFlag = 1 << 24, > > ChildrenAffectedByFirstChildRulesFlag = 1 << 25, > ChildrenAffectedByLastChildRulesFlag = 1 << 26, > ChildrenAffectedByHoverRulesFlag = 1 << 27, > >- DirectChildNeedsStyleRecalcFlag = 1 << 28, >- AffectsNextSiblingElementStyle = 1 << 29, >- StyleIsAffectedByPreviousSibling = 1 << 30, >+ AffectsNextSiblingElementStyle = 1 << 28, >+ StyleIsAffectedByPreviousSibling = 1 << 29, >+ DescendantsAffectedByPreviousSiblingFlag = 1 << 30, > >- SelfOrAncestorHasDirAutoFlag = 1 << 31, >+ HasCustomStyleResolveCallbacksFlag = 1 << 31, > > DefaultNodeFlags = IsParsingChildrenFinishedFlag > };
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
simon.fraser
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189643
: 349845