Attachment 349813 Details for Bug 189610 – Patch

[patch] Patch

bug-189610-20180914150518.patch (text/plain), 19.29 KB, created by Justin Fan on 2018-09-14 15:05:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2018-09-14 15:05:19 PDT

Size: 19.29 KB

patch

obsolete

>Subversion Revision: 235963
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f024f6b73f371ab33db786c71111c6a47a774f40..dd2ff8a9ef0042c9ff33aaba58062411d2e87ca0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,28 @@
>+2018-09-13  Justin Fan  <justin_fan@apple.com>
>+
>+        WebGL 2 conformance: rgb-format-support.html
>+        https://bugs.webkit.org/show_bug.cgi?id=189610
>+        <rdar://problem/44403343>
>+
>+        Reviewed by Dean Jackson.
>+
>+        Implementing getInternalformatParameter (emulating on macOS) and updating 
>+        renderbufferStorage{Multisample} for WebGL 2 conformance. 
>+
>+        Test: webgl/2.0.0/conformance2/rendering/rgb-format-support.html enabled.
>+
>+        * html/canvas/WebGL2RenderingContext.cpp:
>+        (WebCore::isRenderableInternalformat):
>+        (WebCore::WebGL2RenderingContext::getInternalformatParameter):
>+        (WebCore::WebGL2RenderingContext::renderbufferStorageMultisample):
>+        (WebCore::WebGL2RenderingContext::renderbufferStorage):
>+        (WebCore::WebGL2RenderingContext::baseInternalFormatFromInternalFormat):
>+        (WebCore::WebGL2RenderingContext::isIntegerFormat):
>+        * platform/graphics/GraphicsContext3D.h:
>+        * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
>+        (WebCore::GraphicsContext3D::getInternalformativ):
>+        (WebCore::GraphicsContext3D::renderbufferStorageMultisample):
>+
> 2018-09-11  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html hits assertion
>diff --git a/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp b/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
>index 12fcfdad445c976238cfd87aad69005aacdc352b..3523477ebe52a2fefe1e7cd255e247f341f9a094 100644
>--- a/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
>+++ b/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
>@@ -316,9 +316,100 @@ void WebGL2RenderingContext::framebufferTextureLayer(GC3Denum, GC3Denum, WebGLTe
> {
> }
> 
>-WebGLAny WebGL2RenderingContext::getInternalformatParameter(GC3Denum, GC3Denum, GC3Denum)
>+#if !USE(OPENGL_ES)
>+static bool isRenderableInternalformat(GC3Denum internalformat)
> {
>-    return nullptr;
>+    // OpenGL ES 3: internalformat must be a color-renderable, depth-renderable, or stencil-renderable format, as shown in Table 1 below.
>+    switch (internalformat) {
>+    case GraphicsContext3D::R8:
>+    case GraphicsContext3D::R8UI:
>+    case GraphicsContext3D::R16UI:
>+    case GraphicsContext3D::R16I:
>+    case GraphicsContext3D::R32UI:
>+    case GraphicsContext3D::R32I:
>+    case GraphicsContext3D::RG8:
>+    case GraphicsContext3D::RG8UI:
>+    case GraphicsContext3D::RG8I:
>+    case GraphicsContext3D::RG16UI:
>+    case GraphicsContext3D::RG16I:
>+    case GraphicsContext3D::RG32UI:
>+    case GraphicsContext3D::RG32I:
>+    case GraphicsContext3D::RGB8:
>+    case GraphicsContext3D::RGB565:
>+    case GraphicsContext3D::RGBA8:
>+    case GraphicsContext3D::SRGB8_ALPHA8:
>+    case GraphicsContext3D::RGB5_A1:
>+    case GraphicsContext3D::RGBA4:
>+    case GraphicsContext3D::RGB10_A2:
>+    case GraphicsContext3D::RGBA8UI:
>+    case GraphicsContext3D::RGBA8I:
>+    case GraphicsContext3D::RGB10_A2UI:
>+    case GraphicsContext3D::RGBA16UI:
>+    case GraphicsContext3D::RGBA16I:
>+    case GraphicsContext3D::RGBA32I:
>+    case GraphicsContext3D::RGBA32UI:
>+    case GraphicsContext3D::DEPTH_COMPONENT16:
>+    case GraphicsContext3D::DEPTH_COMPONENT24:
>+    case GraphicsContext3D::DEPTH_COMPONENT32F:
>+    case GraphicsContext3D::DEPTH24_STENCIL8:
>+    case GraphicsContext3D::DEPTH32F_STENCIL8:
>+    case GraphicsContext3D::STENCIL_INDEX8:
>+        return true;
>+    }
>+    return false;
>+}
>+#endif
>+
>+WebGLAny WebGL2RenderingContext::getInternalformatParameter(GC3Denum target, GC3Denum internalformat, GC3Denum pname)
>+{
>+    if (isContextLostOrPending())
>+        return nullptr;
>+
>+    if (pname != GraphicsContext3D::SAMPLES) {
>+        synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "getInternalformatParameter", "invalid parameter name");
>+        return nullptr;
>+    }
>+
>+    int numValues = 0;
>+#if USE(OPENGL_ES)
>+    m_context->getInternalformativ(target, internalformat, GraphicsContext3D::NUM_SAMPLE_COUNTS, 1, &numValues);
>+
>+    GC3Dint params[numValues];
>+    m_context->getInternalformativ(target, internalformat, pname, numValues, params);
>+#else
>+    // On desktop OpenGL 4.1 or below we must emulate glGetInternalformativ.
>+
>+    // GL_INVALID_ENUM is generated if target is not GL_RENDERBUFFER.
>+    if (target != GraphicsContext3D::RENDERBUFFER) {
>+        synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "getInternalformatParameter", "invalid target");
>+        return nullptr;
>+    }
>+
>+    // GL_INVALID_ENUM is generated if internalformat is not color-, depth-, or stencil-renderable.
>+    if (!isRenderableInternalformat(internalformat)) {
>+        synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "getInternalformatParameter", "invalid internal format");
>+        return nullptr;
>+    }
>+
>+    Vector<GC3Dint> samples;
>+    // The way I understand this is that this will return a MINIMUM numSamples for all accepeted internalformats.
>+    // However, the true value of this on supported GL versions is gleaned via a getInternalformativ call that depends on internalformat.
>+    int numSamplesMask = getIntParameter(GraphicsContext3D::MAX_SAMPLES);
>+
>+    while (numSamplesMask > 0) {
>+        samples.append(numSamplesMask);
>+        numSamplesMask = numSamplesMask >> 1;
>+    }
>+
>+    // Since multisampling is not supported for signed and unsigned integer internal formats,
>+    // the value of GL_NUM_SAMPLE_COUNTS will be zero for such formats.
>+    numValues = isIntegerFormat(internalformat) ? 0 : samples.size();
>+    GC3Dint params[numValues];
>+    for (size_t i = 0; i < samples.size(); ++i)
>+        params[i] = samples[i];
>+#endif
>+
>+    return Int32Array::create(params, numValues);
> }
> 
> void WebGL2RenderingContext::invalidateFramebuffer(GC3Denum, const Vector<GC3Denum>&)
>@@ -333,8 +424,73 @@ void WebGL2RenderingContext::readBuffer(GC3Denum)
> {
> }
> 
>-void WebGL2RenderingContext::renderbufferStorageMultisample(GC3Denum, GC3Dsizei, GC3Denum, GC3Dsizei, GC3Dsizei)
>+void WebGL2RenderingContext::renderbufferStorageMultisample(GC3Denum target, GC3Dsizei samples, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height)
> {
>+    // To be backward compatible with WebGL 1, also accepts internal format DEPTH_STENCIL,
>+    // which should be mapped to DEPTH24_STENCIL8 by implementations.
>+    if (internalformat == GraphicsContext3D::DEPTH_STENCIL)
>+        internalformat = GraphicsContext3D::DEPTH24_STENCIL8;
>+
>+    // ES 3: GL_INVALID_OPERATION is generated if internalformat is a signed or unsigned integer format and samples is greater than 0.
>+    if (isIntegerFormat(internalformat) && samples > 0) {
>+        synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "renderbufferStorageMultisample", "multisampling not supported for this format");
>+        return;
>+    }
>+
>+    switch (internalformat) {
>+    case GraphicsContext3D::DEPTH_COMPONENT16:
>+    case GraphicsContext3D::DEPTH_COMPONENT32F:
>+    case GraphicsContext3D::DEPTH_COMPONENT24:
>+    case GraphicsContext3D::RGBA32I:
>+    case GraphicsContext3D::RGBA32UI:
>+    case GraphicsContext3D::RGBA16I:
>+    case GraphicsContext3D::RGBA16UI:
>+    case GraphicsContext3D::RGBA8:
>+    case GraphicsContext3D::RGBA8I:
>+    case GraphicsContext3D::RGBA8UI:
>+    case GraphicsContext3D::RGB10_A2:
>+    case GraphicsContext3D::RGB10_A2UI:
>+    case GraphicsContext3D::RGBA4:
>+    case GraphicsContext3D::RG32I:
>+    case GraphicsContext3D::RG32UI:
>+    case GraphicsContext3D::RG16I:
>+    case GraphicsContext3D::RG16UI:
>+    case GraphicsContext3D::RG8:
>+    case GraphicsContext3D::RG8I:
>+    case GraphicsContext3D::RG8UI:
>+    case GraphicsContext3D::R32I:
>+    case GraphicsContext3D::R32UI:
>+    case GraphicsContext3D::R16I:
>+    case GraphicsContext3D::R16UI:
>+    case GraphicsContext3D::R8:
>+    case GraphicsContext3D::R8I:
>+    case GraphicsContext3D::R8UI:
>+    case GraphicsContext3D::RGB5_A1:
>+    case GraphicsContext3D::RGB565:
>+    case GraphicsContext3D::RGB8:
>+    case GraphicsContext3D::STENCIL_INDEX8:
>+    case GraphicsContext3D::SRGB8_ALPHA8:
>+        m_context->renderbufferStorageMultisample(target, samples, internalformat, width, height);
>+        m_renderbufferBinding->setInternalFormat(internalformat);
>+        m_renderbufferBinding->setIsValid(true);
>+        m_renderbufferBinding->setSize(width, height);
>+        break;
>+    case GraphicsContext3D::DEPTH32F_STENCIL8:
>+    case GraphicsContext3D::DEPTH24_STENCIL8:
>+        if (!isDepthStencilSupported()) {
>+            synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "renderbufferStorage", "invalid internalformat");
>+            return;
>+        }
>+        m_context->renderbufferStorageMultisample(target, samples, internalformat, width, height);
>+        m_renderbufferBinding->setSize(width, height);
>+        m_renderbufferBinding->setIsValid(isDepthStencilSupported());
>+        m_renderbufferBinding->setInternalFormat(internalformat);
>+        break;
>+    default:
>+        synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "renderbufferStorage", "invalid internalformat");
>+        return;
>+    }
>+    applyStencilTest();
> }
> 
> bool WebGL2RenderingContext::validateTexStorageFuncParameters(GC3Denum target, GC3Dsizei levels, GC3Denum internalFormat, GC3Dsizei width, GC3Dsizei height, const char* functionName)
>@@ -1371,6 +1527,7 @@ void WebGL2RenderingContext::renderbufferStorage(GC3Denum target, GC3Denum inter
>     case GraphicsContext3D::R8UI:
>     case GraphicsContext3D::RGB5_A1:
>     case GraphicsContext3D::RGB565:
>+    case GraphicsContext3D::RGB8:
>     case GraphicsContext3D::STENCIL_INDEX8:
>     case GraphicsContext3D::SRGB8_ALPHA8:
>         m_context->renderbufferStorage(target, internalformat, width, height);
>@@ -1422,65 +1579,69 @@ GC3Denum WebGL2RenderingContext::baseInternalFormatFromInternalFormat(GC3Denum i
>     case GraphicsContext3D::R8_SNORM:
>     case GraphicsContext3D::R16F:
>     case GraphicsContext3D::R32F:
>+    case GraphicsContext3D::COMPRESSED_R11_EAC:
>+    case GraphicsContext3D::COMPRESSED_SIGNED_R11_EAC:
>+        return GraphicsContext3D::RED;
>     case GraphicsContext3D::R8I:
>     case GraphicsContext3D::R8UI:
>     case GraphicsContext3D::R16I:
>     case GraphicsContext3D::R16UI:
>     case GraphicsContext3D::R32I:
>     case GraphicsContext3D::R32UI:
>-    case GraphicsContext3D::COMPRESSED_R11_EAC:
>-    case GraphicsContext3D::COMPRESSED_SIGNED_R11_EAC:
>-        return GraphicsContext3D::RED;
>+        return GraphicsContext3D::RED_INTEGER;
>     case GraphicsContext3D::RG8:
>     case GraphicsContext3D::RG8_SNORM:
>     case GraphicsContext3D::RG16F:
>     case GraphicsContext3D::RG32F:
>+    case GraphicsContext3D::COMPRESSED_RG11_EAC:
>+    case GraphicsContext3D::COMPRESSED_SIGNED_RG11_EAC:
>+        return GraphicsContext3D::RG;
>     case GraphicsContext3D::RG8I:
>     case GraphicsContext3D::RG8UI:
>     case GraphicsContext3D::RG16I:
>     case GraphicsContext3D::RG16UI:
>     case GraphicsContext3D::RG32I:
>     case GraphicsContext3D::RG32UI:
>-    case GraphicsContext3D::COMPRESSED_RG11_EAC:
>-    case GraphicsContext3D::COMPRESSED_SIGNED_RG11_EAC:
>-        return GraphicsContext3D::RG;
>+        return GraphicsContext3D::RG_INTEGER;
>     case GraphicsContext3D::RGB8:
>     case GraphicsContext3D::RGB8_SNORM:
>     case GraphicsContext3D::RGB565:
>     case GraphicsContext3D::SRGB8:
>     case GraphicsContext3D::RGB16F:
>     case GraphicsContext3D::RGB32F:
>+    case GraphicsContext3D::RGB:
>+    case GraphicsContext3D::COMPRESSED_RGB8_ETC2:
>+    case GraphicsContext3D::COMPRESSED_SRGB8_ETC2:
>+        return GraphicsContext3D::RGB;
>     case GraphicsContext3D::RGB8I:
>     case GraphicsContext3D::RGB8UI:
>     case GraphicsContext3D::RGB16I:
>     case GraphicsContext3D::RGB16UI:
>     case GraphicsContext3D::RGB32I:
>     case GraphicsContext3D::RGB32UI:
>-    case GraphicsContext3D::RGB:
>-    case GraphicsContext3D::COMPRESSED_RGB8_ETC2:
>-    case GraphicsContext3D::COMPRESSED_SRGB8_ETC2:
>-        return GraphicsContext3D::RGB;
>+        return GraphicsContext3D::RGB_INTEGER;
>     case GraphicsContext3D::RGBA4:
>     case GraphicsContext3D::RGB5_A1:
>     case GraphicsContext3D::RGBA8:
>     case GraphicsContext3D::RGBA8_SNORM:
>     case GraphicsContext3D::RGB10_A2:
>-    case GraphicsContext3D::RGB10_A2UI:
>     case GraphicsContext3D::SRGB8_ALPHA8:
>     case GraphicsContext3D::RGBA16F:
>     case GraphicsContext3D::RGBA32F:
>-    case GraphicsContext3D::RGBA8I:
>-    case GraphicsContext3D::RGBA8UI:
>-    case GraphicsContext3D::RGBA16I:
>-    case GraphicsContext3D::RGBA16UI:
>-    case GraphicsContext3D::RGBA32I:
>-    case GraphicsContext3D::RGBA32UI:
>     case GraphicsContext3D::RGBA:
>     case GraphicsContext3D::COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2:
>     case GraphicsContext3D::COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2:
>     case GraphicsContext3D::COMPRESSED_RGBA8_ETC2_EAC:
>     case GraphicsContext3D::COMPRESSED_SRGB8_ALPHA8_ETC2_EAC:
>         return GraphicsContext3D::RGBA;
>+    case GraphicsContext3D::RGBA8I:
>+    case GraphicsContext3D::RGBA8UI:
>+    case GraphicsContext3D::RGB10_A2UI:
>+    case GraphicsContext3D::RGBA16I:
>+    case GraphicsContext3D::RGBA16UI:
>+    case GraphicsContext3D::RGBA32I:
>+    case GraphicsContext3D::RGBA32UI:
>+        return GraphicsContext3D::RGBA_INTEGER;
>     case GraphicsContext3D::DEPTH_COMPONENT16:
>     case GraphicsContext3D::DEPTH_COMPONENT24:
>     case GraphicsContext3D::DEPTH_COMPONENT32F:
>@@ -1500,8 +1661,6 @@ GC3Denum WebGL2RenderingContext::baseInternalFormatFromInternalFormat(GC3Denum i
> 
> bool WebGL2RenderingContext::isIntegerFormat(GC3Denum internalformat)
> {
>-    // FIXME: baseInternalFormatFromInternalFormat() never returns any of these enums.
>-    // Because of that, this function erroneously always returns false!
>     switch (baseInternalFormatFromInternalFormat(internalformat)) {
>     case GraphicsContext3D::RED_INTEGER:
>     case GraphicsContext3D::RG_INTEGER:
>diff --git a/Source/WebCore/platform/graphics/GraphicsContext3D.h b/Source/WebCore/platform/graphics/GraphicsContext3D.h
>index b5f9bb7ccf9624428a9c27ae180e45513269cb8e..c9ea1dfbfcecbf672c2e82be3944a8a78020789d 100644
>--- a/Source/WebCore/platform/graphics/GraphicsContext3D.h
>+++ b/Source/WebCore/platform/graphics/GraphicsContext3D.h
>@@ -981,6 +981,9 @@ public:
>     GC3Dboolean unmapBuffer(GC3Denum target);
>     void copyBufferSubData(GC3Denum readTarget, GC3Denum writeTarget, GC3Dintptr readOffset, GC3Dintptr writeOffset, GC3Dsizeiptr);
> 
>+    void getInternalformativ(GC3Denum target, GC3Denum internalformat, GC3Denum pname, GC3Dsizei bufSize, GC3Dint* params);
>+    void renderbufferStorageMultisample(GC3Denum target, GC3Dsizei samples, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height);
>+
>     void texStorage2D(GC3Denum target, GC3Dsizei levels, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height);
>     void texStorage3D(GC3Denum target, GC3Dsizei levels, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth);
> 
>diff --git a/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp b/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>index cf363b62abb4762e3264132ee2fac3fbfc6c85b6..6c9c3f7f0c02664e151135c8b44ee8d6a92299fa 100644
>--- a/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>+++ b/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>@@ -570,6 +570,26 @@ void GraphicsContext3D::copyBufferSubData(GC3Denum readTarget, GC3Denum writeTar
>     ::glCopyBufferSubData(readTarget, writeTarget, readOffset, writeOffset, size);
> }
> 
>+void GraphicsContext3D::getInternalformativ(GC3Denum target, GC3Denum internalformat, GC3Denum pname, GC3Dsizei bufSize, GC3Dint* params)
>+{
>+#if USE(OPENGL_ES)
>+    makeContextCurrent();
>+    ::glGetInternalformativ(target, internalformat, pname, bufSize, params);
>+#else
>+    UNUSED_PARAM(target);
>+    UNUSED_PARAM(internalformat);
>+    UNUSED_PARAM(pname);
>+    UNUSED_PARAM(bufSize);
>+    UNUSED_PARAM(params);
>+#endif
>+}
>+
>+void GraphicsContext3D::renderbufferStorageMultisample(GC3Denum target, GC3Dsizei samples, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height)
>+{
>+    makeContextCurrent();
>+    ::glRenderbufferStorageMultisample(target, samples, internalformat, width, height);
>+}
>+
> void GraphicsContext3D::texStorage2D(GC3Denum target, GC3Dsizei levels, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height)
> {
>     makeContextCurrent();
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8ef8f32c90a782b995ccde544a7519d2ac314c9a..fe785cd5a1956a5317b77ca1d5c4ae060132b123 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-09-13  Justin Fan  <justin_fan@apple.com>
>+
>+        WebGL 2 conformance: rgb-format-support.html
>+        https://bugs.webkit.org/show_bug.cgi?id=189610
>+        <rdar://problem/44403343>
>+
>+        Reviewed by Dean Jackson.
>+
>+        Enabled rgb-format-support.html, and updated expectation for gl-teximage.html.
>+
>+        * TestExpectations:
>+        * platform/mac/TestExpectations:
>+        * webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt:
>+
> 2018-09-12  Dean Jackson  <dino@grorg.org>
> 
>         Header parsing for experimental and internal debug features
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 810a898cac80c7a90756d9b2ffc72d8cf90aff1f..a6fba9d4ec498ec0efa31f6c889849f6a6eb90b1 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -2071,6 +2071,7 @@ webgl/2.0.0 [ Skip ]
> webgl/2.0.0/conformance2/glsl3 [ Pass ]
> webgl/2.0.0/conformance2/vertex_arrays [ Pass ]
> webgl/2.0.0/conformance2/renderbuffers/framebuffer-test.html [ Pass ]
>+webgl/2.0.0/conformance2/rendering/rgb-format-support.html [ Pass ]
> 
> imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-table-row-001.xht [ ImageOnlyFailure ]
> imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-style-008.html [ ImageOnlyFailure ]
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 52af06c224e68ea8d7e841c91227b323c2c57d86..2a35beee0b8f0b979a86cbb937e9f1026aeb8f0a 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1127,7 +1127,6 @@ webkit.org/b/168953 [ Release ] compositing/video/video-poster.html [ Pass Failu
> webkit.org/b/148435 storage/domstorage/events/basic-body-attribute.html [ Pass Failure ]
> 
> webkit.org/b/149930 fast/canvas/webgl/oes-texture-float-linear.html [ Pass Failure ]
>-webkit.org/b/58766 fast/canvas/webgl/gl-teximage.html [ Pass Failure ]
> 
> # Imported Blink tests which have not been investigated.
> imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt
>index a1dcde1e9773ed38a2e099be76c2fd81a0a245fd..104c1ca25c6e53fd86a861295beeb1786b5dc7b3 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/rendering/rgb-format-support.html
>-PASS
>+[ PASS ] All tests passed
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189610: 349726 | 349727 | 349813