Attachment 349775 Details for Bug 189623 – Patch

[patch] Patch

bug-189623-20180914105203.patch (text/plain), 1.57 KB, created by Ryan Haddad on 2018-09-14 10:52:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan Haddad

Created: 2018-09-14 10:52:03 PDT

Size: 1.57 KB

patch

obsolete

>Subversion Revision: 235980
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 076c830ca61be30339b1cf5d2f484b1cd0d5ae97..c58ed47fa7d14c6c4887c0ff15a29ba03a366f53 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
>+
>+        bots should pass --clobber-old-results to run-webkit-tests
>+        https://bugs.webkit.org/show_bug.cgi?id=189623
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In order to ensure that bots to not produce confusing results due to transient execptions,
>+        or run out of space if they continually hit an exception, old layout test results should be clobbered.
>+
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
>+        (RunWebKitTests):
>+
> 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Fix WebDriver tests after r235225.
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>index 54bb1f0280748b1b55ccf57479fb41e5ebf746c2..3e4a9466411805968430743d85527d5eda86563d 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>@@ -390,6 +390,7 @@ class RunWebKitTests(shell.Test):
>                "--no-build",
>                "--no-show-results",
>                "--no-new-test-results",
>+               "--clobber-old-results",
>                "--builder-name", WithProperties("%(buildername)s"),
>                "--build-number", WithProperties("%(buildnumber)s"),
>                "--master-name", "webkit.org",

Actions: View | Formatted Diff | Diff

Attachments on bug 189623: 349775