Attachment 349759 Details for Bug 189619 – Patch

[patch] Patch

bug-189619-20180914165132.patch (text/plain), 1.96 KB, created by Xabier Rodríguez Calvar on 2018-09-14 07:51:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Xabier Rodríguez Calvar

Created: 2018-09-14 07:51:34 PDT

Size: 1.96 KB

patch

obsolete

>Subversion Revision: 235971
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 88320c4bcbd18747d145ec17242163c27b11a2b3..fd1a52d7a47dcef0ee7d0fa8ea7c60dccbe9edc9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-09-14  Xabier Rodriguez Calvar  <calvaris@igalia.com>
>+
>+        [EME] Queue a "message" Event algorithm should enqueue a task
>+        https://bugs.webkit.org/show_bug.cgi?id=189619
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The spec says we should queue a task and we weren't doing it.
>+
>+        Test: imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html
>+
>+        * Modules/encryptedmedia/MediaKeySession.cpp:
>+        (WebCore::MediaKeySession::enqueueMessage):
>+
> 2018-09-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
> 
>         [GStreamer][EME] decrypt-key-needed message renamed to drm-cdm-instance-needed
>diff --git a/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp b/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
>index eb72ce0778e81cbbcfbeba434c7828dd9a1152a4..7c16e3b829066fba72c9a400d3960bb74ffae103 100644
>--- a/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
>+++ b/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
>@@ -596,7 +596,9 @@ void MediaKeySession::enqueueMessage(MediaKeyMessageType messageType, const Shar
>     //    interface with its type attribute set to message and its isTrusted attribute initialized to true, and dispatch it at the
>     //    session.
>     auto messageEvent = MediaKeyMessageEvent::create(eventNames().messageEvent, {messageType, message.tryCreateArrayBuffer()}, Event::IsTrusted::Yes);
>-    m_eventQueue.enqueueEvent(WTFMove(messageEvent));
>+    m_taskQueue.enqueueTask([this, messageEvent = WTFMove(messageEvent)] () mutable {
>+        m_eventQueue.enqueueEvent(WTFMove(messageEvent));
>+    });
> }
> 
> void MediaKeySession::updateKeyStatuses(CDMInstanceClient::KeyStatusVector&& inputStatuses)

Actions: View | Formatted Diff | Diff

Attachments on bug 189619: 349759 | 350012 | 350209 | 350347