Attachment 349743 Details for Bug 187545 – Patch

[patch] Patch

bug-187545-20180914001253.patch (text/plain), 3.42 KB, created by Sihui Liu on 2018-09-14 00:12:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-09-14 00:12:54 PDT

Size: 3.42 KB

patch

obsolete

>Subversion Revision: 235862
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c03842c1747f1c0b643161b689337847b8c72cd9..4d04bb925e7a21bf0cfc1e3cd2d2e87cec9d2e3a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-09-14  Sihui Liu  <sihui_liu@apple.com>
>+
>+        JavaScript mouseover events triggered when app is in background
>+        https://bugs.webkit.org/show_bug.cgi?id=187545
>+        <rdar://problem/42401575>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should only update the scrollbar for for mouse event if the window is not active.
>+
>+        Test: fast/events/inactive_window_no_mouse_event.html
>+
>+        * page/EventHandler.cpp:
>+        (WebCore::EventHandler::handleMouseMoveEvent):
>+
> 2018-09-10  Simon Fraser  <simon.fraser@apple.com>
> 
>         svg/W3C-SVG-1.1/render-groups-03-t.svg and some other SVG tests leak documents
>diff --git a/Source/WebCore/page/EventHandler.cpp b/Source/WebCore/page/EventHandler.cpp
>index 36504769757ba13922ba6c8ef9f8f89e3f086adf..952439d805931d678071235054bcba40d73414d5 100644
>--- a/Source/WebCore/page/EventHandler.cpp
>+++ b/Source/WebCore/page/EventHandler.cpp
>@@ -1964,7 +1964,9 @@ bool EventHandler::handleMouseMoveEvent(const PlatformMouseEvent& platformMouseE
>             scrollbar->mouseMoved(platformMouseEvent); // Handle hover effects on platforms that support visual feedback on scrollbar hovering.
> #endif
>         if (onlyUpdateScrollbars) {
>+#if PLATFORM(GTK)
>             updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);
>+#endif
>             return true;
>         }
>     }
>diff --git a/LayoutTests/fast/events/inactive_window_no_mouse_event-expected.txt b/LayoutTests/fast/events/inactive_window_no_mouse_event-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..d74c190c9658018e5a8e8bc89ca9820e998d479c
>--- /dev/null
>+++ b/LayoutTests/fast/events/inactive_window_no_mouse_event-expected.txt
>@@ -0,0 +1,8 @@
>+layer at (0,0) size 800x600
>+  RenderView at (0,0) size 800x600
>+layer at (0,0) size 800x13
>+  RenderBlock {HTML} at (0,0) size 800x13
>+    RenderBody {BODY} at (8,13) size 784x0
>+      RenderBlock {PRE} at (0,0) size 784x0
>+layer at (100,100) size 100x100
>+  RenderBlock (positioned) {DIV} at (100,100) size 100x100
>diff --git a/LayoutTests/fast/events/inactive_window_no_mouse_event.html b/LayoutTests/fast/events/inactive_window_no_mouse_event.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..b1b9497ed525f9412195c127b0c1c6042be8bd2f
>--- /dev/null
>+++ b/LayoutTests/fast/events/inactive_window_no_mouse_event.html
>@@ -0,0 +1,27 @@
>+<!DOCTYPE html>
>+<head>
>+<script>
>+function log(message) {
>+    document.getElementById('console').innerHTML += (message + "\n");
>+}
>+
>+document.addEventListener("DOMContentLoaded", function(event) {
>+	var target = document.getElementById("target");
>+	target.addEventListener('mouseenter',() => log("Mouse enters target."));
>+	target.addEventListener('mouseleave',() => log("Mouse leaves target."));
>+	document.body.addEventListener('mousemove',() => log("Mouse moves."));
>+
>+	window.internals.setPageIsFocusedAndActive(false);
>+
>+	eventSender.mouseMoveTo(1, 1);
>+	eventSender.mouseMoveTo(150, 150);
>+	eventSender.mouseMoveTo(1, 1);
>+});
>+</script>
>+</head>
>+
>+<body id=body>
>+<div id="target" style="width:100px; height:100px; top:100px; left:100px; background-color:red; position:absolute">
>+</div>
>+<pre id="console"></pre>
>+</body>

Actions: View | Formatted Diff | Diff

Attachments on bug 187545: 349690 | 349743 | 349748 | 349750 | 349752 | 349753 | 349754 | 349762 | 349765 | 349768 | 349770 | 349774 | 349786 | 349788 | 349789 | 349790 | 349805 | 349824 | 349825 | 349836 | 349876 | 349878 | 349936 | 349993 | 350266