Attachment 349721 Details for Bug 189609 – Patch

[patch] Patch

bug-189609-20180913183012.patch (text/plain), 1.64 KB, created by Justin Fan on 2018-09-13 18:30:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2018-09-13 18:30:13 PDT

Size: 1.64 KB

patch

obsolete

>Subversion Revision: 235961
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index a07ba0f863d63f1c48411461369f83afd618f46c..2c8a040a1fecb89888422a53176d85e68079b141 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-13  Justin Fan  <justin_fan@apple.com>
>+
>+        Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance tests part 4
>+        https://bugs.webkit.org/show_bug.cgi?id=189609
>+
>+        Unreviewed small change for only the few webgl 2 tests' harness; completely passing 
>+        tests now only report the PASS line, to avoid discrepancies between e.g. feature ability 
>+        of different graphics cards causing diffs to fail.
>+
>+        * webgl/2.0.0/resources/webkit-webgl-test-harness.js:
>+        (window.webglTestHarness.notifyFinished):
>+
> 2018-09-12  Dean Jackson  <dino@apple.com>
> 
>         Header parsing for experimental and internal debug features
>diff --git a/LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js b/LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js
>index 0bd37641a415d8e7b2cefffa46114df69aa43ced..464d36b73aff1d3114629bd8ac40e79c039e9989 100644
>--- a/LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js
>+++ b/LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js
>@@ -64,8 +64,9 @@
>       if (numFailures > 0) {
>         log(`[ FAIL ] ${numFailures} failures reported`, "red");
>       } else {
>-        log("[ PASS ] All tests passed", "green");
>+        resultsList.innerHTML = "";
>         iframe.innerHTML = "";
>+        log("[ PASS ] All tests passed", "green");
>       }
> 
>       if (window.layoutTestController) {

Flags:

justin_fan: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189609: 349721 | 349722