Attachment 349716 Details for Bug 189566 – Patch for landing

[patch] Patch for landing

bug-189566-20180913165915.patch (text/plain), 16.11 KB, created by Megan Gardner on 2018-09-13 16:59:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-09-13 16:59:16 PDT

Size: 16.11 KB

patch

obsolete

>Subversion Revision: 235953
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index beb481d6997022d028b89f3f79bcc63b947d1bb6..dbf149b3575a35cc8d864cd0bca65093c880adb9 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,27 @@
>+2018-09-12  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Additional tests for conic gradients
>+        https://bugs.webkit.org/show_bug.cgi?id=189566
>+
>+        Reviewed by Simon Fraser.
>+
>+        Adding tests that actually test the gradient nature of gradients.
>+        This is done by using an svg filter to consolidate the sections
>+        of the gradient to sections we can actuall test the color of. Also,
>+        the seams are clipped out, to reduce noise. Since gradients are 
>+        highly noise prone, this is the best way to check and make sure
>+        that gradients are functional without sevear noise issues.
>+
>+        * TestExpectations:
>+        * fast/gradients/conic-gradient-alpha-expected.html: Added.
>+        * fast/gradients/conic-gradient-alpha.html: Added.
>+        * fast/gradients/conic-gradient-expected.html: Added.
>+        * fast/gradients/conic-gradient-extended-stops-expected.html: Added.
>+        * fast/gradients/conic-gradient-extended-stops.html: Added.
>+        * fast/gradients/conic-gradient.html: Added.
>+        * platform/ios-12/TestExpectations:
>+        * platform/mac/TestExpectations:
>+
> 2018-09-11  Dean Jackson  <dino@apple.com>
> 
>         Header parsing for experimental and internal debug features
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 4196cfe2b4d0d547803762e3722dc4869d5dc17c..f50cf4bad1e00903dfc689c23d13e0efec8941be 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -2245,5 +2245,8 @@ fast/gradients/conic-off-center.html [ Skip ]
> fast/gradients/conic-center-outside-box.html [ Skip ]
> fast/gradients/conic-extended-stops.html [ Skip ]
> fast/gradients/conic-from-angle.html [ Skip ]
>+fast/gradients/conic-gradient-alpha.html [ Skip ]
>+fast/gradients/conic-gradient-extended-stops.html [ Skip ]
>+fast/gradients/conic-gradient.html [ Skip ]
> 
> webkit.org/b/187773 http/tests/webAPIStatistics [ Skip ]
>diff --git a/LayoutTests/fast/gradients/conic-gradient-alpha-expected.html b/LayoutTests/fast/gradients/conic-gradient-alpha-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..53aef34ed8686310a6d0686f02a1bcdd816ba1ba
>--- /dev/null
>+++ b/LayoutTests/fast/gradients/conic-gradient-alpha-expected.html
>@@ -0,0 +1,67 @@
>+<html>
>+<head>
>+    <style>
>+        div {
>+            width: 200px;
>+            height: 200px;
>+            float: left;
>+        }
>+        /*tweak this until it's actually right... */
>+        #topleft {
>+            width: 0; 
>+            height: 0; 
>+            border-left: 100px solid rgb(64,87,64);
>+            border-top: 100px solid rgb(32,32,32);
>+        }
>+        #topright {
>+            width: 0; 
>+            height: 0; 
>+            border-right: 100px solid rgb(225,246,225);
>+            border-top: 100px solid rgb(254,254,254);
>+        }
>+        #bottomleft {
>+            clear: left;
>+            width: 0; 
>+            height: 0; 
>+            border-left: 100px solid rgb(96,135,96);
>+            border-bottom: 100px solid rgb(128,175,128);
>+        }
>+        #bottomright {
>+            width: 0; 
>+            height: 0; 
>+            border-right: 100px solid rgb(193,231,193);
>+            border-bottom: 100px solid rgb(160,207,160);
>+        }
>+        .box {
>+            position: absolute;
>+        }
>+        .x {
>+            position: absolute;
>+            -webkit-clip-path: polygon(0% 0%, 0% 8%, 42% 50%, 0% 92%, 0% 100%, 8% 100%, 50% 58%, 92% 100%, 100% 100%, 100% 92%, 58% 50%, 100% 8%, 100% 0%, 92% 0%, 50% 42%, 8% 0%);
>+        }
>+        #x {
>+            background-color:white;
>+        }
>+        .plus {
>+            position: absolute;
>+            -webkit-clip-path: polygon(45% 0%, 55% 0%, 55% 45%, 100% 45%, 100% 55%, 55% 55%, 55% 100%, 45% 100%, 45% 55%, 0% 55%, 0% 45%, 45% 45%);
>+        }
>+        #plus {
>+            background-color:white;
>+        }
>+        
>+    </style>
>+</head>
>+<body>
>+    <div>
>+        <div class="box">
>+            <div id="topleft"></div>
>+            <div id="topright"></div>
>+            <div id="bottomleft"></div>
>+            <div id="bottomright"></div>
>+        </div>
>+        <div id="x" class="x"></div>
>+        <div id="plus" class="plus"></div>
>+    </div>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/gradients/conic-gradient-alpha.html b/LayoutTests/fast/gradients/conic-gradient-alpha.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..ff9a16375092916cb5190cb844194fbabd61a54c
>--- /dev/null
>+++ b/LayoutTests/fast/gradients/conic-gradient-alpha.html
>@@ -0,0 +1,56 @@
>+<html>
>+<head>
>+<style>
>+    svg {
>+        width: 800px;
>+        display: none;
>+    }
>+    div {
>+        width: 200px;
>+        height: 200px;
>+    }
>+    #gradient {
>+        position: absolute;
>+        width: 200px;
>+        height: 200px;
>+        background-image: conic-gradient(rgba(0,255,0,0), black);
>+        filter: url(#posterize);
>+    }
>+
>+    .x {
>+        position: absolute;
>+        -webkit-clip-path: polygon(0% 0%, 0% 8%, 42% 50%, 0% 92%, 0% 100%, 8% 100%, 50% 58%, 92% 100%, 100% 100%, 100% 92%, 58% 50%, 100% 8%, 100% 0%, 92% 0%, 50% 42%, 8% 0%);
>+    }
>+    #x {
>+        background-color:white;
>+    }
>+    .plus {
>+        position: absolute;
>+        -webkit-clip-path: polygon(45% 0%, 55% 0%, 55% 45%, 100% 45%, 100% 55%, 55% 55%, 55% 100%, 45% 100%, 45% 55%, 0% 55%, 0% 45%, 45% 45%);
>+    }
>+    #plus {
>+        background-color:white;
>+    }
>+</style>
>+</head>
>+
>+<body>
>+<svg viewBox="0 0 700 100">
>+<defs>
>+    <filter id="posterize" filterUnits="objectBoundingBox" primitiveUnits="objectBoundingBox">
>+        <feComponentTransfer>
>+            <feFuncR type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+            <feFuncG type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+            <feFuncB type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+            <feFuncA type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+        </feComponentTransfer>
>+    </filter>
>+</defs>
>+</svg>
>+
>+<div>
>+    <div id="gradient"></div>
>+    <div id="x" class="x"></div>
>+    <div id="plus" class="plus"></div>
>+</div>
>+</html>
>diff --git a/LayoutTests/fast/gradients/conic-gradient-expected.html b/LayoutTests/fast/gradients/conic-gradient-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..322e16986a2439899a5b09c22aed7cfa5a8e3292
>--- /dev/null
>+++ b/LayoutTests/fast/gradients/conic-gradient-expected.html
>@@ -0,0 +1,66 @@
>+<html>
>+<head>
>+    <style>
>+        div {
>+            width: 200px;
>+            height: 200px;
>+            float: left;
>+        }
>+        #topleft {
>+            width: 0; 
>+            height: 0; 
>+            border-left: 100px solid rgb(0,32,0);
>+            border-top: 100px solid rgb(0,0,0);
>+        }
>+        #topright {
>+            width: 0; 
>+            height: 0; 
>+            border-right: 100px solid rgb(0,192,0);
>+            border-top: 100px solid rgb(0,224,0);
>+        }
>+        #bottomleft {
>+            clear: left;
>+            width: 0; 
>+            height: 0; 
>+            border-left: 100px solid rgb(0,64,0);
>+            border-bottom: 100px solid rgb(0,96,0);
>+        }
>+        #bottomright {
>+            width: 0; 
>+            height: 0; 
>+            border-right: 100px solid rgb(0,160,0);
>+            border-bottom: 100px solid rgb(0,128,0);
>+        }
>+        .box {
>+            position: absolute;
>+        }
>+        .x {
>+            position: absolute;
>+            -webkit-clip-path: polygon(0% 0%, 0% 5%, 45% 50%, 0% 95%, 0% 100%, 5% 100%, 50% 55%, 95% 100%, 100% 100%, 100% 95%, 55% 50%, 100% 5%, 100% 0%, 95% 0%, 50% 45%, 5% 0%);
>+        }
>+        #x {
>+            background-color:black;
>+        }
>+        .plus {
>+            position: absolute;
>+            -webkit-clip-path: polygon(45% 0%, 55% 0%, 55% 45%, 100% 45%, 100% 55%, 55% 55%, 55% 100%, 45% 100%, 45% 55%, 0% 55%, 0% 45%, 45% 45%);
>+        }
>+        #plus {
>+            background-color:black;
>+        }
>+        
>+    </style>
>+</head>
>+<body>
>+    <div>
>+        <div class="box">
>+            <div id="topleft"></div>
>+            <div id="topright"></div>
>+            <div id="bottomleft"></div>
>+            <div id="bottomright"></div>
>+        </div>
>+        <div id="x" class="x"></div>
>+        <div id="plus" class="plus"></div>
>+    </div>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html b/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..f9260b4c0db609477d7517c2395b0964dd7b7bf0
>--- /dev/null
>+++ b/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html
>@@ -0,0 +1,66 @@
>+<html>
>+<head>
>+    <style>
>+        div {
>+            width: 200px;
>+            height: 200px;
>+            float: left;
>+        }
>+        #topleft {
>+            width: 0; 
>+            height: 0; 
>+            border-left: 100px solid rgb(0,80,0);
>+            border-top: 100px solid rgb(0,64,0);
>+        }
>+        #topright {
>+            width: 0; 
>+            height: 0; 
>+            border-right: 100px solid rgb(0,160,0);
>+            border-top: 100px solid rgb(0,176,0);
>+        }
>+        #bottomleft {
>+            clear: left;
>+            width: 0; 
>+            height: 0; 
>+            border-left: 100px solid rgb(0,96,0);
>+            border-bottom: 100px solid rgb(0,112,0);
>+        }
>+        #bottomright {
>+            width: 0; 
>+            height: 0; 
>+            border-right: 100px solid rgb(0,144,0);
>+            border-bottom: 100px solid rgb(0,128,0);
>+        }
>+        .box {
>+            position: absolute;
>+        }
>+        .x {
>+            position: absolute;
>+            -webkit-clip-path: polygon(0% 0%, 0% 5%, 45% 50%, 0% 95%, 0% 100%, 5% 100%, 50% 55%, 95% 100%, 100% 100%, 100% 95%, 55% 50%, 100% 5%, 100% 0%, 95% 0%, 50% 45%, 5% 0%);
>+        }
>+        #x {
>+            background-color:black;
>+        }
>+        .plus {
>+            position: absolute;
>+            -webkit-clip-path: polygon(45% 0%, 55% 0%, 55% 45%, 100% 45%, 100% 55%, 55% 55%, 55% 100%, 45% 100%, 45% 55%, 0% 55%, 0% 45%, 45% 45%);
>+        }
>+        #plus {
>+            background-color:black;
>+        }
>+        
>+    </style>
>+</head>
>+<body>
>+    <div>
>+        <div class="box">
>+            <div id="topleft"></div>
>+            <div id="topright"></div>
>+            <div id="bottomleft"></div>
>+            <div id="bottomright"></div>
>+        </div>
>+        <div id="x" class="x"></div>
>+        <div id="plus" class="plus"></div>
>+    </div>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/gradients/conic-gradient-extended-stops.html b/LayoutTests/fast/gradients/conic-gradient-extended-stops.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..1bd4b59180ddfc5e1751255e09f45f25f00170ab
>--- /dev/null
>+++ b/LayoutTests/fast/gradients/conic-gradient-extended-stops.html
>@@ -0,0 +1,55 @@
>+<html>
>+<head>
>+<style>
>+    svg {
>+        width: 800px;
>+        display: none;
>+    }
>+    div {
>+        width: 200px;
>+        height: 200px;
>+    }
>+    #gradient {
>+        position: absolute;
>+        width: 200px;
>+        height: 200px;
>+        background-image: conic-gradient(lime -180deg, black 540deg);
>+        filter: url(#posterize);
>+    }
>+
>+    .x {
>+        position: absolute;
>+        -webkit-clip-path: polygon(0% 0%, 0% 5%, 45% 50%, 0% 95%, 0% 100%, 5% 100%, 50% 55%, 95% 100%, 100% 100%, 100% 95%, 55% 50%, 100% 5%, 100% 0%, 95% 0%, 50% 45%, 5% 0%);
>+    }
>+    #x {
>+        background-color:black;
>+    }
>+    .plus {
>+        position: absolute;
>+        -webkit-clip-path: polygon(45% 0%, 55% 0%, 55% 45%, 100% 45%, 100% 55%, 55% 55%, 55% 100%, 45% 100%, 45% 55%, 0% 55%, 0% 45%, 45% 45%);
>+    }
>+    #plus {
>+        background-color:black;
>+    }
>+</style>
>+</head>
>+
>+<body>
>+<svg viewBox="0 0 700 100">
>+<defs>
>+    <filter id="posterize" filterUnits="objectBoundingBox" primitiveUnits="objectBoundingBox">
>+        <feComponentTransfer>
>+            <feFuncR type="discrete" tableValues="0 0.0625 0.125 0.1875 0.25 0.3125 0.375 0.4375 0.5 0.5625 0.625 0.6875 0.75 0.8125 0.875 0.9375"/>
>+            <feFuncG type="discrete" tableValues="0 0.0625 0.125 0.1875 0.25 0.3125 0.375 0.4375 0.5 0.5625 0.625 0.6875 0.75 0.8125 0.875 0.9375"/>
>+            <feFuncB type="discrete" tableValues="0 0.0625 0.125 0.1875 0.25 0.3125 0.375 0.4375 0.5 0.5625 0.625 0.6875 0.75 0.8125 0.875 0.9375"/>
>+        </feComponentTransfer>
>+    </filter>
>+</defs>
>+</svg>
>+
>+<div>
>+    <div id="gradient"></div>
>+    <div id="x" class="x"></div>
>+    <div id="plus" class="plus"></div>
>+</div>
>+</html>
>diff --git a/LayoutTests/fast/gradients/conic-gradient.html b/LayoutTests/fast/gradients/conic-gradient.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..73847024f9139ad103f3a97cb43b3a91bc6e1bab
>--- /dev/null
>+++ b/LayoutTests/fast/gradients/conic-gradient.html
>@@ -0,0 +1,55 @@
>+<html>
>+<head>
>+<style>
>+    svg {
>+        width: 800px;
>+        display: none;
>+    }
>+    div {
>+        width: 200px;
>+        height: 200px;
>+    }
>+    #gradient {
>+        position: absolute;
>+        width: 200px;
>+        height: 200px;
>+        background-image: conic-gradient(lime, black);
>+        filter: url(#posterize);
>+    }
>+
>+    .x {
>+        position: absolute;
>+        -webkit-clip-path: polygon(0% 0%, 0% 5%, 45% 50%, 0% 95%, 0% 100%, 5% 100%, 50% 55%, 95% 100%, 100% 100%, 100% 95%, 55% 50%, 100% 5%, 100% 0%, 95% 0%, 50% 45%, 5% 0%);
>+    }
>+    #x {
>+        background-color:black;
>+    }
>+    .plus {
>+        position: absolute;
>+        -webkit-clip-path: polygon(45% 0%, 55% 0%, 55% 45%, 100% 45%, 100% 55%, 55% 55%, 55% 100%, 45% 100%, 45% 55%, 0% 55%, 0% 45%, 45% 45%);
>+    }
>+    #plus {
>+        background-color:black;
>+    }
>+</style>
>+</head>
>+
>+<body>
>+<svg viewBox="0 0 700 100">
>+<defs>
>+    <filter id="posterize" filterUnits="objectBoundingBox" primitiveUnits="objectBoundingBox">
>+        <feComponentTransfer>
>+            <feFuncR type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+            <feFuncG type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+            <feFuncB type="discrete" tableValues="0 0.125 0.25 0.375 0.5 0.625 0.75 0.875"/>
>+        </feComponentTransfer>
>+    </filter>
>+</defs>
>+</svg>
>+
>+<div>
>+    <div id="gradient"></div>
>+    <div id="x" class="x"></div>
>+    <div id="plus" class="plus"></div>
>+</div>
>+</html>
>diff --git a/LayoutTests/platform/ios-12/TestExpectations b/LayoutTests/platform/ios-12/TestExpectations
>index 362cd87a06c09f5464d60c84da8b22dd68f374c9..6e4cce01f2db1c7bdf12f4ac1bdb1c32b9d37b0d 100644
>--- a/LayoutTests/platform/ios-12/TestExpectations
>+++ b/LayoutTests/platform/ios-12/TestExpectations
>@@ -32,4 +32,7 @@ fast/gradients/conic.html [ Pass ]
> fast/gradients/conic-off-center.html [ Pass ]
> fast/gradients/conic-center-outside-box.html [ Pass ]
> fast/gradients/conic-extended-stops.html [ Pass ]
>-fast/gradients/conic-from-angle.html [ Pass ]
>\ No newline at end of file
>+fast/gradients/conic-from-angle.html [ Pass ]
>+fast/gradients/conic-gradient-alpha.html [ Pass ]
>+fast/gradients/conic-gradient-extended-stops.html [ Pass ]
>+fast/gradients/conic-gradient.html [ Pass ]
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 52af06c224e68ea8d7e841c91227b323c2c57d86..fc5f0a2a69f6e80506d64163f36fff06ac636eeb 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1764,3 +1764,7 @@ webkit.org/b/187393 imported/w3c/web-platform-tests/2dcontext/imagebitmap/create
> [ Mojave+ ] fast/gradients/conic-center-outside-box.html [ Pass ]
> [ Mojave+ ] fast/gradients/conic-extended-stops.html [ Pass ]
> [ Mojave+ ] fast/gradients/conic-from-angle.html [ Pass ]
>+[ Mojave+ ] fast/gradients/conic-gradient-alpha.html [ Pass ]
>+[ Mojave+ ] fast/gradients/conic-gradient-extended-stops.html [ Pass ]
>+[ Mojave+ ] fast/gradients/conic-gradient.html [ Pass ]
>+

Actions: View | Formatted Diff | Diff

Attachments on bug 189566: 349592 | 349613 | 349716 | 349812