Attachment 349690 Details for Bug 187545 – Patch

[patch] Patch

bug-187545-20180913121904.patch (text/plain), 1.53 KB, created by Sihui Liu on 2018-09-13 12:19:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-09-13 12:19:06 PDT

Size: 1.53 KB

patch

obsolete

>Subversion Revision: 235862
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 90577d93183fd5ce2e249bbcb375ee359100b0d2..c0e911008ff6617d0fb426d7e74e6425a62001f7 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-13  Sihui Liu  <sihui_liu@apple.com>
>+
>+        JavaScript mouseover events triggered when app is in background
>+        https://bugs.webkit.org/show_bug.cgi?id=187545
>+        <rdar://problem/42401575>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Don't send mouse event to webpage if view's window is not acitive.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::handleMouseEvent):
>+
> 2018-09-10  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Arrow keys do not dispatch DOM events to non-editable elements
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index e28310ba60a928337a08f7693d8edc9156eba436..e65966f6786fbbb5db4eee2d5f6cde845dc46f59 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -1940,6 +1940,9 @@ void WebPageProxy::handleMouseEvent(const NativeWebMouseEvent& event)
>     if (!isValid())
>         return;
> 
>+    if (!isViewWindowActive())
>+        return;
>+
>     // If we receive multiple mousemove or mouseforcechanged events and the most recent mousemove or mouseforcechanged event
>     // (respectively) has not yet been sent to WebProcess for processing, remove the pending mouse event and insert the new
>     // event in the queue.

Actions: View | Formatted Diff | Diff

Attachments on bug 187545: 349690 | 349743 | 349748 | 349750 | 349752 | 349753 | 349754 | 349762 | 349765 | 349768 | 349770 | 349774 | 349786 | 349788 | 349789 | 349790 | 349805 | 349824 | 349825 | 349836 | 349876 | 349878 | 349936 | 349993 | 350266