Attachment 349677 Details for Bug 189569 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

resize-1.patch (text/plain), 1.68 KB, created by Joseph Pecoraro on 2018-09-13 10:24:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-09-13 10:24:27 PDT

Size: 1.68 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9c34e79a609..2a3b3b39a62 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-09-13  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Opening inspector with a selected element might immediately scroll that element off screen in the DOM Tree outline
>+        https://bugs.webkit.org/show_bug.cgi?id=189569
>+        <rdar://problem/44397098>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DOMTreeContentView.js:
>+        (WI.DOMTreeContentView.prototype.layout):
>+        Re-select the selected DOM node in the DOM Tree when the view resizes.
>+        Typically this can happen if the sidebar opens/closes/resizes, in which
>+        case we will want the selected DOM node to stay in view even if the DOM
>+        tree starts wrapping earlier content.
>+
> 2018-09-11  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: fix test case failures in js-isLikelyStackTrace.html
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js b/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
>index 8d99ffc0472..2d4306ddf4c 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
>@@ -348,6 +348,9 @@ WI.DOMTreeContentView = class DOMTreeContentView extends WI.ContentView
>     layout()
>     {
>         this._domTreeOutline.updateSelection();
>+
>+        if (this.layoutReason === WI.View.LayoutReason.Resize)
>+            this._domTreeOutline.selectDOMNode(this._domTreeOutline.selectedDOMNode());
>     }
> 
>     // Private

Actions: View | Formatted Diff | Diff

Attachments on bug 189569: 349597 | 349625 | 349677 | 349691