Attachment 349676 Details for Bug 189588 – Patch

[patch] Patch

bug-189588-20180913201043.patch (text/plain), 1.64 KB, created by Adrian Perez on 2018-09-13 10:10:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2018-09-13 10:10:44 PDT

Size: 1.64 KB

patch

obsolete

>Subversion Revision: 235975
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e0b90ceb73f3fc56b24112632d5f0478b8e3e9e9..e865af8cc663934cc780e68b77b88dc3f5e2d392 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-13  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [WPE][GTK] Docs for WebKitWebView::load-failed do not tell which kind of errors are reported
>+        https://bugs.webkit.org/show_bug.cgi?id=189588
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/glib/WebKitWebView.cpp:
>+        (webkit_web_view_class_init): Indicate in the documentation the possible error domains.
>+
> 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
>diff --git a/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp b/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
>index 0fa4a18f89c8c51a4540778f5ae27bea87d7b5f1..3209351a342920c22df2f3c266e6ea43d8811142 100644
>--- a/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
>+++ b/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
>@@ -1184,6 +1184,9 @@ static void webkit_web_view_class_init(WebKitWebViewClass* webViewClass)
>      * By default, if the signal is not handled, a stock error page will be displayed.
>      * You need to handle the signal if you want to provide your own error page.
>      *
>+     * The possible domains for the @error are #WEBKIT_NETWORK_ERROR,
>+     * #WEBKIT_PLUGIN_ERROR, and #SOUP_HTTP_ERROR.
>+     *
>      * Returns: %TRUE to stop other handlers from being invoked for the event.
>      *    %FALSE to propagate the event further.
>      */

Flags:

mcatanzaro: review-
mcatanzaro: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189588: 349676