Attachment 349670 Details for Bug 189587 – Patch

[patch] Patch

bug-189587-20180913084151.patch (text/plain), 1.43 KB, created by Chris Dumez on 2018-09-13 08:41:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-09-13 08:41:52 PDT

Size: 1.43 KB

patch

obsolete

>Subversion Revision: 235973
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e0b90ceb73f3fc56b24112632d5f0478b8e3e9e9..9392a7562cf381c8e8f54eef6430d86f0a677e50 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-13  Chris Dumez  <cdumez@apple.com>
>+
>+        Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
>+        https://bugs.webkit.org/show_bug.cgi?id=189587
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
>+        as this is causing crashes on the bots.
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::didCompletePageTransition):
>+
> 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index 0559674b6080206fc61c2c64777874be1afe8a21..14769b8ee0cca154460e6afdb55283f84a351943 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -2870,7 +2870,8 @@ void WebPage::didStartPageTransition()
> 
> void WebPage::didCompletePageTransition()
> {
>-    m_drawingArea->setLayerTreeStateIsFrozen(false);
>+    if (m_drawingArea)
>+        m_drawingArea->setLayerTreeStateIsFrozen(false);
> }
> 
> void WebPage::show()

Actions: View | Formatted Diff | Diff

Attachments on bug 189587: 349670