Attachment 349664 Details for Bug 189585 – Patch

[patch] Patch

bug-189585-20180913162730.patch (text/plain), 1.74 KB, created by Ms2ger (he/him; ⌚ UTC+1/+2) on 2018-09-13 07:27:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ms2ger (he/him; ⌚ UTC+1/+2)

Created: 2018-09-13 07:27:32 PDT

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 235970
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f024f6b73f371ab33db786c71111c6a47a774f40..1a238ce6763231399de7908f7c91632c88f74a8e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-09-13  Ms2ger  <Ms2ger@igalia.com>
>+
>+        [GLib] Fix format string in KeyedEncoderGlib::beginObject().
>+        https://bugs.webkit.org/show_bug.cgi?id=189585
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This appears to fix the following assertion locally:
>+
>+        GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed
>+
>+        Covered by existing tests.
>+
>+        * platform/glib/KeyedEncoderGlib.cpp:
>+        (WebCore::KeyedEncoderGlib::beginObject):
>+
> 2018-09-11  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html hits assertion
>diff --git a/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp b/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp
>index 9d182fae917dcf247ddfd764e7d6cefddd5e385a..7404bcbd449aa4921b8ce2b7e01844950106f680 100644
>--- a/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp
>+++ b/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp
>@@ -98,7 +98,7 @@ void KeyedEncoderGlib::encodeString(const String& key, const String& value)
> 
> void KeyedEncoderGlib::beginObject(const String& key)
> {
>-    GRefPtr<GVariantBuilder> builder = adoptGRef(g_variant_builder_new(G_VARIANT_TYPE("aa{sv}")));
>+    GRefPtr<GVariantBuilder> builder = adoptGRef(g_variant_builder_new(G_VARIANT_TYPE("a{sv}")));
>     m_objectStack.append(std::make_pair(key, builder));
>     m_variantBuilderStack.append(builder.get());
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 189585: 349664