WebKit Bugzilla
Attachment 349660 Details for
Bug 189579
: Build error in ImageBufferCG when compiled with IOSurfacePool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Quick hack to work around the issue
a.patch (text/plain), 1.55 KB, created by
Frédéric Wang (:fredw)
on 2018-09-13 06:25:14 PDT
(
hide
)
Description:
Quick hack to work around the issue
Filename:
MIME Type:
Creator:
Frédéric Wang (:fredw)
Created:
2018-09-13 06:25:14 PDT
Size:
1.55 KB
patch
obsolete
>diff --git a/Source/WebCore/platform/graphics/cocoa/IOSurface.h b/Source/WebCore/platform/graphics/cocoa/IOSurface.h >index 3f68ecf96f..e49421b40d 100644 >--- a/Source/WebCore/platform/graphics/cocoa/IOSurface.h >+++ b/Source/WebCore/platform/graphics/cocoa/IOSurface.h >@@ -89,9 +89,9 @@ public: > static std::unique_ptr<IOSurface> createFromSurface(IOSurfaceRef, CGColorSpaceRef); > WEBCORE_EXPORT static std::unique_ptr<IOSurface> createFromImage(CGImageRef); > >-#if USE(IOSURFACE_CANVAS_BACKING_STORE) >+ //#if USE(IOSURFACE_CANVAS_BACKING_STORE) > static std::unique_ptr<IOSurface> createFromImageBuffer(std::unique_ptr<ImageBuffer>); >-#endif >+ //#endif > > WEBCORE_EXPORT static void moveToPool(std::unique_ptr<IOSurface>&&); > >diff --git a/Source/WebCore/platform/graphics/cocoa/IOSurface.mm b/Source/WebCore/platform/graphics/cocoa/IOSurface.mm >index f821ee071f..b318742740 100644 >--- a/Source/WebCore/platform/graphics/cocoa/IOSurface.mm >+++ b/Source/WebCore/platform/graphics/cocoa/IOSurface.mm >@@ -108,12 +108,12 @@ void IOSurface::moveToPool(std::unique_ptr<IOSurface>&& surface) > IOSurfacePool::sharedPool().addSurface(WTFMove(surface)); > } > >-#if USE(IOSURFACE_CANVAS_BACKING_STORE) >+//#if USE(IOSURFACE_CANVAS_BACKING_STORE) > std::unique_ptr<IOSurface> IOSurface::createFromImageBuffer(std::unique_ptr<ImageBuffer> imageBuffer) > { > return WTFMove(imageBuffer->m_data.surface); > } >-#endif >+//#endif > > static NSDictionary *optionsForBiplanarSurface(IntSize size, unsigned pixelFormat, size_t firstPlaneBytesPerPixel, size_t secondPlaneBytesPerPixel) > {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189579
: 349660 |
349673
|
349757