Attachment 349643 Details for Bug 189578 – Patch

[patch] Patch

bug-189578-20180913171157.patch (text/plain), 2.20 KB, created by Fujii Hironori on 2018-09-13 01:11:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-13 01:11:59 PDT

Size: 2.20 KB

patch

obsolete

>Subversion Revision: 235967
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f024f6b73f371ab33db786c71111c6a47a774f40..ca756b92f6b02124343f04a0ab085bffdf4e159b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-09-13  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        Remove a MSVC workaround in XPath::Step::NodeTest
>+        https://bugs.webkit.org/show_bug.cgi?id=189578
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        XPath::Step::NodeTest has a special code for MSVC bug workaround.
>+        It has been introduced in 5 years ago in Bug 121082 Comment 19.
>+
>+        I think it is safe just to remove the workaround.
>+
>+        No new tests (No behavior change).
>+
>+        * xml/XPathStep.h: Removed the MSVC workaround.
>+
> 2018-09-11  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html hits assertion
>diff --git a/Source/WebCore/xml/XPathStep.h b/Source/WebCore/xml/XPathStep.h
>index d2ef5bb0088ccadb1015d4634806044e5eaacd58..0e5fd629cda2d70cf499322f9e290714baa256b6 100644
>--- a/Source/WebCore/xml/XPathStep.h
>+++ b/Source/WebCore/xml/XPathStep.h
>@@ -58,27 +58,6 @@ public:
>         NodeTest(Kind kind, const AtomicString& data) : m_kind(kind), m_data(data) { }
>         NodeTest(Kind kind, const AtomicString& data, const AtomicString& namespaceURI) : m_kind(kind), m_data(data), m_namespaceURI(namespaceURI) { }
> 
>-#if COMPILER(MSVC)
>-        NodeTest(const NodeTest&);
>-        void operator=(const NodeTest&);
>-
>-        NodeTest(NodeTest&& other)
>-            : m_kind(other.m_kind)
>-            , m_data(WTFMove(other.m_data))
>-            , m_namespaceURI(WTFMove(other.m_namespaceURI))
>-            , m_mergedPredicates(WTFMove(other.m_mergedPredicates))
>-        {
>-        }
>-        NodeTest& operator=(NodeTest&& other)
>-        {
>-            m_kind = other.m_kind;
>-            m_data = WTFMove(other.m_data);
>-            m_namespaceURI = WTFMove(other.m_namespaceURI);
>-            m_mergedPredicates = WTFMove(other.m_mergedPredicates);
>-            return *this;
>-        }
>-#endif
>-
>     private:
>         friend class Step;
>         friend void optimizeStepPair(Step&, Step&, bool&);

Actions: View | Formatted Diff | Diff

Attachments on bug 189578: 349643 | 349661