Attachment 349641 Details for Bug 189577 – Patch

[patch] Patch

bug-189577-20180913165657.patch (text/plain), 2.05 KB, created by Fujii Hironori on 2018-09-13 00:56:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-13 00:56:58 PDT

Size: 2.05 KB

patch

obsolete

>Subversion Revision: 235967
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f024f6b73f371ab33db786c71111c6a47a774f40..cf5fdd8e55dd0fa88a98e144efa8b8d8861b4d4c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-13  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        Remove a MSVC workaround in InspectorStyle::styleWithProperties
>+        https://bugs.webkit.org/show_bug.cgi?id=189577
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (No behavior change).
>+
>+        * inspector/InspectorStyleSheet.cpp:
>+        (WebCore::InspectorStyle::styleWithProperties const): Use 'auto' for the type of 'status'.
>+
> 2018-09-11  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html hits assertion
>diff --git a/Source/WebCore/inspector/InspectorStyleSheet.cpp b/Source/WebCore/inspector/InspectorStyleSheet.cpp
>index 9d985819cb3d442463ab751c696d4dc9f05632cf..75b4688c83cb25e90222a4c3270df89ee0e39b4c 100644
>--- a/Source/WebCore/inspector/InspectorStyleSheet.cpp
>+++ b/Source/WebCore/inspector/InspectorStyleSheet.cpp
>@@ -634,13 +634,7 @@ Ref<Inspector::Protocol::CSS::CSSStyle> InspectorStyle::styleWithProperties() co
>         const CSSPropertySourceData& propertyEntry = it->sourceData;
>         const String& name = propertyEntry.name;
> 
>-        // Visual Studio disagrees with other compilers as to whether 'class' is needed here.
>-#if COMPILER(MSVC)
>-        enum class Protocol::CSS::CSSPropertyStatus status;
>-#else
>-        enum Inspector::Protocol::CSS::CSSPropertyStatus status;
>-#endif
>-        status = it->disabled ? Inspector::Protocol::CSS::CSSPropertyStatus::Disabled : Inspector::Protocol::CSS::CSSPropertyStatus::Active;
>+        auto status = it->disabled ? Inspector::Protocol::CSS::CSSPropertyStatus::Disabled : Inspector::Protocol::CSS::CSSPropertyStatus::Active;
> 
>         RefPtr<Inspector::Protocol::CSS::CSSProperty> property = Inspector::Protocol::CSS::CSSProperty::create()
>             .setName(name.convertToASCIILowercase())

Actions: View | Formatted Diff | Diff

Attachments on bug 189577: 349641 | 349653