Attachment 349628 Details for Bug 189575 – Patch

[patch] Patch

bug-189575-20180913142516.patch (text/plain), 1.82 KB, created by Fujii Hironori on 2018-09-12 22:25:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-12 22:25:17 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 235966
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f024f6b73f371ab33db786c71111c6a47a774f40..ab013c339d44f5f4bfed8779e1c2607ad9955f67 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] error: type 'float' cannot be narrowed to 'LONG' (aka 'long') in initializer list in WheelEventWin.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=189575
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (No behavior change).
>+
>+        * platform/win/WheelEventWin.cpp:
>+        (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use flooredIntPoint to convert FloatPoint to POINT.
>+
> 2018-09-11  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html hits assertion
>diff --git a/Source/WebCore/platform/win/WheelEventWin.cpp b/Source/WebCore/platform/win/WheelEventWin.cpp
>index c24aed18e543e20f13e46651c7873c8b6c45a29c..3d9046fa4ddba19f754d74a2bf6cbdd3623bc4b6 100644
>--- a/Source/WebCore/platform/win/WheelEventWin.cpp
>+++ b/Source/WebCore/platform/win/WheelEventWin.cpp
>@@ -83,12 +83,12 @@ PlatformWheelEvent::PlatformWheelEvent(HWND hWnd, const FloatSize& delta, const
>     m_wheelTicksY = m_deltaY;
> 
>     // Global Position is just x, y location of event
>-    POINT point = {location.x(), location.y()};
>     float inverseScaleFactor = 1.0f / deviceScaleFactorForWindow(hWnd);
>-    m_globalPosition = point;
>+    m_globalPosition = flooredIntPoint(location);
>     m_globalPosition.scale(inverseScaleFactor, inverseScaleFactor);
> 
>     // Position needs to be translated to our client
>+    POINT point;
>     ScreenToClient(hWnd, &point);
>     m_position = point;
>     m_position.scale(inverseScaleFactor, inverseScaleFactor);

Actions: View | Formatted Diff | Diff

Attachments on bug 189575: 349628